1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
|
// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/ui/zoom/zoom_controller.h"
#include "base/prefs/pref_service.h"
#include "base/process/kill.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/browser/ui/webui/signin/login_ui_test_utils.h"
#include "chrome/browser/ui/zoom/chrome_zoom_level_prefs.h"
#include "chrome/common/url_constants.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
#include "components/signin/core/common/profile_management_switches.h"
#include "content/public/browser/host_zoom_map.h"
#include "content/public/browser/navigation_entry.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/browser/render_view_host.h"
#include "content/public/browser/web_contents.h"
#include "content/public/common/page_type.h"
#include "content/public/test/browser_test_utils.h"
#include "testing/gmock/include/gmock/gmock.h"
using ui_zoom::ZoomController;
using ui_zoom::ZoomObserver;
bool operator==(const ZoomController::ZoomChangedEventData& lhs,
const ZoomController::ZoomChangedEventData& rhs) {
return lhs.web_contents == rhs.web_contents &&
lhs.old_zoom_level == rhs.old_zoom_level &&
lhs.new_zoom_level == rhs.new_zoom_level &&
lhs.zoom_mode == rhs.zoom_mode &&
lhs.can_show_bubble == rhs.can_show_bubble;
}
class ZoomChangedWatcher : public ZoomObserver {
public:
ZoomChangedWatcher(
content::WebContents* web_contents,
const ZoomController::ZoomChangedEventData& expected_event_data)
: expected_event_data_(expected_event_data),
message_loop_runner_(new content::MessageLoopRunner) {
ZoomController::FromWebContents(web_contents)->AddObserver(this);
}
~ZoomChangedWatcher() override {}
void Wait() { message_loop_runner_->Run(); }
void OnZoomChanged(
const ZoomController::ZoomChangedEventData& event_data) override {
if (event_data == expected_event_data_)
message_loop_runner_->Quit();
}
private:
ZoomController::ZoomChangedEventData expected_event_data_;
scoped_refptr<content::MessageLoopRunner> message_loop_runner_;
DISALLOW_COPY_AND_ASSIGN(ZoomChangedWatcher);
};
class ZoomControllerBrowserTest : public InProcessBrowserTest {
public:
ZoomControllerBrowserTest() {}
~ZoomControllerBrowserTest() override {}
void TestResetOnNavigation(ZoomController::ZoomMode zoom_mode) {
DCHECK(zoom_mode == ZoomController::ZOOM_MODE_ISOLATED ||
zoom_mode == ZoomController::ZOOM_MODE_MANUAL);
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
ui_test_utils::NavigateToURLBlockUntilNavigationsComplete(
browser(), GURL("about:blank"), 1);
ZoomController* zoom_controller =
ZoomController::FromWebContents(web_contents);
double zoom_level = zoom_controller->GetDefaultZoomLevel();
zoom_controller->SetZoomMode(zoom_mode);
// When the navigation occurs, the zoom_mode will be reset to
// ZOOM_MODE_DEFAULT, and this will be reflected in the event that
// is generated.
ZoomController::ZoomChangedEventData zoom_change_data(
web_contents, zoom_level, zoom_level, ZoomController::ZOOM_MODE_DEFAULT,
false);
ZoomChangedWatcher zoom_change_watcher(web_contents, zoom_change_data);
ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUISettingsURL));
zoom_change_watcher.Wait();
}
}; // ZoomControllerBrowserTest
#if defined(OS_ANDROID)
#define MAYBE_CrashedTabsDoNotChangeZoom DISABLED_CrashedTabsDoNotChangeZoom
#else
#define MAYBE_CrashedTabsDoNotChangeZoom CrashedTabsDoNotChangeZoom
#endif
IN_PROC_BROWSER_TEST_F(ZoomControllerBrowserTest,
MAYBE_CrashedTabsDoNotChangeZoom) {
// At the start of the test we are at a tab displaying about:blank.
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
ZoomController* zoom_controller =
ZoomController::FromWebContents(web_contents);
double old_zoom_level = zoom_controller->GetZoomLevel();
double new_zoom_level = old_zoom_level + 0.5;
content::RenderProcessHost* host = web_contents->GetRenderProcessHost();
{
content::RenderProcessHostWatcher crash_observer(
host, content::RenderProcessHostWatcher::WATCH_FOR_PROCESS_EXIT);
host->Shutdown(0, false);
crash_observer.Wait();
}
EXPECT_FALSE(web_contents->GetRenderViewHost()->IsRenderViewLive());
// The following attempt to change the zoom level for a crashed tab should
// fail.
zoom_controller->SetZoomLevel(new_zoom_level);
EXPECT_FLOAT_EQ(old_zoom_level, zoom_controller->GetZoomLevel());
}
IN_PROC_BROWSER_TEST_F(ZoomControllerBrowserTest, OnPreferenceChanged) {
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
double new_default_zoom_level = 1.0;
// Since this page uses the default zoom level, the changes to the default
// zoom level will change the zoom level for this web_contents.
ZoomController::ZoomChangedEventData zoom_change_data(
web_contents,
new_default_zoom_level,
new_default_zoom_level,
ZoomController::ZOOM_MODE_DEFAULT,
false);
ZoomChangedWatcher zoom_change_watcher(web_contents, zoom_change_data);
// TODO(wjmaclean): Convert this to call partition-specific zoom level prefs
// when they become available.
browser()->profile()->GetZoomLevelPrefs()->SetDefaultZoomLevelPref(
new_default_zoom_level);
// Because this test relies on a round-trip IPC to/from the renderer process,
// we need to wait for it to propagate.
zoom_change_watcher.Wait();
}
IN_PROC_BROWSER_TEST_F(ZoomControllerBrowserTest, ErrorPagesCanZoom) {
ui_test_utils::NavigateToURL(browser(), GURL("http://kjfhkjsdf.com"));
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
ZoomController* zoom_controller =
ZoomController::FromWebContents(web_contents);
EXPECT_EQ(
content::PAGE_TYPE_ERROR,
web_contents->GetController().GetLastCommittedEntry()->GetPageType());
double old_zoom_level = zoom_controller->GetZoomLevel();
double new_zoom_level = old_zoom_level + 0.5;
// The following attempt to change the zoom level for an error page should
// fail.
zoom_controller->SetZoomLevel(new_zoom_level);
EXPECT_FLOAT_EQ(new_zoom_level, zoom_controller->GetZoomLevel());
}
IN_PROC_BROWSER_TEST_F(ZoomControllerBrowserTest,
ErrorPagesCanZoomAfterTabRestore) {
// This url is meant to cause a network error page to be loaded.
// Tests can't reach the network, so this test should continue
// to work even if the domain listed is someday registered.
GURL url("http://kjfhkjsdf.com");
TabStripModel* tab_strip = browser()->tab_strip_model();
ASSERT_TRUE(tab_strip);
ui_test_utils::NavigateToURLWithDisposition(
browser(), url, NEW_FOREGROUND_TAB,
ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
{
content::WebContents* web_contents = tab_strip->GetActiveWebContents();
EXPECT_EQ(
content::PAGE_TYPE_ERROR,
web_contents->GetController().GetLastCommittedEntry()->GetPageType());
content::WebContentsDestroyedWatcher destroyed_watcher(web_contents);
tab_strip->CloseWebContentsAt(tab_strip->active_index(),
TabStripModel::CLOSE_CREATE_HISTORICAL_TAB);
destroyed_watcher.Wait();
}
EXPECT_EQ(1, tab_strip->count());
content::WebContentsAddedObserver new_web_contents_observer;
chrome::RestoreTab(browser());
content::WebContents* web_contents =
new_web_contents_observer.GetWebContents();
content::WaitForLoadStop(web_contents);
EXPECT_EQ(2, tab_strip->count());
EXPECT_EQ(
content::PAGE_TYPE_ERROR,
web_contents->GetController().GetLastCommittedEntry()->GetPageType());
ZoomController* zoom_controller =
ZoomController::FromWebContents(web_contents);
double old_zoom_level = zoom_controller->GetZoomLevel();
double new_zoom_level = old_zoom_level + 0.5;
// The following attempt to change the zoom level for an error page should
// fail.
zoom_controller->SetZoomLevel(new_zoom_level);
EXPECT_FLOAT_EQ(new_zoom_level, zoom_controller->GetZoomLevel());
}
IN_PROC_BROWSER_TEST_F(ZoomControllerBrowserTest, Observe) {
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
double new_zoom_level = 1.0;
// When the event is initiated from HostZoomMap, the old zoom level is not
// available.
ZoomController::ZoomChangedEventData zoom_change_data(
web_contents,
new_zoom_level,
new_zoom_level,
ZoomController::ZOOM_MODE_DEFAULT,
false); // The ZoomController did not initiate, so this will be 'false'.
ZoomChangedWatcher zoom_change_watcher(web_contents, zoom_change_data);
content::HostZoomMap* host_zoom_map =
content::HostZoomMap::GetDefaultForBrowserContext(
web_contents->GetBrowserContext());
host_zoom_map->SetZoomLevelForHost("about:blank", new_zoom_level);
zoom_change_watcher.Wait();
}
IN_PROC_BROWSER_TEST_F(ZoomControllerBrowserTest, ObserveDisabledModeEvent) {
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
ZoomController* zoom_controller =
ZoomController::FromWebContents(web_contents);
double default_zoom_level = zoom_controller->GetDefaultZoomLevel();
double new_zoom_level = default_zoom_level + 1.0;
zoom_controller->SetZoomLevel(new_zoom_level);
ZoomController::ZoomChangedEventData zoom_change_data(
web_contents,
new_zoom_level,
default_zoom_level,
ZoomController::ZOOM_MODE_DISABLED,
true);
ZoomChangedWatcher zoom_change_watcher(web_contents, zoom_change_data);
zoom_controller->SetZoomMode(ZoomController::ZOOM_MODE_DISABLED);
zoom_change_watcher.Wait();
}
IN_PROC_BROWSER_TEST_F(ZoomControllerBrowserTest, PerTabModeResetSendsEvent) {
TestResetOnNavigation(ZoomController::ZOOM_MODE_ISOLATED);
}
// Regression test: crbug.com/450909.
IN_PROC_BROWSER_TEST_F(ZoomControllerBrowserTest, NavigationResetsManualMode) {
TestResetOnNavigation(ZoomController::ZOOM_MODE_MANUAL);
}
#if !defined(OS_CHROMEOS)
// Regression test: crbug.com/438979.
IN_PROC_BROWSER_TEST_F(ZoomControllerBrowserTest,
SettingsZoomAfterSigninWorks) {
GURL signin_url(
std::string(chrome::kChromeUIChromeSigninURL).append("?source=0"));
// We open the signin page in a new tab so that the ZoomController is
// created against the HostZoomMap of the special StoragePartition that
// backs the signin page. When we subsequently navigate away from the
// signin page, the HostZoomMap changes, and we need to test that the
// ZoomController correctly detects this.
ui_test_utils::NavigateToURLWithDisposition(
browser(), signin_url, NEW_FOREGROUND_TAB,
ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
login_ui_test_utils::WaitUntilUIReady(browser());
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
EXPECT_NE(
content::PAGE_TYPE_ERROR,
web_contents->GetController().GetLastCommittedEntry()->GetPageType());
EXPECT_EQ(signin_url, web_contents->GetLastCommittedURL());
ZoomController* zoom_controller =
ZoomController::FromWebContents(web_contents);
content::HostZoomMap* host_zoom_map_signin =
content::HostZoomMap::GetForWebContents(web_contents);
GURL settings_url(chrome::kChromeUISettingsURL);
ui_test_utils::NavigateToURL(browser(), settings_url);
EXPECT_NE(
content::PAGE_TYPE_ERROR,
web_contents->GetController().GetLastCommittedEntry()->GetPageType());
// Verify new tab was created.
EXPECT_EQ(2, browser()->tab_strip_model()->count());
// Verify that the settings page is using the same WebContents.
EXPECT_EQ(web_contents, browser()->tab_strip_model()->GetActiveWebContents());
// TODO(wjmaclean): figure out why this next line fails, i.e. why does this
// test not properly trigger a navigation to the settings page.
EXPECT_EQ(settings_url, web_contents->GetLastCommittedURL());
EXPECT_EQ(zoom_controller, ZoomController::FromWebContents(web_contents));
// For the webview based sign-in code, the sign in page uses the default host
// zoom map.
if (!switches::IsEnableWebviewBasedSignin()) {
// We expect the navigation from the chrome sign in page to the settings
// page to invoke a storage partition switch, and thus a different
// HostZoomMap for the web_contents.
content::HostZoomMap* host_zoom_map_settings =
content::HostZoomMap::GetForWebContents(web_contents);
EXPECT_NE(host_zoom_map_signin, host_zoom_map_settings);
}
// If we zoom the new page, it should still generate a ZoomController event.
double old_zoom_level = zoom_controller->GetZoomLevel();
double new_zoom_level = old_zoom_level + 0.5;
ZoomController::ZoomChangedEventData zoom_change_data(
web_contents,
old_zoom_level,
new_zoom_level,
ZoomController::ZOOM_MODE_DEFAULT,
true); // We have a non-empty host, so this will be 'true'.
ZoomChangedWatcher zoom_change_watcher(web_contents, zoom_change_data);
zoom_controller->SetZoomLevel(new_zoom_level);
zoom_change_watcher.Wait();
}
#endif // !defined(OS_CHROMEOS)
|