1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
|
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
#include "base/command_line.h"
#include "base/strings/string_util.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/extensions/api/commands/commands_handler.h"
#include "chrome/common/extensions/features/feature_channel.h"
#include "extensions/common/manifest_constants.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace extensions {
namespace errors = manifest_errors;
class CommandsManifestTest : public ExtensionManifestTest {
};
TEST_F(CommandsManifestTest, CommandManifestSimple) {
#if defined(OS_MACOSX)
int ctrl = ui::EF_COMMAND_DOWN;
#else
int ctrl = ui::EF_CONTROL_DOWN;
#endif
const ui::Accelerator ctrl_f = ui::Accelerator(ui::VKEY_F, ctrl);
const ui::Accelerator ctrl_shift_f =
ui::Accelerator(ui::VKEY_F, ctrl | ui::EF_SHIFT_DOWN);
const ui::Accelerator alt_shift_f =
ui::Accelerator(ui::VKEY_F, ui::EF_ALT_DOWN | ui::EF_SHIFT_DOWN);
scoped_refptr<Extension> extension =
LoadAndExpectSuccess("command_simple.json");
ASSERT_TRUE(extension.get());
const CommandMap* commands = CommandsInfo::GetNamedCommands(extension.get());
ASSERT_TRUE(commands);
ASSERT_EQ(1u, commands->size());
CommandMap::const_iterator iter = commands->begin();
ASSERT_TRUE(commands->end() != iter);
const Command* named_command = &(*iter).second;
ASSERT_STREQ("feature1", named_command->command_name().c_str());
ASSERT_STREQ("desc", UTF16ToASCII(named_command->description()).c_str());
ASSERT_EQ(ctrl_shift_f, named_command->accelerator());
const Command* browser_action =
CommandsInfo::GetBrowserActionCommand(extension.get());
ASSERT_TRUE(NULL != browser_action);
ASSERT_STREQ("_execute_browser_action",
browser_action->command_name().c_str());
ASSERT_STREQ("", UTF16ToASCII(browser_action->description()).c_str());
ASSERT_EQ(alt_shift_f, browser_action->accelerator());
const Command* page_action =
CommandsInfo::GetPageActionCommand(extension.get());
ASSERT_TRUE(NULL != page_action);
ASSERT_STREQ("_execute_page_action",
page_action->command_name().c_str());
ASSERT_STREQ("", UTF16ToASCII(page_action->description()).c_str());
ASSERT_EQ(ctrl_f, page_action->accelerator());
}
TEST_F(CommandsManifestTest, CommandManifestShortcutsTooMany) {
LoadAndExpectError("command_too_many.json",
errors::kInvalidKeyBindingTooMany);
}
TEST_F(CommandsManifestTest, CommandManifestManyButWithinBounds) {
scoped_refptr<Extension> extension =
LoadAndExpectSuccess("command_many_but_shortcuts_under_limit.json");
}
TEST_F(CommandsManifestTest, CommandManifestAllowNumbers) {
scoped_refptr<Extension> extension =
LoadAndExpectSuccess("command_allow_numbers.json");
}
TEST_F(CommandsManifestTest, CommandManifestRejectJustShift) {
LoadAndExpectError("command_reject_just_shift.json",
errors::kInvalidKeyBinding);
}
TEST_F(CommandsManifestTest, BrowserActionSynthesizesCommand) {
scoped_refptr<Extension> extension =
LoadAndExpectSuccess("browser_action_synthesizes_command.json");
// An extension with a browser action but no extension command specified
// should get a command assigned to it.
const extensions::Command* command =
CommandsInfo::GetBrowserActionCommand(extension.get());
ASSERT_TRUE(command != NULL);
ASSERT_EQ(ui::VKEY_UNKNOWN, command->accelerator().key_code());
}
// This test makes sure that the "commands" feature and the "commands.global"
// property behave as expected on dev and stable (enabled and working on dev,
// not working on stable).
TEST_F(CommandsManifestTest, ChannelTests) {
// This tests the following combinations.
// Ext+Command Stable : OK.
// Ext+Command+Global Stable : Property is silently ignored (expect success).
// App+Command Stable : NOT OK.
// App+Command+Global Stable : NOT OK.
{
std::string warning = "'commands' requires Google Chrome dev channel or "
"newer, but this is the stable channel.";
ScopedCurrentChannel channel(chrome::VersionInfo::CHANNEL_STABLE);
scoped_refptr<Extension> extension1 =
LoadAndExpectSuccess("command_ext.json");
scoped_refptr<Extension> extension2 =
LoadAndExpectSuccess("command_ext_global.json");
LoadAndExpectWarning("command_app.json", warning);
LoadAndExpectWarning("command_app_global.json", warning);
}
// Ext+Command Dev : OK.
// App+Command Dev : OK.
// Ext+Command+Global Dev : OK.
// App+Command+Global Dev : OK.
{
ScopedCurrentChannel channel(chrome::VersionInfo::CHANNEL_DEV);
scoped_refptr<Extension> extension1 =
LoadAndExpectSuccess("command_ext.json");
scoped_refptr<Extension> extension2 =
LoadAndExpectSuccess("command_app.json");
scoped_refptr<Extension> extension3 =
LoadAndExpectSuccess("command_ext_global.json");
scoped_refptr<Extension> extension4 =
LoadAndExpectSuccess("command_app_global.json");
}
}
} // namespace extensions
|
