1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
|
// Copyright (c) 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <string>
#include <vector>
#include "base/file_path.h"
#include "base/stl_util.h"
#include "base/utf_string_conversions.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/extension_builder.h"
#include "chrome/common/extensions/manifest_handler.h"
#include "chrome/common/extensions/value_builder.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace extensions {
class ManifestHandlerTest : public testing::Test {
public:
class ParsingWatcher {
public:
// Called when a manifest handler parses.
void Record(const std::string& name) {
parsed_names_.push_back(name);
}
const std::vector<std::string>& parsed_names() {
return parsed_names_;
}
// Returns true if |name_before| was parsed before |name_after|.
bool ParsedBefore(const std::string& name_before,
const std::string& name_after) {
size_t i_before = parsed_names_.size();
size_t i_after = 0;
for (size_t i = 0; i < parsed_names_.size(); ++i) {
if (parsed_names_[i] == name_before)
i_before = i;
if (parsed_names_[i] == name_after)
i_after = i;
}
if (i_before < i_after)
return true;
return false;
}
private:
// The order of manifest handlers that we watched parsing.
std::vector<std::string> parsed_names_;
};
class TestManifestHandler : public ManifestHandler {
public:
TestManifestHandler(const std::string& name,
const std::vector<std::string>& prereqs,
ParsingWatcher* watcher)
: name_(name), prereqs_(prereqs), watcher_(watcher) {
}
virtual bool Parse(Extension* extension, string16* error) OVERRIDE {
watcher_->Record(name_);
return true;
}
virtual const std::vector<std::string>& PrerequisiteKeys() OVERRIDE {
return prereqs_;
}
protected:
std::string name_;
std::vector<std::string> prereqs_;
ParsingWatcher* watcher_;
};
class FailingTestManifestHandler : public TestManifestHandler {
public:
FailingTestManifestHandler(const std::string& name,
const std::vector<std::string> prereqs,
ParsingWatcher* watcher)
: TestManifestHandler(name, prereqs, watcher) {
}
virtual bool Parse(Extension* extension, string16* error) OVERRIDE {
*error = ASCIIToUTF16(name_);
return false;
}
};
class AlwaysParseTestManifestHandler : public TestManifestHandler {
public:
AlwaysParseTestManifestHandler(const std::string& name,
const std::vector<std::string> prereqs,
ParsingWatcher* watcher)
: TestManifestHandler(name, prereqs, watcher) {
}
virtual bool AlwaysParseForType(Manifest::Type type) OVERRIDE {
return true;
}
};
protected:
virtual void SetUp() OVERRIDE {
ManifestHandler::ClearRegistryForTesting();
}
};
TEST_F(ManifestHandlerTest, DependentHandlers) {
ParsingWatcher watcher;
std::vector<std::string> prereqs;
ManifestHandler::Register(
"a", make_linked_ptr(new TestManifestHandler("A", prereqs, &watcher)));
ManifestHandler::Register(
"b", make_linked_ptr(new TestManifestHandler("B", prereqs, &watcher)));
ManifestHandler::Register(
"j", make_linked_ptr(new TestManifestHandler("J", prereqs, &watcher)));
ManifestHandler::Register(
"k", make_linked_ptr(
new AlwaysParseTestManifestHandler("K", prereqs, &watcher)));
prereqs.push_back("c.d");
linked_ptr<TestManifestHandler> handler_c2(
new TestManifestHandler("C.EZ", prereqs, &watcher));
ManifestHandler::Register("c.e", handler_c2);
ManifestHandler::Register("c.z", handler_c2);
prereqs.clear();
prereqs.push_back("b");
prereqs.push_back("k");
ManifestHandler::Register(
"c.d", make_linked_ptr(new TestManifestHandler(
"C.D", prereqs, &watcher)));
scoped_refptr<Extension> extension = ExtensionBuilder()
.SetManifest(DictionaryBuilder()
.Set("name", "no name")
.Set("version", "0")
.Set("manifest_version", 2)
.Set("a", 1)
.Set("b", 2)
.Set("c", DictionaryBuilder()
.Set("d", 3)
.Set("e", 4)
.Set("f", 5))
.Set("g", 6))
.Build();
// A, B, C.EZ, C.D, K
EXPECT_EQ(5u, watcher.parsed_names().size());
EXPECT_TRUE(watcher.ParsedBefore("B", "C.D"));
EXPECT_TRUE(watcher.ParsedBefore("K", "C.D"));
EXPECT_TRUE(watcher.ParsedBefore("C.D", "C.EZ"));
}
TEST_F(ManifestHandlerTest, FailingHandlers) {
// Can't use ExtensionBuilder, because this extension will fail to
// be parsed.
scoped_ptr<base::DictionaryValue> manifest_a(
DictionaryBuilder()
.Set("name", "no name")
.Set("version", "0")
.Set("manifest_version", 2)
.Set("a", 1)
.Build());
// Succeeds when "a" is not recognized.
std::string error;
scoped_refptr<Extension> extension = Extension::Create(
base::FilePath(),
Manifest::INVALID_LOCATION,
*manifest_a,
Extension::NO_FLAGS,
&error);
EXPECT_TRUE(extension);
// Register a handler for "a" that fails.
ParsingWatcher watcher;
ManifestHandler::Register(
"a", make_linked_ptr(new FailingTestManifestHandler(
"A", std::vector<std::string>(), &watcher)));
extension = Extension::Create(
base::FilePath(),
Manifest::INVALID_LOCATION,
*manifest_a,
Extension::NO_FLAGS,
&error);
EXPECT_FALSE(extension);
EXPECT_EQ("A", error);
}
} // namespace extensions
|
