1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
|
// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <set>
#include "base/file_util.h"
#include "base/path_service.h"
#include "base/scoped_temp_dir.h"
#include "base/string_util.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/zip.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
namespace {
// Make the test a PlatformTest to setup autorelease pools properly on Mac.
class ZipTest : public PlatformTest {
protected:
virtual void SetUp() {
PlatformTest::SetUp();
ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
test_dir_ = temp_dir_.path();
FilePath zip_path(test_dir_);
zip_contents_.insert(zip_path.AppendASCII("foo.txt"));
zip_path = zip_path.AppendASCII("foo");
zip_contents_.insert(zip_path);
zip_contents_.insert(zip_path.AppendASCII("bar.txt"));
zip_path = zip_path.AppendASCII("bar");
zip_contents_.insert(zip_path);
zip_contents_.insert(zip_path.AppendASCII("baz.txt"));
zip_contents_.insert(zip_path.AppendASCII("quux.txt"));
zip_contents_.insert(zip_path.AppendASCII(".hidden"));
}
virtual void TearDown() {
PlatformTest::TearDown();
}
void TestUnzipFile(const FilePath::StringType& filename,
bool expect_hidden_files) {
FilePath test_dir;
ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &test_dir));
test_dir = test_dir.AppendASCII("zip");
TestUnzipFile(test_dir.Append(filename), expect_hidden_files);
}
void TestUnzipFile(const FilePath& path, bool expect_hidden_files) {
ASSERT_TRUE(file_util::PathExists(path)) << "no file " << path.value();
ASSERT_TRUE(zip::Unzip(path, test_dir_));
file_util::FileEnumerator files(test_dir_, true,
static_cast<file_util::FileEnumerator::FileType>(
file_util::FileEnumerator::FILES |
file_util::FileEnumerator::DIRECTORIES));
FilePath next_path = files.Next();
size_t count = 0;
while (!next_path.value().empty()) {
if (next_path.value().find(FILE_PATH_LITERAL(".svn")) ==
FilePath::StringType::npos) {
EXPECT_EQ(zip_contents_.count(next_path), 1U) <<
"Couldn't find " << next_path.value();
count++;
}
next_path = files.Next();
}
size_t expected_count = 0;
for (std::set<FilePath>::iterator iter = zip_contents_.begin();
iter != zip_contents_.end(); ++iter) {
if (expect_hidden_files || iter->BaseName().value()[0] != '.')
++expected_count;
}
EXPECT_EQ(expected_count, count);
}
// the path to temporary directory used to contain the test operations
FilePath test_dir_;
ScopedTempDir temp_dir_;
// hard-coded contents of a known zip file
std::set<FilePath> zip_contents_;
};
TEST_F(ZipTest, Unzip) {
TestUnzipFile(FILE_PATH_LITERAL("test.zip"), true);
}
TEST_F(ZipTest, UnzipUncompressed) {
TestUnzipFile(FILE_PATH_LITERAL("test_nocompress.zip"), true);
}
TEST_F(ZipTest, UnzipEvil) {
FilePath path;
ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &path));
path = path.AppendASCII("zip").AppendASCII("evil.zip");
// Unzip the zip file into a sub directory of test_dir_ so evil.zip
// won't create a persistent file outside test_dir_ in case of a
// failure.
FilePath output_dir = test_dir_.AppendASCII("out");
ASSERT_FALSE(zip::Unzip(path, output_dir));
FilePath evil_file = output_dir;
evil_file = evil_file.AppendASCII(
"../levilevilevilevilevilevilevilevilevilevilevilevil");
ASSERT_FALSE(file_util::PathExists(evil_file));
}
TEST_F(ZipTest, UnzipEvil2) {
FilePath path;
ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &path));
// The zip file contains an evil file with invalid UTF-8 in its file
// name.
path = path.AppendASCII("zip").AppendASCII("evil_via_invalid_utf8.zip");
// See the comment at UnzipEvil() for why we do this.
FilePath output_dir = test_dir_.AppendASCII("out");
// This should fail as it contains an evil file.
ASSERT_FALSE(zip::Unzip(path, output_dir));
FilePath evil_file = output_dir;
evil_file = evil_file.AppendASCII("../evil.txt");
ASSERT_FALSE(file_util::PathExists(evil_file));
}
TEST_F(ZipTest, Zip) {
FilePath src_dir;
ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &src_dir));
src_dir = src_dir.AppendASCII("zip").AppendASCII("test");
ScopedTempDir temp_dir;
ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
FilePath zip_file = temp_dir.path().AppendASCII("out.zip");
EXPECT_TRUE(zip::Zip(src_dir, zip_file, true));
TestUnzipFile(zip_file, true);
}
TEST_F(ZipTest, ZipIgnoreHidden) {
FilePath src_dir;
ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &src_dir));
src_dir = src_dir.AppendASCII("zip").AppendASCII("test");
ScopedTempDir temp_dir;
ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
FilePath zip_file = temp_dir.path().AppendASCII("out.zip");
EXPECT_TRUE(zip::Zip(src_dir, zip_file, false));
TestUnzipFile(zip_file, false);
}
} // namespace
|
