1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
|
// Copyright (c) 2010 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// Note: this test uses RenderViewFakeResourcesTest in order to set up a
// real RenderThread to hold the phishing Scorer object.
#include "chrome/renderer/safe_browsing/phishing_classifier_delegate.h"
#include "base/scoped_ptr.h"
#include "base/utf_string_conversions.h"
#include "chrome/common/safebrowsing_messages.h"
#include "chrome/renderer/render_view.h"
#include "chrome/renderer/safe_browsing/features.h"
#include "chrome/renderer/safe_browsing/phishing_classifier.h"
#include "chrome/renderer/safe_browsing/render_view_fake_resources_test.h"
#include "chrome/renderer/safe_browsing/scorer.h"
#include "googleurl/src/gurl.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebURL.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebURLRequest.h"
using ::testing::_;
using ::testing::DeleteArg;
using ::testing::Mock;
using ::testing::Pointee;
using ::testing::StrictMock;
namespace safe_browsing {
namespace {
class MockPhishingClassifier : public PhishingClassifier {
public:
explicit MockPhishingClassifier(RenderView* render_view)
: PhishingClassifier(render_view, NULL /* clock */) {}
virtual ~MockPhishingClassifier() {}
MOCK_METHOD2(BeginClassification, void(const string16*, DoneCallback*));
MOCK_METHOD0(CancelPendingClassification, void());
private:
DISALLOW_COPY_AND_ASSIGN(MockPhishingClassifier);
};
class MockScorer : public Scorer {
public:
MockScorer() : Scorer() {}
virtual ~MockScorer() {}
MOCK_CONST_METHOD1(ComputeScore, double(const FeatureMap&));
private:
DISALLOW_COPY_AND_ASSIGN(MockScorer);
};
} // namespace
class PhishingClassifierDelegateTest : public RenderViewFakeResourcesTest {
protected:
bool OnMessageReceived(const IPC::Message& message) {
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(PhishingClassifierDelegateTest, message)
IPC_MESSAGE_HANDLER(SafeBrowsingDetectionHostMsg_DetectedPhishingSite,
OnDetectedPhishingSite)
IPC_MESSAGE_UNHANDLED(
handled = RenderViewFakeResourcesTest::OnMessageReceived(message))
IPC_END_MESSAGE_MAP()
return handled;
}
void OnDetectedPhishingSite(GURL phishing_url, double phishing_score) {
detected_phishing_site_ = true;
detected_url_ = phishing_url;
detected_score_ = phishing_score;
message_loop_.Quit();
}
// Runs the ClassificationDone callback, then waits for the
// DetectedPhishingSite IPC to arrive.
void RunClassificationDone(PhishingClassifierDelegate* delegate,
bool is_phishy, double phishy_score) {
// Clear out any previous state.
detected_phishing_site_ = false;
detected_url_ = GURL();
detected_score_ = -1.0;
delegate->ClassificationDone(is_phishy, phishy_score);
message_loop_.Run();
}
void OnStartPhishingDetection(PhishingClassifierDelegate* delegate,
const GURL& url) {
delegate->OnStartPhishingDetection(url);
}
bool detected_phishing_site_;
GURL detected_url_;
double detected_score_;
};
TEST_F(PhishingClassifierDelegateTest, Navigation) {
MockPhishingClassifier* classifier =
new StrictMock<MockPhishingClassifier>(view_);
PhishingClassifierDelegate* delegate =
new PhishingClassifierDelegate(view_, classifier);
MockScorer scorer;
delegate->SetPhishingScorer(&scorer);
ASSERT_TRUE(classifier->is_ready());
// Test an initial load. We expect classification to happen normally.
EXPECT_CALL(*classifier, CancelPendingClassification()).Times(2);
responses_["http://host.com/"] =
"<html><body><iframe src=\"http://sub1.com/\"></iframe></body></html>";
LoadURL("http://host.com/");
Mock::VerifyAndClearExpectations(classifier);
OnStartPhishingDetection(delegate, GURL("http://host.com/"));
string16 page_text = ASCIIToUTF16("dummy");
EXPECT_CALL(*classifier, BeginClassification(Pointee(page_text), _)).
WillOnce(DeleteArg<1>());
delegate->PageCaptured(page_text);
Mock::VerifyAndClearExpectations(classifier);
// Reloading the same page should not trigger a reclassification.
// However, it will cancel any pending classification since the
// content is being replaced.
EXPECT_CALL(*classifier, CancelPendingClassification()).Times(2);
GetMainFrame()->reload();
message_loop_.Run();
Mock::VerifyAndClearExpectations(classifier);
OnStartPhishingDetection(delegate, GURL("http://host.com/"));
delegate->PageCaptured(page_text);
// Navigating in a subframe will increment the page id, but not change
// the toplevel URL. This should cancel pending classification since the
// page content is changing, and not begin a new classification.
EXPECT_CALL(*classifier, CancelPendingClassification());
GetMainFrame()->firstChild()->loadRequest(
WebKit::WebURLRequest(GURL("http://sub2.com/")));
message_loop_.Run();
Mock::VerifyAndClearExpectations(classifier);
OnStartPhishingDetection(delegate, GURL("http://host.com/"));
delegate->PageCaptured(page_text);
// Scrolling to an anchor will increment the page id, but should not
// not trigger a reclassification. A pending classification should not
// be cancelled, since the content is not changing.
LoadURL("http://host.com/#foo");
OnStartPhishingDetection(delegate, GURL("http://host.com/#foo"));
delegate->PageCaptured(page_text);
// Now load a new toplevel page, which should trigger another classification.
EXPECT_CALL(*classifier, CancelPendingClassification());
LoadURL("http://host2.com/");
Mock::VerifyAndClearExpectations(classifier);
page_text = ASCIIToUTF16("dummy2");
EXPECT_CALL(*classifier, BeginClassification(Pointee(page_text), _)).
WillOnce(DeleteArg<1>());
OnStartPhishingDetection(delegate, GURL("http://host2.com/"));
delegate->PageCaptured(page_text);
Mock::VerifyAndClearExpectations(classifier);
// No classification should happen on back/forward navigation.
// Note: in practice, the browser will not send a StartPhishingDetection IPC
// in this case. However, we want to make sure that the delegate behaves
// correctly regardless.
EXPECT_CALL(*classifier, CancelPendingClassification());
GoBack();
Mock::VerifyAndClearExpectations(classifier);
page_text = ASCIIToUTF16("dummy");
OnStartPhishingDetection(delegate, GURL("http://host.com/#foo"));
delegate->PageCaptured(page_text);
// The delegate will cancel pending classification on destruction.
EXPECT_CALL(*classifier, CancelPendingClassification());
}
TEST_F(PhishingClassifierDelegateTest, NoScorer) {
// For this test, we'll create the delegate with no scorer available yet.
MockPhishingClassifier* classifier =
new StrictMock<MockPhishingClassifier>(view_);
PhishingClassifierDelegate* delegate =
new PhishingClassifierDelegate(view_, classifier);
ASSERT_FALSE(classifier->is_ready());
// Queue up a pending classification, cancel it, then queue up another one.
LoadURL("http://host.com/");
string16 page_text = ASCIIToUTF16("dummy");
OnStartPhishingDetection(delegate, GURL("http://host.com/"));
delegate->PageCaptured(page_text);
LoadURL("http://host2.com/");
page_text = ASCIIToUTF16("dummy2");
OnStartPhishingDetection(delegate, GURL("http://host2.com/"));
delegate->PageCaptured(page_text);
// Now set a scorer, which should cause a classifier to be created and
// the classification to proceed. Note that we need to reset |page_text|
// since it is modified by the call to PageCaptured().
page_text = ASCIIToUTF16("dummy2");
EXPECT_CALL(*classifier, BeginClassification(Pointee(page_text), _)).
WillOnce(DeleteArg<1>());
MockScorer scorer;
delegate->SetPhishingScorer(&scorer);
Mock::VerifyAndClearExpectations(classifier);
// The delegate will cancel pending classification on destruction.
EXPECT_CALL(*classifier, CancelPendingClassification());
}
TEST_F(PhishingClassifierDelegateTest, NoScorer_Ref) {
// Similar to the last test, but navigates within the page before
// setting the scorer.
MockPhishingClassifier* classifier =
new StrictMock<MockPhishingClassifier>(view_);
PhishingClassifierDelegate* delegate =
new PhishingClassifierDelegate(view_, classifier);
ASSERT_FALSE(classifier->is_ready());
// Queue up a pending classification, cancel it, then queue up another one.
LoadURL("http://host.com/");
string16 page_text = ASCIIToUTF16("dummy");
OnStartPhishingDetection(delegate, GURL("http://host.com/"));
delegate->PageCaptured(page_text);
LoadURL("http://host.com/#foo");
OnStartPhishingDetection(delegate, GURL("http://host.com/#foo"));
delegate->PageCaptured(page_text);
// Now set a scorer, which should cause a classifier to be created and
// the classification to proceed.
EXPECT_CALL(*classifier, BeginClassification(Pointee(page_text), _)).
WillOnce(DeleteArg<1>());
MockScorer scorer;
delegate->SetPhishingScorer(&scorer);
Mock::VerifyAndClearExpectations(classifier);
// The delegate will cancel pending classification on destruction.
EXPECT_CALL(*classifier, CancelPendingClassification());
}
TEST_F(PhishingClassifierDelegateTest, NoStartPhishingDetection) {
// Tests the behavior when OnStartPhishingDetection has not yet been called
// when the page load finishes.
MockPhishingClassifier* classifier =
new StrictMock<MockPhishingClassifier>(view_);
PhishingClassifierDelegate* delegate =
new PhishingClassifierDelegate(view_, classifier);
MockScorer scorer;
delegate->SetPhishingScorer(&scorer);
ASSERT_TRUE(classifier->is_ready());
EXPECT_CALL(*classifier, CancelPendingClassification());
responses_["http://host.com/"] = "<html><body>phish</body></html>";
LoadURL("http://host.com/");
Mock::VerifyAndClearExpectations(classifier);
string16 page_text = ASCIIToUTF16("phish");
delegate->PageCaptured(page_text);
// Now simulate the StartPhishingDetection IPC. We expect classification
// to begin.
EXPECT_CALL(*classifier, BeginClassification(Pointee(page_text), _)).
WillOnce(DeleteArg<1>());
OnStartPhishingDetection(delegate, GURL("http://host.com/"));
Mock::VerifyAndClearExpectations(classifier);
// Now try again, but this time we will navigate the page away before
// the IPC is sent.
EXPECT_CALL(*classifier, CancelPendingClassification());
responses_["http://host2.com/"] = "<html><body>phish</body></html>";
LoadURL("http://host2.com/");
delegate->PageCaptured(page_text);
EXPECT_CALL(*classifier, CancelPendingClassification());
responses_["http://host3.com/"] = "<html><body>phish</body></html>";
LoadURL("http://host3.com/");
Mock::VerifyAndClearExpectations(classifier);
OnStartPhishingDetection(delegate, GURL("http://host2.com/"));
// The delegate will cancel pending classification on destruction.
EXPECT_CALL(*classifier, CancelPendingClassification());
}
TEST_F(PhishingClassifierDelegateTest, DetectedPhishingSite) {
// Tests that a DetectedPhishingSite IPC is sent to the browser
// if a site comes back as phishy.
MockPhishingClassifier* classifier =
new StrictMock<MockPhishingClassifier>(view_);
PhishingClassifierDelegate* delegate =
new PhishingClassifierDelegate(view_, classifier);
MockScorer scorer;
delegate->SetPhishingScorer(&scorer);
ASSERT_TRUE(classifier->is_ready());
// Start by loading a page to populate the delegate's state.
responses_["http://host.com/"] = "<html><body>phish</body></html>";
EXPECT_CALL(*classifier, CancelPendingClassification());
LoadURL("http://host.com/");
Mock::VerifyAndClearExpectations(classifier);
string16 page_text = ASCIIToUTF16("phish");
EXPECT_CALL(*classifier, BeginClassification(Pointee(page_text), _)).
WillOnce(DeleteArg<1>());
OnStartPhishingDetection(delegate, GURL("http://host.com/"));
delegate->PageCaptured(page_text);
Mock::VerifyAndClearExpectations(classifier);
// Now run the callback to simulate the classifier finishing.
RunClassificationDone(delegate, true, 0.8);
EXPECT_TRUE(detected_phishing_site_);
EXPECT_EQ(GURL("http://host.com/"), detected_url_);
EXPECT_EQ(0.8, detected_score_);
// The delegate will cancel pending classification on destruction.
EXPECT_CALL(*classifier, CancelPendingClassification());
}
} // namespace safe_browsing
|
