1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
|
// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/command_line.h"
#include "base/message_loop/message_loop.h"
#include "base/strings/utf_string_conversions.h"
#include "components/metrics/proto/omnibox_event.pb.h"
#include "components/omnibox/autocomplete_match.h"
#include "components/omnibox/autocomplete_scheme_classifier.h"
#include "components/omnibox/keyword_provider.h"
#include "components/search_engines/search_engines_switches.h"
#include "components/search_engines/template_url.h"
#include "components/search_engines/template_url_service.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
using base::ASCIIToUTF16;
namespace {
class TestingSchemeClassifier : public AutocompleteSchemeClassifier {
public:
metrics::OmniboxInputType::Type GetInputTypeForScheme(
const std::string& scheme) const override {
if (net::URLRequest::IsHandledProtocol(scheme))
return metrics::OmniboxInputType::URL;
return metrics::OmniboxInputType::INVALID;
}
};
} // namespace
class KeywordProviderTest : public testing::Test {
protected:
template<class ResultType>
struct MatchType {
const ResultType member;
bool allowed_to_be_default_match;
};
template<class ResultType>
struct TestData {
const base::string16 input;
const size_t num_results;
const MatchType<ResultType> output[3];
};
KeywordProviderTest() : kw_provider_(NULL) { }
~KeywordProviderTest() override {}
void SetUp() override;
void TearDown() override;
template<class ResultType>
void RunTest(TestData<ResultType>* keyword_cases,
int num_cases,
ResultType AutocompleteMatch::* member);
protected:
static const TemplateURLService::Initializer kTestData[];
scoped_refptr<KeywordProvider> kw_provider_;
scoped_ptr<TemplateURLService> model_;
};
// static
const TemplateURLService::Initializer KeywordProviderTest::kTestData[] = {
{ "aa", "aa.com?foo={searchTerms}", "aa" },
{ "aaaa", "http://aaaa/?aaaa=1&b={searchTerms}&c", "aaaa" },
{ "aaaaa", "{searchTerms}", "aaaaa" },
{ "ab", "bogus URL {searchTerms}", "ab" },
{ "weasel", "weasel{searchTerms}weasel", "weasel" },
{ "www", " +%2B?={searchTerms}foo ", "www" },
{ "nonsub", "http://nonsubstituting-keyword.com/", "nonsub" },
{ "z", "{searchTerms}=z", "z" },
};
void KeywordProviderTest::SetUp() {
model_.reset(new TemplateURLService(kTestData, arraysize(kTestData)));
kw_provider_ = new KeywordProvider(NULL, model_.get());
}
void KeywordProviderTest::TearDown() {
model_.reset();
kw_provider_ = NULL;
}
template<class ResultType>
void KeywordProviderTest::RunTest(TestData<ResultType>* keyword_cases,
int num_cases,
ResultType AutocompleteMatch::* member) {
ACMatches matches;
for (int i = 0; i < num_cases; ++i) {
SCOPED_TRACE(keyword_cases[i].input);
AutocompleteInput input(keyword_cases[i].input, base::string16::npos,
std::string(), GURL(),
metrics::OmniboxEventProto::INVALID_SPEC, true,
false, true, true, TestingSchemeClassifier());
kw_provider_->Start(input, false, false);
EXPECT_TRUE(kw_provider_->done());
matches = kw_provider_->matches();
ASSERT_EQ(keyword_cases[i].num_results, matches.size());
for (size_t j = 0; j < matches.size(); ++j) {
EXPECT_EQ(keyword_cases[i].output[j].member, matches[j].*member);
EXPECT_EQ(keyword_cases[i].output[j].allowed_to_be_default_match,
matches[j].allowed_to_be_default_match);
}
}
}
TEST_F(KeywordProviderTest, Edit) {
const MatchType<base::string16> kEmptyMatch = { base::string16(), false };
TestData<base::string16> edit_cases[] = {
// Searching for a nonexistent prefix should give nothing.
{ ASCIIToUTF16("Not Found"), 0,
{ kEmptyMatch, kEmptyMatch, kEmptyMatch } },
{ ASCIIToUTF16("aaaaaNot Found"), 0,
{ kEmptyMatch, kEmptyMatch, kEmptyMatch } },
// Check that tokenization only collapses whitespace between first tokens,
// no-query-input cases have a space appended, and action is not escaped.
{ ASCIIToUTF16("z"), 1,
{ { ASCIIToUTF16("z "), true }, kEmptyMatch, kEmptyMatch } },
{ ASCIIToUTF16("z \t"), 1,
{ { ASCIIToUTF16("z "), true }, kEmptyMatch, kEmptyMatch } },
// Check that exact, substituting keywords with a verbatim search term
// don't generate a result. (These are handled by SearchProvider.)
{ ASCIIToUTF16("z foo"), 0,
{ kEmptyMatch, kEmptyMatch, kEmptyMatch } },
{ ASCIIToUTF16("z a b c++"), 0,
{ kEmptyMatch, kEmptyMatch, kEmptyMatch } },
// Matches should be limited to three, and sorted in quality order, not
// alphabetical.
{ ASCIIToUTF16("aaa"), 2,
{ { ASCIIToUTF16("aaaa "), false },
{ ASCIIToUTF16("aaaaa "), false },
kEmptyMatch } },
{ ASCIIToUTF16("a 1 2 3"), 3,
{ { ASCIIToUTF16("aa 1 2 3"), false },
{ ASCIIToUTF16("ab 1 2 3"), false },
{ ASCIIToUTF16("aaaa 1 2 3"), false } } },
{ ASCIIToUTF16("www.a"), 3,
{ { ASCIIToUTF16("aa "), false },
{ ASCIIToUTF16("ab "), false },
{ ASCIIToUTF16("aaaa "), false } } },
// Exact matches should prevent returning inexact matches. Also, the
// verbatim query for this keyword match should not be returned. (It's
// returned by SearchProvider.)
{ ASCIIToUTF16("aaaa foo"), 0,
{ kEmptyMatch, kEmptyMatch, kEmptyMatch } },
{ ASCIIToUTF16("www.aaaa foo"), 0,
{ kEmptyMatch, kEmptyMatch, kEmptyMatch } },
// Clean up keyword input properly. "http" and "https" are the only
// allowed schemes.
{ ASCIIToUTF16("www"), 1,
{ { ASCIIToUTF16("www "), true }, kEmptyMatch, kEmptyMatch }},
{ ASCIIToUTF16("www."), 0,
{ kEmptyMatch, kEmptyMatch, kEmptyMatch } },
{ ASCIIToUTF16("www.w w"), 2,
{ { ASCIIToUTF16("www w"), false },
{ ASCIIToUTF16("weasel w"), false },
kEmptyMatch } },
{ ASCIIToUTF16("http://www"), 1,
{ { ASCIIToUTF16("www "), true }, kEmptyMatch, kEmptyMatch } },
{ ASCIIToUTF16("http://www."), 0,
{ kEmptyMatch, kEmptyMatch, kEmptyMatch } },
{ ASCIIToUTF16("ftp: blah"), 0,
{ kEmptyMatch, kEmptyMatch, kEmptyMatch } },
{ ASCIIToUTF16("mailto:z"), 0,
{ kEmptyMatch, kEmptyMatch, kEmptyMatch } },
{ ASCIIToUTF16("ftp://z"), 0,
{ kEmptyMatch, kEmptyMatch, kEmptyMatch } },
{ ASCIIToUTF16("https://z"), 1,
{ { ASCIIToUTF16("z "), true }, kEmptyMatch, kEmptyMatch } },
// Non-substituting keywords, whether typed fully or not
// should not add a space.
{ ASCIIToUTF16("nonsu"), 1,
{ { ASCIIToUTF16("nonsub"), false }, kEmptyMatch, kEmptyMatch } },
{ ASCIIToUTF16("nonsub"), 1,
{ { ASCIIToUTF16("nonsub"), true }, kEmptyMatch, kEmptyMatch } },
};
RunTest<base::string16>(edit_cases, arraysize(edit_cases),
&AutocompleteMatch::fill_into_edit);
}
TEST_F(KeywordProviderTest, URL) {
const MatchType<GURL> kEmptyMatch = { GURL(), false };
TestData<GURL> url_cases[] = {
// No query input -> empty destination URL.
{ ASCIIToUTF16("z"), 1,
{ { GURL(), true }, kEmptyMatch, kEmptyMatch } },
{ ASCIIToUTF16("z \t"), 1,
{ { GURL(), true }, kEmptyMatch, kEmptyMatch } },
// Check that tokenization only collapses whitespace between first tokens
// and query input, but not rest of URL, is escaped.
{ ASCIIToUTF16("w bar +baz"), 2,
{ { GURL(" +%2B?=bar+%2Bbazfoo "), false },
{ GURL("bar+%2Bbaz=z"), false },
kEmptyMatch } },
// Substitution should work with various locations of the "%s".
{ ASCIIToUTF16("aaa 1a2b"), 2,
{ { GURL("http://aaaa/?aaaa=1&b=1a2b&c"), false },
{ GURL("1a2b"), false },
kEmptyMatch } },
{ ASCIIToUTF16("a 1 2 3"), 3,
{ { GURL("aa.com?foo=1+2+3"), false },
{ GURL("bogus URL 1+2+3"), false },
{ GURL("http://aaaa/?aaaa=1&b=1+2+3&c"), false } } },
{ ASCIIToUTF16("www.w w"), 2,
{ { GURL(" +%2B?=wfoo "), false },
{ GURL("weaselwweasel"), false },
kEmptyMatch } },
};
RunTest<GURL>(url_cases, arraysize(url_cases),
&AutocompleteMatch::destination_url);
}
TEST_F(KeywordProviderTest, Contents) {
const MatchType<base::string16> kEmptyMatch = { base::string16(), false };
TestData<base::string16> contents_cases[] = {
// No query input -> substitute "<enter query>" into contents.
{ ASCIIToUTF16("z"), 1,
{ { ASCIIToUTF16("Search z for <enter query>"), true },
kEmptyMatch, kEmptyMatch } },
{ ASCIIToUTF16("z \t"), 1,
{ { ASCIIToUTF16("Search z for <enter query>"), true },
kEmptyMatch, kEmptyMatch } },
// Exact keyword matches with remaining text should return nothing.
{ ASCIIToUTF16("www.www www"), 0,
{ kEmptyMatch, kEmptyMatch, kEmptyMatch } },
{ ASCIIToUTF16("z a b c++"), 0,
{ kEmptyMatch, kEmptyMatch, kEmptyMatch } },
// Exact keyword matches with remaining text when the keyword is an
// extension keyword should return something. This is tested in
// chrome/browser/extensions/api/omnibox/omnibox_apitest.cc's
// in OmniboxApiTest's Basic test.
// Substitution should work with various locations of the "%s".
{ ASCIIToUTF16("aaa"), 2,
{ { ASCIIToUTF16("Search aaaa for <enter query>"), false },
{ ASCIIToUTF16("Search aaaaa for <enter query>"), false },
kEmptyMatch} },
{ ASCIIToUTF16("www.w w"), 2,
{ { ASCIIToUTF16("Search www for w"), false },
{ ASCIIToUTF16("Search weasel for w"), false },
kEmptyMatch } },
// Also, check that tokenization only collapses whitespace between first
// tokens and contents are not escaped or unescaped.
{ ASCIIToUTF16("a 1 2+ 3"), 3,
{ { ASCIIToUTF16("Search aa for 1 2+ 3"), false },
{ ASCIIToUTF16("Search ab for 1 2+ 3"), false },
{ ASCIIToUTF16("Search aaaa for 1 2+ 3"), false } } },
};
RunTest<base::string16>(contents_cases, arraysize(contents_cases),
&AutocompleteMatch::contents);
}
TEST_F(KeywordProviderTest, AddKeyword) {
TemplateURLData data;
data.short_name = ASCIIToUTF16("Test");
base::string16 keyword(ASCIIToUTF16("foo"));
data.SetKeyword(keyword);
data.SetURL("http://www.google.com/foo?q={searchTerms}");
TemplateURL* template_url = new TemplateURL(data);
model_->Add(template_url);
ASSERT_TRUE(template_url == model_->GetTemplateURLForKeyword(keyword));
}
TEST_F(KeywordProviderTest, RemoveKeyword) {
base::string16 url(ASCIIToUTF16("http://aaaa/?aaaa=1&b={searchTerms}&c"));
model_->Remove(model_->GetTemplateURLForKeyword(ASCIIToUTF16("aaaa")));
ASSERT_TRUE(model_->GetTemplateURLForKeyword(ASCIIToUTF16("aaaa")) == NULL);
}
TEST_F(KeywordProviderTest, GetKeywordForInput) {
EXPECT_EQ(ASCIIToUTF16("aa"),
kw_provider_->GetKeywordForText(ASCIIToUTF16("aa")));
EXPECT_EQ(base::string16(),
kw_provider_->GetKeywordForText(ASCIIToUTF16("aafoo")));
EXPECT_EQ(base::string16(),
kw_provider_->GetKeywordForText(ASCIIToUTF16("aa foo")));
}
TEST_F(KeywordProviderTest, GetSubstitutingTemplateURLForInput) {
struct {
const std::string text;
const size_t cursor_position;
const bool allow_exact_keyword_match;
const std::string expected_url;
const std::string updated_text;
const size_t updated_cursor_position;
} cases[] = {
{ "foo", base::string16::npos, true, "", "foo", base::string16::npos },
{ "aa foo", base::string16::npos, true, "aa.com?foo={searchTerms}", "foo",
base::string16::npos },
// Cursor adjustment.
{ "aa foo", base::string16::npos, true, "aa.com?foo={searchTerms}", "foo",
base::string16::npos },
{ "aa foo", 4u, true, "aa.com?foo={searchTerms}", "foo", 1u },
// Cursor at the end.
{ "aa foo", 6u, true, "aa.com?foo={searchTerms}", "foo", 3u },
// Cursor before the first character of the remaining text.
{ "aa foo", 3u, true, "aa.com?foo={searchTerms}", "foo", 0u },
// Trailing space.
{ "aa foo ", 7u, true, "aa.com?foo={searchTerms}", "foo ", 4u },
// Trailing space without remaining text, cursor in the middle.
{ "aa ", 3u, true, "aa.com?foo={searchTerms}", "", base::string16::npos },
// Trailing space without remaining text, cursor at the end.
{ "aa ", 4u, true, "aa.com?foo={searchTerms}", "", base::string16::npos },
// Extra space after keyword, cursor at the end.
{ "aa foo ", 8u, true, "aa.com?foo={searchTerms}", "foo ", 4u },
// Extra space after keyword, cursor in the middle.
{ "aa foo ", 3u, true, "aa.com?foo={searchTerms}", "foo ", 0 },
// Extra space after keyword, no trailing space, cursor at the end.
{ "aa foo", 7u, true, "aa.com?foo={searchTerms}", "foo", 3u },
// Extra space after keyword, no trailing space, cursor in the middle.
{ "aa foo", 5u, true, "aa.com?foo={searchTerms}", "foo", 1u },
// Disallow exact keyword match.
{ "aa foo", base::string16::npos, false, "", "aa foo",
base::string16::npos },
};
for (size_t i = 0; i < arraysize(cases); i++) {
AutocompleteInput input(
ASCIIToUTF16(cases[i].text), cases[i].cursor_position, std::string(),
GURL(), metrics::OmniboxEventProto::INVALID_SPEC, false, false,
cases[i].allow_exact_keyword_match, true, TestingSchemeClassifier());
const TemplateURL* url =
KeywordProvider::GetSubstitutingTemplateURLForInput(model_.get(),
&input);
if (cases[i].expected_url.empty())
EXPECT_FALSE(url);
else
EXPECT_EQ(cases[i].expected_url, url->url());
EXPECT_EQ(ASCIIToUTF16(cases[i].updated_text), input.text());
EXPECT_EQ(cases[i].updated_cursor_position, input.cursor_position());
}
}
// If extra query params are specified on the command line, they should be
// reflected (only) in the default search provider's destination URL.
TEST_F(KeywordProviderTest, ExtraQueryParams) {
base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
switches::kExtraSearchQueryParams, "a=b");
TestData<GURL> url_cases[] = {
{ ASCIIToUTF16("a 1 2 3"), 3,
{ { GURL("aa.com?a=b&foo=1+2+3"), false },
{ GURL("bogus URL 1+2+3"), false },
{ GURL("http://aaaa/?aaaa=1&b=1+2+3&c"), false } } },
};
RunTest<GURL>(url_cases, arraysize(url_cases),
&AutocompleteMatch::destination_url);
}
TEST_F(KeywordProviderTest, DoesNotProvideMatchesOnFocus) {
AutocompleteInput input(ASCIIToUTF16("aaa"), base::string16::npos,
std::string(), GURL(),
metrics::OmniboxEventProto::INVALID_SPEC, true,
false, true, true, TestingSchemeClassifier());
kw_provider_->Start(input, false, true);
ASSERT_TRUE(kw_provider_->matches().empty());
}
|