blob: a1532cf235901558b2a0bf9122a1fe11e8f0357a (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
|
// Copyright 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "storage/browser/fileapi/sandbox_file_system_backend_delegate.h"
#include "base/basictypes.h"
#include "base/files/file_util.h"
#include "base/files/scoped_temp_dir.h"
#include "base/memory/scoped_ptr.h"
#include "base/message_loop/message_loop.h"
#include "base/message_loop/message_loop_proxy.h"
#include "content/public/test/test_file_system_options.h"
#include "storage/browser/fileapi/file_system_url.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
using storage::FileSystemURL;
namespace content {
namespace {
FileSystemURL CreateFileSystemURL(const char* path) {
const GURL kOrigin("http://foo/");
return storage::FileSystemURL::CreateForTest(
kOrigin,
storage::kFileSystemTypeTemporary,
base::FilePath::FromUTF8Unsafe(path));
}
} // namespace
class SandboxFileSystemBackendDelegateTest : public testing::Test {
protected:
virtual void SetUp() {
ASSERT_TRUE(data_dir_.CreateUniqueTempDir());
delegate_.reset(new storage::SandboxFileSystemBackendDelegate(
NULL /* quota_manager_proxy */,
base::MessageLoopProxy::current().get(),
data_dir_.path(),
NULL /* special_storage_policy */,
CreateAllowFileAccessOptions()));
}
bool IsAccessValid(const FileSystemURL& url) const {
return delegate_->IsAccessValid(url);
}
base::ScopedTempDir data_dir_;
base::MessageLoop message_loop_;
scoped_ptr<storage::SandboxFileSystemBackendDelegate> delegate_;
};
TEST_F(SandboxFileSystemBackendDelegateTest, IsAccessValid) {
// Normal case.
EXPECT_TRUE(IsAccessValid(CreateFileSystemURL("a")));
// Access to a path with parent references ('..') should be disallowed.
EXPECT_FALSE(IsAccessValid(CreateFileSystemURL("a/../b")));
// Access from non-allowed scheme should be disallowed.
EXPECT_FALSE(IsAccessValid(
FileSystemURL::CreateForTest(GURL("unknown://bar"),
storage::kFileSystemTypeTemporary,
base::FilePath::FromUTF8Unsafe("foo"))));
// Access with restricted name should be disallowed.
EXPECT_FALSE(IsAccessValid(CreateFileSystemURL(".")));
EXPECT_FALSE(IsAccessValid(CreateFileSystemURL("..")));
// This is also disallowed due to Windows XP parent path handling.
EXPECT_FALSE(IsAccessValid(CreateFileSystemURL("...")));
// These are identified as unsafe cases due to weird path handling
// on Windows.
EXPECT_FALSE(IsAccessValid(CreateFileSystemURL(" ..")));
EXPECT_FALSE(IsAccessValid(CreateFileSystemURL(".. ")));
// Similar but safe cases.
EXPECT_TRUE(IsAccessValid(CreateFileSystemURL(" .")));
EXPECT_TRUE(IsAccessValid(CreateFileSystemURL(". ")));
EXPECT_TRUE(IsAccessValid(CreateFileSystemURL("b.")));
EXPECT_TRUE(IsAccessValid(CreateFileSystemURL(".b")));
// A path that looks like a drive letter.
EXPECT_TRUE(IsAccessValid(CreateFileSystemURL("c:")));
}
} // namespace content
|
