1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
|
// Copyright 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "content/browser/frame_host/frame_tree.h"
#include <stddef.h>
#include "base/macros.h"
#include "base/run_loop.h"
#include "base/strings/string_number_conversions.h"
#include "content/browser/frame_host/navigator_impl.h"
#include "content/browser/frame_host/render_frame_host_factory.h"
#include "content/browser/frame_host/render_frame_host_impl.h"
#include "content/browser/renderer_host/render_view_host_impl.h"
#include "content/browser/web_contents/web_contents_impl.h"
#include "content/common/frame_messages.h"
#include "content/public/browser/web_contents_observer.h"
#include "content/public/test/mock_render_process_host.h"
#include "content/public/test/test_browser_context.h"
#include "content/public/test/test_browser_thread_bundle.h"
#include "content/test/test_render_frame_host.h"
#include "content/test/test_render_view_host.h"
#include "content/test/test_web_contents.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/WebKit/public/web/WebSandboxFlags.h"
namespace content {
namespace {
// Appends a description of the structure of the frame tree to |result|.
void AppendTreeNodeState(FrameTreeNode* node, std::string* result) {
result->append(
base::Int64ToString(node->current_frame_host()->GetRoutingID()));
if (!node->current_frame_host()->IsRenderFrameLive())
result->append("*"); // Asterisk next to dead frames.
if (!node->frame_name().empty()) {
result->append(" '");
result->append(node->frame_name());
result->append("'");
}
result->append(": [");
const char* separator = "";
for (size_t i = 0; i < node->child_count(); i++) {
result->append(separator);
AppendTreeNodeState(node->child_at(i), result);
separator = ", ";
}
result->append("]");
}
// Logs calls to WebContentsObserver along with the state of the frame tree,
// for later use in EXPECT_EQ().
class TreeWalkingWebContentsLogger : public WebContentsObserver {
public:
explicit TreeWalkingWebContentsLogger(WebContents* web_contents)
: WebContentsObserver(web_contents) {}
~TreeWalkingWebContentsLogger() override {
EXPECT_EQ("", log_) << "Activity logged that was not expected";
}
// Gets and resets the log, which is a string of what happened.
std::string GetLog() {
std::string result = log_;
log_.clear();
return result;
}
// content::WebContentsObserver implementation.
void RenderFrameCreated(RenderFrameHost* render_frame_host) override {
LogWhatHappened("RenderFrameCreated", render_frame_host);
}
void RenderFrameHostChanged(RenderFrameHost* old_host,
RenderFrameHost* new_host) override {
if (old_host)
LogWhatHappened("RenderFrameHostChanged(old)", old_host);
LogWhatHappened("RenderFrameHostChanged(new)", new_host);
}
void RenderFrameDeleted(RenderFrameHost* render_frame_host) override {
LogWhatHappened("RenderFrameDeleted", render_frame_host);
}
void RenderProcessGone(base::TerminationStatus status) override {
LogWhatHappened("RenderProcessGone");
}
private:
void LogWhatHappened(const std::string& event_name) {
if (!log_.empty()) {
log_.append("\n");
}
log_.append(event_name + " -> ");
AppendTreeNodeState(
static_cast<WebContentsImpl*>(web_contents())->GetFrameTree()->root(),
&log_);
}
void LogWhatHappened(const std::string& event_name, RenderFrameHost* rfh) {
LogWhatHappened(
base::StringPrintf("%s(%d)", event_name.c_str(), rfh->GetRoutingID()));
}
std::string log_;
DISALLOW_COPY_AND_ASSIGN(TreeWalkingWebContentsLogger);
};
} // namespace
class FrameTreeTest : public RenderViewHostImplTestHarness {
protected:
// Prints a FrameTree, for easy assertions of the tree hierarchy.
std::string GetTreeState(FrameTree* frame_tree) {
std::string result;
AppendTreeNodeState(frame_tree->root(), &result);
return result;
}
std::string GetTraversalOrder(FrameTree* frame_tree,
FrameTreeNode* node_to_skip) {
std::string result;
for (FrameTreeNode* node : frame_tree->NodesExcept(node_to_skip)) {
if (!result.empty())
result += " ";
result += base::Int64ToString(node->current_frame_host()->GetRoutingID());
}
return result;
}
};
// Exercise tree manipulation routines.
// - Add a series of nodes and verify tree structure.
// - Remove a series of nodes and verify tree structure.
TEST_F(FrameTreeTest, Shape) {
main_test_rfh()->InitializeRenderFrameIfNeeded();
// Use the FrameTree of the WebContents so that it has all the delegates it
// needs. We may want to consider a test version of this.
FrameTree* frame_tree = contents()->GetFrameTree();
FrameTreeNode* root = frame_tree->root();
std::string no_children_node("no children node");
std::string deep_subtree("node with deep subtree");
int process_id = root->current_frame_host()->GetProcess()->GetID();
// Do not navigate each frame separately, since that will clutter the test
// itself. Instead, leave them in "not live" state, which is indicated by the
// * after the frame id, since this test cares about the shape, not the
// frame liveness.
EXPECT_EQ("2: []", GetTreeState(frame_tree));
// Simulate attaching a series of frames to build the frame tree.
frame_tree->AddFrame(root, process_id, 14, blink::WebTreeScopeType::Document,
std::string(), blink::WebSandboxFlags::None,
blink::WebFrameOwnerProperties());
frame_tree->AddFrame(root, process_id, 15, blink::WebTreeScopeType::Document,
std::string(), blink::WebSandboxFlags::None,
blink::WebFrameOwnerProperties());
frame_tree->AddFrame(root, process_id, 16, blink::WebTreeScopeType::Document,
std::string(), blink::WebSandboxFlags::None,
blink::WebFrameOwnerProperties());
frame_tree->AddFrame(root->child_at(0), process_id, 244,
blink::WebTreeScopeType::Document, std::string(),
blink::WebSandboxFlags::None,
blink::WebFrameOwnerProperties());
frame_tree->AddFrame(root->child_at(1), process_id, 255,
blink::WebTreeScopeType::Document, no_children_node,
blink::WebSandboxFlags::None,
blink::WebFrameOwnerProperties());
frame_tree->AddFrame(root->child_at(0), process_id, 245,
blink::WebTreeScopeType::Document, std::string(),
blink::WebSandboxFlags::None,
blink::WebFrameOwnerProperties());
EXPECT_EQ(
"2: [14: [244: [], 245: []], "
"15: [255 'no children node': []], "
"16: []]",
GetTreeState(frame_tree));
FrameTreeNode* child_16 = root->child_at(2);
frame_tree->AddFrame(child_16, process_id, 264,
blink::WebTreeScopeType::Document, std::string(),
blink::WebSandboxFlags::None,
blink::WebFrameOwnerProperties());
frame_tree->AddFrame(child_16, process_id, 265,
blink::WebTreeScopeType::Document, std::string(),
blink::WebSandboxFlags::None,
blink::WebFrameOwnerProperties());
frame_tree->AddFrame(child_16, process_id, 266,
blink::WebTreeScopeType::Document, std::string(),
blink::WebSandboxFlags::None,
blink::WebFrameOwnerProperties());
frame_tree->AddFrame(child_16, process_id, 267,
blink::WebTreeScopeType::Document, deep_subtree,
blink::WebSandboxFlags::None,
blink::WebFrameOwnerProperties());
frame_tree->AddFrame(child_16, process_id, 268,
blink::WebTreeScopeType::Document, std::string(),
blink::WebSandboxFlags::None,
blink::WebFrameOwnerProperties());
FrameTreeNode* child_267 = child_16->child_at(3);
frame_tree->AddFrame(child_267, process_id, 365,
blink::WebTreeScopeType::Document, std::string(),
blink::WebSandboxFlags::None,
blink::WebFrameOwnerProperties());
frame_tree->AddFrame(child_267->child_at(0), process_id, 455,
blink::WebTreeScopeType::Document, std::string(),
blink::WebSandboxFlags::None,
blink::WebFrameOwnerProperties());
frame_tree->AddFrame(child_267->child_at(0)->child_at(0), process_id, 555,
blink::WebTreeScopeType::Document, std::string(),
blink::WebSandboxFlags::None,
blink::WebFrameOwnerProperties());
frame_tree->AddFrame(child_267->child_at(0)->child_at(0)->child_at(0),
process_id, 655, blink::WebTreeScopeType::Document,
std::string(), blink::WebSandboxFlags::None,
blink::WebFrameOwnerProperties());
// Now that's it's fully built, verify the tree structure is as expected.
EXPECT_EQ(
"2: [14: [244: [], 245: []], "
"15: [255 'no children node': []], "
"16: [264: [], 265: [], 266: [], "
"267 'node with deep subtree': "
"[365: [455: [555: [655: []]]]], 268: []]]",
GetTreeState(frame_tree));
// Verify that traversal order is breadth first, even if we skip a subtree.
FrameTreeNode* child_14 = root->child_at(0);
FrameTreeNode* child_15 = root->child_at(1);
FrameTreeNode* child_244 = child_14->child_at(0);
FrameTreeNode* child_245 = child_14->child_at(1);
FrameTreeNode* child_555 = child_267->child_at(0)->child_at(0)->child_at(0);
FrameTreeNode* child_655 = child_555->child_at(0);
EXPECT_EQ("2 14 15 16 244 245 255 264 265 266 267 268 365 455 555 655",
GetTraversalOrder(frame_tree, nullptr));
EXPECT_EQ("", GetTraversalOrder(frame_tree, root));
EXPECT_EQ("2 15 16 255 264 265 266 267 268 365 455 555 655",
GetTraversalOrder(frame_tree, child_14));
EXPECT_EQ("2 14 15 16 245 255 264 265 266 267 268 365 455 555 655",
GetTraversalOrder(frame_tree, child_244));
EXPECT_EQ("2 14 15 16 244 255 264 265 266 267 268 365 455 555 655",
GetTraversalOrder(frame_tree, child_245));
EXPECT_EQ("2 14 16 244 245 264 265 266 267 268 365 455 555 655",
GetTraversalOrder(frame_tree, child_15));
EXPECT_EQ("2 14 15 16 244 245 255 264 265 266 268",
GetTraversalOrder(frame_tree, child_267));
EXPECT_EQ("2 14 15 16 244 245 255 264 265 266 267 268 365 455",
GetTraversalOrder(frame_tree, child_555));
EXPECT_EQ("2 14 15 16 244 245 255 264 265 266 267 268 365 455 555",
GetTraversalOrder(frame_tree, child_655));
frame_tree->RemoveFrame(child_555);
EXPECT_EQ(
"2: [14: [244: [], 245: []], "
"15: [255 'no children node': []], "
"16: [264: [], 265: [], 266: [], "
"267 'node with deep subtree': "
"[365: [455: []]], 268: []]]",
GetTreeState(frame_tree));
frame_tree->RemoveFrame(child_16->child_at(1));
EXPECT_EQ(
"2: [14: [244: [], 245: []], "
"15: [255 'no children node': []], "
"16: [264: [], 266: [], "
"267 'node with deep subtree': "
"[365: [455: []]], 268: []]]",
GetTreeState(frame_tree));
frame_tree->RemoveFrame(root->child_at(1));
EXPECT_EQ(
"2: [14: [244: [], 245: []], "
"16: [264: [], 266: [], "
"267 'node with deep subtree': "
"[365: [455: []]], 268: []]]",
GetTreeState(frame_tree));
}
// Ensure frames can be found by frame_tree_node_id, routing ID, or name.
TEST_F(FrameTreeTest, FindFrames) {
main_test_rfh()->InitializeRenderFrameIfNeeded();
// Add a few child frames to the main frame.
FrameTree* frame_tree = contents()->GetFrameTree();
FrameTreeNode* root = frame_tree->root();
main_test_rfh()->OnCreateChildFrame(22, blink::WebTreeScopeType::Document,
"child0", blink::WebSandboxFlags::None,
blink::WebFrameOwnerProperties());
main_test_rfh()->OnCreateChildFrame(23, blink::WebTreeScopeType::Document,
"child1", blink::WebSandboxFlags::None,
blink::WebFrameOwnerProperties());
main_test_rfh()->OnCreateChildFrame(24, blink::WebTreeScopeType::Document,
std::string(),
blink::WebSandboxFlags::None,
blink::WebFrameOwnerProperties());
FrameTreeNode* child0 = root->child_at(0);
FrameTreeNode* child1 = root->child_at(1);
FrameTreeNode* child2 = root->child_at(2);
// Add one grandchild frame.
child1->current_frame_host()->OnCreateChildFrame(
33, blink::WebTreeScopeType::Document, "grandchild",
blink::WebSandboxFlags::None, blink::WebFrameOwnerProperties());
FrameTreeNode* grandchild = child1->child_at(0);
// Ensure they can be found by FTN id.
EXPECT_EQ(root, frame_tree->FindByID(root->frame_tree_node_id()));
EXPECT_EQ(child0, frame_tree->FindByID(child0->frame_tree_node_id()));
EXPECT_EQ(child1, frame_tree->FindByID(child1->frame_tree_node_id()));
EXPECT_EQ(child2, frame_tree->FindByID(child2->frame_tree_node_id()));
EXPECT_EQ(grandchild, frame_tree->FindByID(grandchild->frame_tree_node_id()));
EXPECT_EQ(nullptr, frame_tree->FindByID(-1));
// Ensure they can be found by routing id.
int process_id = main_test_rfh()->GetProcess()->GetID();
EXPECT_EQ(root, frame_tree->FindByRoutingID(process_id,
main_test_rfh()->GetRoutingID()));
EXPECT_EQ(child0, frame_tree->FindByRoutingID(process_id, 22));
EXPECT_EQ(child1, frame_tree->FindByRoutingID(process_id, 23));
EXPECT_EQ(child2, frame_tree->FindByRoutingID(process_id, 24));
EXPECT_EQ(grandchild, frame_tree->FindByRoutingID(process_id, 33));
EXPECT_EQ(nullptr, frame_tree->FindByRoutingID(process_id, 37));
// Ensure they can be found by name, if they have one.
EXPECT_EQ(root, frame_tree->FindByName(std::string()));
EXPECT_EQ(child0, frame_tree->FindByName("child0"));
EXPECT_EQ(child1, frame_tree->FindByName("child1"));
EXPECT_EQ(grandchild, frame_tree->FindByName("grandchild"));
EXPECT_EQ(nullptr, frame_tree->FindByName("no such frame"));
}
// Check that PreviousSibling() is retrieved correctly.
TEST_F(FrameTreeTest, PreviousSibling) {
main_test_rfh()->InitializeRenderFrameIfNeeded();
// Add a few child frames to the main frame.
FrameTree* frame_tree = contents()->GetFrameTree();
FrameTreeNode* root = frame_tree->root();
main_test_rfh()->OnCreateChildFrame(22, blink::WebTreeScopeType::Document,
"child0", blink::WebSandboxFlags::None,
blink::WebFrameOwnerProperties());
main_test_rfh()->OnCreateChildFrame(23, blink::WebTreeScopeType::Document,
"child1", blink::WebSandboxFlags::None,
blink::WebFrameOwnerProperties());
main_test_rfh()->OnCreateChildFrame(24, blink::WebTreeScopeType::Document,
"child2", blink::WebSandboxFlags::None,
blink::WebFrameOwnerProperties());
FrameTreeNode* child0 = root->child_at(0);
FrameTreeNode* child1 = root->child_at(1);
FrameTreeNode* child2 = root->child_at(2);
// Add one grandchild frame.
child1->current_frame_host()->OnCreateChildFrame(
33, blink::WebTreeScopeType::Document, "grandchild",
blink::WebSandboxFlags::None, blink::WebFrameOwnerProperties());
FrameTreeNode* grandchild = child1->child_at(0);
EXPECT_EQ(nullptr, root->PreviousSibling());
EXPECT_EQ(nullptr, child0->PreviousSibling());
EXPECT_EQ(child0, child1->PreviousSibling());
EXPECT_EQ(child1, child2->PreviousSibling());
EXPECT_EQ(nullptr, grandchild->PreviousSibling());
}
// Do some simple manipulations of the frame tree, making sure that
// WebContentsObservers see a consistent view of the tree as we go.
TEST_F(FrameTreeTest, ObserverWalksTreeDuringFrameCreation) {
TreeWalkingWebContentsLogger activity(contents());
contents()->NavigateAndCommit(GURL("http://www.google.com"));
EXPECT_EQ("RenderFrameCreated(2) -> 2: []", activity.GetLog());
FrameTree* frame_tree = contents()->GetFrameTree();
FrameTreeNode* root = frame_tree->root();
// Simulate attaching a series of frames to build the frame tree.
main_test_rfh()->OnCreateChildFrame(14, blink::WebTreeScopeType::Document,
std::string(),
blink::WebSandboxFlags::None,
blink::WebFrameOwnerProperties());
EXPECT_EQ(
"RenderFrameHostChanged(new)(14) -> 2: []\n"
"RenderFrameCreated(14) -> 2: [14: []]",
activity.GetLog());
main_test_rfh()->OnCreateChildFrame(18, blink::WebTreeScopeType::Document,
std::string(),
blink::WebSandboxFlags::None,
blink::WebFrameOwnerProperties());
EXPECT_EQ(
"RenderFrameHostChanged(new)(18) -> 2: [14: []]\n"
"RenderFrameCreated(18) -> 2: [14: [], 18: []]",
activity.GetLog());
frame_tree->RemoveFrame(root->child_at(0));
EXPECT_EQ("RenderFrameDeleted(14) -> 2: [18: []]", activity.GetLog());
frame_tree->RemoveFrame(root->child_at(0));
EXPECT_EQ("RenderFrameDeleted(18) -> 2: []", activity.GetLog());
}
// Make sure that WebContentsObservers see a consistent view of the tree after
// recovery from a render process crash.
TEST_F(FrameTreeTest, ObserverWalksTreeAfterCrash) {
TreeWalkingWebContentsLogger activity(contents());
contents()->NavigateAndCommit(GURL("http://www.google.com"));
EXPECT_EQ("RenderFrameCreated(2) -> 2: []", activity.GetLog());
main_test_rfh()->OnCreateChildFrame(22, blink::WebTreeScopeType::Document,
std::string(),
blink::WebSandboxFlags::None,
blink::WebFrameOwnerProperties());
EXPECT_EQ(
"RenderFrameHostChanged(new)(22) -> 2: []\n"
"RenderFrameCreated(22) -> 2: [22: []]",
activity.GetLog());
main_test_rfh()->OnCreateChildFrame(23, blink::WebTreeScopeType::Document,
std::string(),
blink::WebSandboxFlags::None,
blink::WebFrameOwnerProperties());
EXPECT_EQ(
"RenderFrameHostChanged(new)(23) -> 2: [22: []]\n"
"RenderFrameCreated(23) -> 2: [22: [], 23: []]",
activity.GetLog());
// Crash the renderer
main_test_rfh()->GetProcess()->SimulateCrash();
EXPECT_EQ(
"RenderProcessGone -> 2*: [22*: [], 23*: []]\n"
"RenderFrameDeleted(23) -> 2*: [22*: [], 23*: []]\n"
"RenderFrameDeleted(22) -> 2*: [22*: [], 23*: []]\n"
"RenderFrameDeleted(2) -> 2*: []",
activity.GetLog());
}
// Ensure that frames are not added to the tree, if the process passed in
// is different than the process of the parent node.
TEST_F(FrameTreeTest, FailAddFrameWithWrongProcessId) {
contents()->NavigateAndCommit(GURL("http://www.google.com"));
FrameTree* frame_tree = contents()->GetFrameTree();
FrameTreeNode* root = frame_tree->root();
int process_id = root->current_frame_host()->GetProcess()->GetID();
ASSERT_EQ("2: []", GetTreeState(frame_tree));
// Simulate attaching a frame from mismatched process id.
ASSERT_FALSE(frame_tree->AddFrame(
root, process_id + 1, 1, blink::WebTreeScopeType::Document, std::string(),
blink::WebSandboxFlags::None, blink::WebFrameOwnerProperties()));
ASSERT_EQ("2: []", GetTreeState(frame_tree));
}
// Ensure that frames removed while a process has crashed are not preserved in
// the global map of id->frame.
TEST_F(FrameTreeTest, ProcessCrashClearsGlobalMap) {
main_test_rfh()->InitializeRenderFrameIfNeeded();
// Add a couple child frames to the main frame.
FrameTreeNode* root = contents()->GetFrameTree()->root();
main_test_rfh()->OnCreateChildFrame(22, blink::WebTreeScopeType::Document,
std::string(),
blink::WebSandboxFlags::None,
blink::WebFrameOwnerProperties());
main_test_rfh()->OnCreateChildFrame(23, blink::WebTreeScopeType::Document,
std::string(),
blink::WebSandboxFlags::None,
blink::WebFrameOwnerProperties());
// Add one grandchild frame.
RenderFrameHostImpl* child1_rfh = root->child_at(0)->current_frame_host();
child1_rfh->OnCreateChildFrame(33, blink::WebTreeScopeType::Document,
std::string(), blink::WebSandboxFlags::None,
blink::WebFrameOwnerProperties());
// Ensure they can be found by id.
int id1 = root->child_at(0)->frame_tree_node_id();
int id2 = root->child_at(1)->frame_tree_node_id();
int id3 = root->child_at(0)->child_at(0)->frame_tree_node_id();
EXPECT_TRUE(FrameTreeNode::GloballyFindByID(id1));
EXPECT_TRUE(FrameTreeNode::GloballyFindByID(id2));
EXPECT_TRUE(FrameTreeNode::GloballyFindByID(id3));
// Crash the renderer.
main_test_rfh()->GetProcess()->SimulateCrash();
// Ensure they cannot be found by id after the process has crashed.
EXPECT_FALSE(FrameTreeNode::GloballyFindByID(id1));
EXPECT_FALSE(FrameTreeNode::GloballyFindByID(id2));
EXPECT_FALSE(FrameTreeNode::GloballyFindByID(id3));
}
} // namespace content
|