1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
|
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/macros.h"
#include "base/memory/scoped_ptr.h"
#include "base/message_loop/message_loop.h"
#include "base/pickle.h"
#include "base/stl_util.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/stringprintf.h"
#include "base/time/time.h"
#include "extensions/browser/extension_throttle_entry.h"
#include "extensions/browser/extension_throttle_manager.h"
#include "extensions/browser/extension_throttle_test_support.h"
#include "net/base/load_flags.h"
#include "net/base/request_priority.h"
#include "net/base/test_completion_callback.h"
#include "net/url_request/url_request.h"
#include "net/url_request/url_request_context.h"
#include "net/url_request/url_request_test_util.h"
#include "testing/gtest/include/gtest/gtest.h"
using base::TimeDelta;
using base::TimeTicks;
using net::BackoffEntry;
using net::NetworkChangeNotifier;
using net::TestNetworkDelegate;
using net::TestURLRequestContext;
using net::URLRequest;
using net::URLRequestContext;
namespace extensions {
namespace {
class MockExtensionThrottleEntry : public ExtensionThrottleEntry {
public:
explicit MockExtensionThrottleEntry(ExtensionThrottleManager* manager)
: ExtensionThrottleEntry(manager, std::string()),
backoff_entry_(&backoff_policy_, &fake_clock_) {
InitPolicy();
}
MockExtensionThrottleEntry(ExtensionThrottleManager* manager,
const TimeTicks& exponential_backoff_release_time,
const TimeTicks& sliding_window_release_time,
const TimeTicks& fake_now)
: ExtensionThrottleEntry(manager, std::string()),
fake_clock_(fake_now),
backoff_entry_(&backoff_policy_, &fake_clock_) {
InitPolicy();
set_exponential_backoff_release_time(exponential_backoff_release_time);
set_sliding_window_release_time(sliding_window_release_time);
}
void InitPolicy() {
// Some tests become flaky if we have jitter.
backoff_policy_.jitter_factor = 0.0;
// This lets us avoid having to make multiple failures initially (this
// logic is already tested in the BackoffEntry unit tests).
backoff_policy_.num_errors_to_ignore = 0;
}
const BackoffEntry* GetBackoffEntry() const override {
return &backoff_entry_;
}
BackoffEntry* GetBackoffEntry() override { return &backoff_entry_; }
static bool ExplicitUserRequest(int load_flags) {
return ExtensionThrottleEntry::ExplicitUserRequest(load_flags);
}
void ResetToBlank(const TimeTicks& time_now) {
fake_clock_.set_now(time_now);
GetBackoffEntry()->Reset();
set_sliding_window_release_time(time_now);
}
// Overridden for tests.
TimeTicks ImplGetTimeNow() const override { return fake_clock_.NowTicks(); }
void set_fake_now(const TimeTicks& now) { fake_clock_.set_now(now); }
void set_exponential_backoff_release_time(const TimeTicks& release_time) {
GetBackoffEntry()->SetCustomReleaseTime(release_time);
}
TimeTicks sliding_window_release_time() const {
return ExtensionThrottleEntry::sliding_window_release_time();
}
void set_sliding_window_release_time(const TimeTicks& release_time) {
ExtensionThrottleEntry::set_sliding_window_release_time(release_time);
}
protected:
~MockExtensionThrottleEntry() override {}
private:
mutable TestTickClock fake_clock_;
BackoffEntry backoff_entry_;
};
class MockExtensionThrottleManager : public ExtensionThrottleManager {
public:
MockExtensionThrottleManager() : create_entry_index_(0) {}
// Method to process the URL using ExtensionThrottleManager protected
// method.
std::string DoGetUrlIdFromUrl(const GURL& url) { return GetIdFromUrl(url); }
// Method to use the garbage collecting method of ExtensionThrottleManager.
void DoGarbageCollectEntries() { GarbageCollectEntries(); }
// Returns the number of entries in the map.
int GetNumberOfEntries() const { return GetNumberOfEntriesForTests(); }
void CreateEntry(bool is_outdated) {
TimeTicks time = TimeTicks::Now();
if (is_outdated) {
time -= TimeDelta::FromMilliseconds(
MockExtensionThrottleEntry::kDefaultEntryLifetimeMs + 1000);
}
std::string fake_url_string("http://www.fakeurl.com/");
fake_url_string.append(base::IntToString(create_entry_index_++));
GURL fake_url(fake_url_string);
OverrideEntryForTests(
fake_url, new MockExtensionThrottleEntry(this, time, TimeTicks::Now(),
TimeTicks::Now()));
}
private:
int create_entry_index_;
};
struct TimeAndBool {
TimeAndBool(const TimeTicks& time_value, bool expected, int line_num) {
time = time_value;
result = expected;
line = line_num;
}
TimeTicks time;
bool result;
int line;
};
struct GurlAndString {
GurlAndString(const GURL& url_value,
const std::string& expected,
int line_num) {
url = url_value;
result = expected;
line = line_num;
}
GURL url;
std::string result;
int line;
};
} // namespace
class ExtensionThrottleEntryTest : public testing::Test {
protected:
ExtensionThrottleEntryTest()
: request_(context_.CreateRequest(GURL(), net::DEFAULT_PRIORITY, NULL)) {}
void SetUp() override;
TimeTicks now_;
MockExtensionThrottleManager manager_; // Dummy object, not used.
scoped_refptr<MockExtensionThrottleEntry> entry_;
base::MessageLoopForIO message_loop_;
TestURLRequestContext context_;
scoped_ptr<URLRequest> request_;
};
void ExtensionThrottleEntryTest::SetUp() {
request_->SetLoadFlags(0);
now_ = TimeTicks::Now();
entry_ = new MockExtensionThrottleEntry(&manager_);
entry_->ResetToBlank(now_);
}
std::ostream& operator<<(std::ostream& out, const base::TimeTicks& time) {
return out << time.ToInternalValue();
}
TEST_F(ExtensionThrottleEntryTest, CanThrottleRequest) {
entry_->set_exponential_backoff_release_time(entry_->ImplGetTimeNow() +
TimeDelta::FromMilliseconds(1));
EXPECT_TRUE(entry_->ShouldRejectRequest(*request_));
}
TEST_F(ExtensionThrottleEntryTest, InterfaceDuringExponentialBackoff) {
entry_->set_exponential_backoff_release_time(entry_->ImplGetTimeNow() +
TimeDelta::FromMilliseconds(1));
EXPECT_TRUE(entry_->ShouldRejectRequest(*request_));
// Also end-to-end test the load flags exceptions.
request_->SetLoadFlags(net::LOAD_MAYBE_USER_GESTURE);
EXPECT_FALSE(entry_->ShouldRejectRequest(*request_));
}
TEST_F(ExtensionThrottleEntryTest, InterfaceNotDuringExponentialBackoff) {
entry_->set_exponential_backoff_release_time(entry_->ImplGetTimeNow());
EXPECT_FALSE(entry_->ShouldRejectRequest(*request_));
entry_->set_exponential_backoff_release_time(entry_->ImplGetTimeNow() -
TimeDelta::FromMilliseconds(1));
EXPECT_FALSE(entry_->ShouldRejectRequest(*request_));
}
TEST_F(ExtensionThrottleEntryTest, InterfaceUpdateFailure) {
entry_->UpdateWithResponse(503);
EXPECT_GT(entry_->GetExponentialBackoffReleaseTime(),
entry_->ImplGetTimeNow())
<< "A failure should increase the release_time";
}
TEST_F(ExtensionThrottleEntryTest, InterfaceUpdateSuccess) {
entry_->UpdateWithResponse(200);
EXPECT_EQ(entry_->GetExponentialBackoffReleaseTime(),
entry_->ImplGetTimeNow())
<< "A success should not add any delay";
}
TEST_F(ExtensionThrottleEntryTest, InterfaceUpdateSuccessThenFailure) {
entry_->UpdateWithResponse(200);
entry_->UpdateWithResponse(503);
EXPECT_GT(entry_->GetExponentialBackoffReleaseTime(),
entry_->ImplGetTimeNow())
<< "This scenario should add delay";
entry_->UpdateWithResponse(200);
}
TEST_F(ExtensionThrottleEntryTest, IsEntryReallyOutdated) {
TimeDelta lifetime = TimeDelta::FromMilliseconds(
MockExtensionThrottleEntry::kDefaultEntryLifetimeMs);
const TimeDelta kFiveMs = TimeDelta::FromMilliseconds(5);
TimeAndBool test_values[] = {
TimeAndBool(now_, false, __LINE__),
TimeAndBool(now_ - kFiveMs, false, __LINE__),
TimeAndBool(now_ + kFiveMs, false, __LINE__),
TimeAndBool(now_ - (lifetime - kFiveMs), false, __LINE__),
TimeAndBool(now_ - lifetime, true, __LINE__),
TimeAndBool(now_ - (lifetime + kFiveMs), true, __LINE__)};
for (unsigned int i = 0; i < arraysize(test_values); ++i) {
entry_->set_exponential_backoff_release_time(test_values[i].time);
EXPECT_EQ(entry_->IsEntryOutdated(), test_values[i].result)
<< "Test case #" << i << " line " << test_values[i].line << " failed";
}
}
TEST_F(ExtensionThrottleEntryTest, MaxAllowedBackoff) {
for (int i = 0; i < 30; ++i) {
entry_->UpdateWithResponse(503);
}
TimeDelta delay = entry_->GetExponentialBackoffReleaseTime() - now_;
EXPECT_EQ(delay.InMilliseconds(),
MockExtensionThrottleEntry::kDefaultMaximumBackoffMs);
}
TEST_F(ExtensionThrottleEntryTest, MalformedContent) {
for (int i = 0; i < 5; ++i)
entry_->UpdateWithResponse(503);
TimeTicks release_after_failures = entry_->GetExponentialBackoffReleaseTime();
// Inform the entry that a response body was malformed, which is supposed to
// increase the back-off time. Note that we also submit a successful
// UpdateWithResponse to pair with ReceivedContentWasMalformed() since that
// is what happens in practice (if a body is received, then a non-500
// response must also have been received).
entry_->ReceivedContentWasMalformed(200);
entry_->UpdateWithResponse(200);
EXPECT_GT(entry_->GetExponentialBackoffReleaseTime(), release_after_failures);
}
TEST_F(ExtensionThrottleEntryTest, SlidingWindow) {
int max_send = ExtensionThrottleEntry::kDefaultMaxSendThreshold;
int sliding_window = ExtensionThrottleEntry::kDefaultSlidingWindowPeriodMs;
TimeTicks time_1 = entry_->ImplGetTimeNow() +
TimeDelta::FromMilliseconds(sliding_window / 3);
TimeTicks time_2 = entry_->ImplGetTimeNow() +
TimeDelta::FromMilliseconds(2 * sliding_window / 3);
TimeTicks time_3 =
entry_->ImplGetTimeNow() + TimeDelta::FromMilliseconds(sliding_window);
TimeTicks time_4 =
entry_->ImplGetTimeNow() +
TimeDelta::FromMilliseconds(sliding_window + 2 * sliding_window / 3);
entry_->set_exponential_backoff_release_time(time_1);
for (int i = 0; i < max_send / 2; ++i) {
EXPECT_EQ(2 * sliding_window / 3,
entry_->ReserveSendingTimeForNextRequest(time_2));
}
EXPECT_EQ(time_2, entry_->sliding_window_release_time());
entry_->set_fake_now(time_3);
for (int i = 0; i < (max_send + 1) / 2; ++i)
EXPECT_EQ(0, entry_->ReserveSendingTimeForNextRequest(TimeTicks()));
EXPECT_EQ(time_4, entry_->sliding_window_release_time());
}
TEST_F(ExtensionThrottleEntryTest, ExplicitUserRequest) {
ASSERT_FALSE(MockExtensionThrottleEntry::ExplicitUserRequest(0));
ASSERT_TRUE(MockExtensionThrottleEntry::ExplicitUserRequest(
net::LOAD_MAYBE_USER_GESTURE));
ASSERT_FALSE(MockExtensionThrottleEntry::ExplicitUserRequest(
~net::LOAD_MAYBE_USER_GESTURE));
}
class ExtensionThrottleManagerTest : public testing::Test {
protected:
ExtensionThrottleManagerTest()
: request_(context_.CreateRequest(GURL(), net::DEFAULT_PRIORITY, NULL)) {}
void SetUp() override { request_->SetLoadFlags(0); }
void ExpectEntryAllowsAllOnErrorIfOptedOut(
ExtensionThrottleEntryInterface* entry,
bool opted_out,
const URLRequest& request) {
EXPECT_FALSE(entry->ShouldRejectRequest(request));
for (int i = 0; i < 10; ++i) {
entry->UpdateWithResponse(503);
}
EXPECT_NE(opted_out, entry->ShouldRejectRequest(request));
if (opted_out) {
// We're not mocking out GetTimeNow() in this scenario
// so add a 100 ms buffer to avoid flakiness (that should always
// give enough time to get from the TimeTicks::Now() call here
// to the TimeTicks::Now() call in the entry class).
EXPECT_GT(TimeTicks::Now() + TimeDelta::FromMilliseconds(100),
entry->GetExponentialBackoffReleaseTime());
} else {
// As above, add 100 ms.
EXPECT_LT(TimeTicks::Now() + TimeDelta::FromMilliseconds(100),
entry->GetExponentialBackoffReleaseTime());
}
}
base::MessageLoopForIO message_loop_;
// context_ must be declared before request_.
TestURLRequestContext context_;
scoped_ptr<URLRequest> request_;
};
TEST_F(ExtensionThrottleManagerTest, IsUrlStandardised) {
MockExtensionThrottleManager manager;
GurlAndString test_values[] = {
GurlAndString(GURL("http://www.example.com"),
std::string("http://www.example.com/"), __LINE__),
GurlAndString(GURL("http://www.Example.com"),
std::string("http://www.example.com/"), __LINE__),
GurlAndString(GURL("http://www.ex4mple.com/Pr4c71c41"),
std::string("http://www.ex4mple.com/pr4c71c41"), __LINE__),
GurlAndString(GURL("http://www.example.com/0/token/false"),
std::string("http://www.example.com/0/token/false"),
__LINE__),
GurlAndString(GURL("http://www.example.com/index.php?code=javascript"),
std::string("http://www.example.com/index.php"), __LINE__),
GurlAndString(GURL("http://www.example.com/index.php?code=1#superEntry"),
std::string("http://www.example.com/index.php"), __LINE__),
GurlAndString(GURL("http://www.example.com/index.php#superEntry"),
std::string("http://www.example.com/index.php"), __LINE__),
GurlAndString(GURL("http://www.example.com:1234/"),
std::string("http://www.example.com:1234/"), __LINE__)};
for (unsigned int i = 0; i < arraysize(test_values); ++i) {
std::string temp = manager.DoGetUrlIdFromUrl(test_values[i].url);
EXPECT_EQ(temp, test_values[i].result) << "Test case #" << i << " line "
<< test_values[i].line << " failed";
}
}
TEST_F(ExtensionThrottleManagerTest, AreEntriesBeingCollected) {
MockExtensionThrottleManager manager;
manager.CreateEntry(true); // true = Entry is outdated.
manager.CreateEntry(true);
manager.CreateEntry(true);
manager.DoGarbageCollectEntries();
EXPECT_EQ(0, manager.GetNumberOfEntries());
manager.CreateEntry(false);
manager.CreateEntry(false);
manager.CreateEntry(false);
manager.CreateEntry(true);
manager.DoGarbageCollectEntries();
EXPECT_EQ(3, manager.GetNumberOfEntries());
}
TEST_F(ExtensionThrottleManagerTest, IsHostBeingRegistered) {
MockExtensionThrottleManager manager;
manager.RegisterRequestUrl(GURL("http://www.example.com/"));
manager.RegisterRequestUrl(GURL("http://www.google.com/"));
manager.RegisterRequestUrl(GURL("http://www.google.com/index/0"));
manager.RegisterRequestUrl(GURL("http://www.google.com/index/0?code=1"));
manager.RegisterRequestUrl(GURL("http://www.google.com/index/0#lolsaure"));
EXPECT_EQ(3, manager.GetNumberOfEntries());
}
TEST_F(ExtensionThrottleManagerTest, LocalHostOptedOut) {
MockExtensionThrottleManager manager;
// A localhost entry should always be opted out.
scoped_refptr<ExtensionThrottleEntryInterface> localhost_entry =
manager.RegisterRequestUrl(GURL("http://localhost/hello"));
EXPECT_FALSE(localhost_entry->ShouldRejectRequest((*request_)));
for (int i = 0; i < 10; ++i) {
localhost_entry->UpdateWithResponse(503);
}
EXPECT_FALSE(localhost_entry->ShouldRejectRequest((*request_)));
// We're not mocking out GetTimeNow() in this scenario
// so add a 100 ms buffer to avoid flakiness (that should always
// give enough time to get from the TimeTicks::Now() call here
// to the TimeTicks::Now() call in the entry class).
EXPECT_GT(TimeTicks::Now() + TimeDelta::FromMilliseconds(100),
localhost_entry->GetExponentialBackoffReleaseTime());
}
TEST_F(ExtensionThrottleManagerTest, ClearOnNetworkChange) {
for (int i = 0; i < 3; ++i) {
MockExtensionThrottleManager manager;
scoped_refptr<ExtensionThrottleEntryInterface> entry_before =
manager.RegisterRequestUrl(GURL("http://www.example.com/"));
for (int j = 0; j < 10; ++j) {
entry_before->UpdateWithResponse(503);
}
EXPECT_TRUE(entry_before->ShouldRejectRequest(*request_));
switch (i) {
case 0:
manager.OnIPAddressChanged();
break;
case 1:
manager.OnConnectionTypeChanged(
NetworkChangeNotifier::CONNECTION_UNKNOWN);
break;
case 2:
manager.OnConnectionTypeChanged(NetworkChangeNotifier::CONNECTION_NONE);
break;
default:
FAIL();
}
scoped_refptr<ExtensionThrottleEntryInterface> entry_after =
manager.RegisterRequestUrl(GURL("http://www.example.com/"));
EXPECT_FALSE(entry_after->ShouldRejectRequest(*request_));
}
}
} // namespace extensions
|