1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
|
// Copyright 2015 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <limits>
#include "base/run_loop.h"
#include "content/public/test/test_browser_thread_bundle.h"
#include "extensions/browser/deferred_start_render_host.h"
#include "extensions/browser/extensions_test.h"
#include "extensions/browser/load_monitoring_extension_host_queue.h"
#include "extensions/browser/serial_extension_host_queue.h"
namespace extensions {
namespace {
class StubDeferredStartRenderHost : public DeferredStartRenderHost {
public:
// Returns true if this host is being observed by |observer|.
bool IsObservedBy(DeferredStartRenderHostObserver* observer) {
return observers_.count(observer) > 0;
}
private:
// DeferredStartRenderHost:
void AddDeferredStartRenderHostObserver(
DeferredStartRenderHostObserver* observer) override {
observers_.insert(observer);
}
void RemoveDeferredStartRenderHostObserver(
DeferredStartRenderHostObserver* observer) override {
observers_.erase(observer);
}
void CreateRenderViewNow() override {}
std::set<DeferredStartRenderHostObserver*> observers_;
};
const size_t g_invalid_size_t = std::numeric_limits<size_t>::max();
} // namespace
class LoadMonitoringExtensionHostQueueTest : public ExtensionsTest {
public:
LoadMonitoringExtensionHostQueueTest()
: finished_(false),
// Arbitrary choice of an invalid size_t.
num_queued_(g_invalid_size_t),
num_loaded_(g_invalid_size_t),
max_awaiting_loading_(g_invalid_size_t),
max_active_loading_(g_invalid_size_t) {}
void SetUp() override {
queue_.reset(new LoadMonitoringExtensionHostQueue(
// Use a SerialExtensionHostQueue because it's simple.
scoped_ptr<ExtensionHostQueue>(new SerialExtensionHostQueue()),
base::TimeDelta(), // no delay, easier to test
base::Bind(&LoadMonitoringExtensionHostQueueTest::Finished,
base::Unretained(this))));
}
protected:
// Creates a new DeferredStartRenderHost. Ownership is held by this class,
// not passed to caller.
StubDeferredStartRenderHost* CreateHost() {
StubDeferredStartRenderHost* stub = new StubDeferredStartRenderHost();
stubs_.push_back(stub);
return stub;
}
// Our single LoadMonitoringExtensionHostQueue instance.
LoadMonitoringExtensionHostQueue* queue() { return queue_.get(); }
// Returns true if the queue has finished monitoring.
bool finished() const { return finished_; }
// These are available after the queue has finished (in which case finished()
// will return true).
size_t num_queued() { return num_queued_; }
size_t num_loaded() { return num_loaded_; }
size_t max_awaiting_loading() { return max_awaiting_loading_; }
size_t max_active_loading() { return max_active_loading_; }
private:
// Callback when queue has finished monitoring.
void Finished(size_t num_queued,
size_t num_loaded,
size_t max_awaiting_loading,
size_t max_active_loading) {
CHECK(!finished_);
finished_ = true;
num_queued_ = num_queued;
num_loaded_ = num_loaded;
max_awaiting_loading_ = max_awaiting_loading;
max_active_loading_ = max_active_loading;
}
content::TestBrowserThreadBundle thread_bundle_;
scoped_ptr<LoadMonitoringExtensionHostQueue> queue_;
ScopedVector<StubDeferredStartRenderHost> stubs_;
// Set after the queue has finished monitoring.
bool finished_;
size_t num_queued_;
size_t num_loaded_;
size_t max_awaiting_loading_;
size_t max_active_loading_;
};
// Tests that if monitoring is never started, nor any hosts added, nothing is
// recorded.
TEST_F(LoadMonitoringExtensionHostQueueTest, NeverStarted) {
base::RunLoop().RunUntilIdle();
ASSERT_FALSE(finished());
}
// Tests that if monitoring has started but no hosts added, it's recorded as 0.
TEST_F(LoadMonitoringExtensionHostQueueTest, NoHosts) {
queue()->StartMonitoring();
base::RunLoop().RunUntilIdle();
ASSERT_TRUE(finished());
EXPECT_EQ(0u, num_queued());
EXPECT_EQ(0u, num_loaded());
EXPECT_EQ(0u, max_awaiting_loading());
EXPECT_EQ(0u, max_active_loading());
}
// Tests that adding a host starts monitoring.
TEST_F(LoadMonitoringExtensionHostQueueTest, AddOneHost) {
queue()->Add(CreateHost());
base::RunLoop().RunUntilIdle();
ASSERT_TRUE(finished());
EXPECT_EQ(1u, num_queued());
EXPECT_EQ(0u, num_loaded());
EXPECT_EQ(1u, max_awaiting_loading());
EXPECT_EQ(0u, max_active_loading());
}
// Tests that a host added and removed is still recorded, but not as a load
// finished.
TEST_F(LoadMonitoringExtensionHostQueueTest, AddAndRemoveOneHost) {
DeferredStartRenderHost* host = CreateHost();
queue()->Add(host);
queue()->Remove(host);
base::RunLoop().RunUntilIdle();
ASSERT_TRUE(finished());
EXPECT_EQ(1u, num_queued());
EXPECT_EQ(0u, num_loaded());
EXPECT_EQ(1u, max_awaiting_loading());
EXPECT_EQ(0u, max_active_loading());
}
// Tests adding and starting a single host.
TEST_F(LoadMonitoringExtensionHostQueueTest, AddAndStartOneHost) {
DeferredStartRenderHost* host = CreateHost();
queue()->Add(host);
queue()->OnDeferredStartRenderHostDidStartFirstLoad(host);
base::RunLoop().RunUntilIdle();
ASSERT_TRUE(finished());
EXPECT_EQ(1u, num_queued());
EXPECT_EQ(0u, num_loaded());
EXPECT_EQ(1u, max_awaiting_loading());
EXPECT_EQ(1u, max_active_loading());
}
// Tests adding and destroying a single host without starting it.
TEST_F(LoadMonitoringExtensionHostQueueTest, AddAndDestroyOneHost) {
DeferredStartRenderHost* host = CreateHost();
queue()->Add(host);
queue()->OnDeferredStartRenderHostDestroyed(host);
base::RunLoop().RunUntilIdle();
ASSERT_TRUE(finished());
EXPECT_EQ(1u, num_queued());
EXPECT_EQ(0u, num_loaded());
EXPECT_EQ(1u, max_awaiting_loading());
EXPECT_EQ(0u, max_active_loading());
}
// Tests adding, starting, and stopping a single host.
TEST_F(LoadMonitoringExtensionHostQueueTest, AddAndStartAndStopOneHost) {
DeferredStartRenderHost* host = CreateHost();
queue()->Add(host);
queue()->OnDeferredStartRenderHostDidStartFirstLoad(host);
queue()->OnDeferredStartRenderHostDidStopFirstLoad(host);
base::RunLoop().RunUntilIdle();
ASSERT_TRUE(finished());
EXPECT_EQ(1u, num_queued());
EXPECT_EQ(1u, num_loaded());
EXPECT_EQ(1u, max_awaiting_loading());
EXPECT_EQ(1u, max_active_loading());
}
// Tests adding, starting, and stopping a single host - twice.
TEST_F(LoadMonitoringExtensionHostQueueTest, AddAndStartAndStopOneHostTwice) {
DeferredStartRenderHost* host = CreateHost();
queue()->Add(host);
queue()->OnDeferredStartRenderHostDidStartFirstLoad(host);
queue()->OnDeferredStartRenderHostDidStopFirstLoad(host);
// Re-starting loading should also be recorded fine (e.g. navigations could
// trigger this).
queue()->OnDeferredStartRenderHostDidStartFirstLoad(host);
queue()->OnDeferredStartRenderHostDidStopFirstLoad(host);
base::RunLoop().RunUntilIdle();
ASSERT_TRUE(finished());
EXPECT_EQ(1u, num_queued());
EXPECT_EQ(2u, num_loaded()); // 2 loaded this time, because we ran twice
EXPECT_EQ(1u, max_awaiting_loading());
EXPECT_EQ(1u, max_active_loading());
}
// Tests adding, starting, and destroying (i.e. an implicit stop) a single host.
TEST_F(LoadMonitoringExtensionHostQueueTest, AddAndStartAndDestroyOneHost) {
DeferredStartRenderHost* host = CreateHost();
queue()->Add(host);
queue()->OnDeferredStartRenderHostDidStartFirstLoad(host);
queue()->OnDeferredStartRenderHostDestroyed(host);
base::RunLoop().RunUntilIdle();
ASSERT_TRUE(finished());
EXPECT_EQ(1u, num_queued());
EXPECT_EQ(1u, num_loaded());
EXPECT_EQ(1u, max_awaiting_loading());
EXPECT_EQ(1u, max_active_loading());
}
// Tests adding, starting, and removing a single host.
TEST_F(LoadMonitoringExtensionHostQueueTest, AddAndStartAndRemoveOneHost) {
DeferredStartRenderHost* host = CreateHost();
queue()->Add(host);
queue()->OnDeferredStartRenderHostDidStartFirstLoad(host);
queue()->Remove(host);
base::RunLoop().RunUntilIdle();
ASSERT_TRUE(finished());
EXPECT_EQ(1u, num_queued());
EXPECT_EQ(0u, num_loaded());
EXPECT_EQ(1u, max_awaiting_loading());
EXPECT_EQ(1u, max_active_loading());
}
// Tests monitoring a sequence of hosts.
TEST_F(LoadMonitoringExtensionHostQueueTest, Sequence) {
// Scenario:
//
// 6 hosts will be added, only 5 will start loading, with a maximum of 4 in
// the queue and 3 loading at any time. Only 2 will finish.
DeferredStartRenderHost* host1 = CreateHost();
DeferredStartRenderHost* host2 = CreateHost();
DeferredStartRenderHost* host3 = CreateHost();
DeferredStartRenderHost* host4 = CreateHost();
DeferredStartRenderHost* host5 = CreateHost();
DeferredStartRenderHost* host6 = CreateHost();
queue()->Add(host1);
queue()->Add(host2);
queue()->Add(host3);
queue()->OnDeferredStartRenderHostDidStartFirstLoad(host1);
queue()->OnDeferredStartRenderHostDidStartFirstLoad(host2);
queue()->OnDeferredStartRenderHostDidStopFirstLoad(host1);
queue()->Add(host4);
queue()->Add(host5);
queue()->Add(host6);
queue()->OnDeferredStartRenderHostDidStartFirstLoad(host3);
queue()->OnDeferredStartRenderHostDidStartFirstLoad(host4);
queue()->OnDeferredStartRenderHostDidStopFirstLoad(host4);
queue()->OnDeferredStartRenderHostDidStartFirstLoad(host5);
base::RunLoop().RunUntilIdle();
ASSERT_TRUE(finished());
EXPECT_EQ(6u, num_queued());
EXPECT_EQ(2u, num_loaded());
EXPECT_EQ(4u, max_awaiting_loading());
EXPECT_EQ(3u, max_active_loading());
// Complete a realistic sequence by stopping and/or destroying all hosts.
queue()->OnDeferredStartRenderHostDestroyed(host1);
queue()->OnDeferredStartRenderHostDidStopFirstLoad(host2);
queue()->OnDeferredStartRenderHostDestroyed(host2);
queue()->OnDeferredStartRenderHostDidStopFirstLoad(host3);
queue()->OnDeferredStartRenderHostDestroyed(host3);
queue()->OnDeferredStartRenderHostDestroyed(host4);
queue()->OnDeferredStartRenderHostDestroyed(host5); // never stopped
queue()->OnDeferredStartRenderHostDestroyed(host6); // never started/stopped
}
// Tests that the queue is observing Hosts from adding them through to being
// removed - that the load sequence itself is irrelevant.
//
// This is an unfortunate implementation-style test, but it used to be a bug
// and difficult to catch outside of a proper test framework - one in which we
// don't have to trigger events by hand.
TEST_F(LoadMonitoringExtensionHostQueueTest, ObserverLifetime) {
StubDeferredStartRenderHost* host1 = CreateHost();
StubDeferredStartRenderHost* host2 = CreateHost();
StubDeferredStartRenderHost* host3 = CreateHost();
StubDeferredStartRenderHost* host4 = CreateHost();
EXPECT_FALSE(host1->IsObservedBy(queue()));
EXPECT_FALSE(host2->IsObservedBy(queue()));
EXPECT_FALSE(host3->IsObservedBy(queue()));
EXPECT_FALSE(host4->IsObservedBy(queue()));
queue()->Add(host1);
queue()->Add(host2);
queue()->Add(host3);
queue()->Add(host4);
EXPECT_TRUE(host1->IsObservedBy(queue()));
EXPECT_TRUE(host2->IsObservedBy(queue()));
EXPECT_TRUE(host3->IsObservedBy(queue()));
EXPECT_TRUE(host4->IsObservedBy(queue()));
queue()->OnDeferredStartRenderHostDidStartFirstLoad(host1);
queue()->OnDeferredStartRenderHostDidStartFirstLoad(host2);
queue()->OnDeferredStartRenderHostDidStartFirstLoad(host3);
// host4 will test that we Remove before Starting - so don't start.
EXPECT_TRUE(host1->IsObservedBy(queue()));
EXPECT_TRUE(host2->IsObservedBy(queue()));
EXPECT_TRUE(host3->IsObservedBy(queue()));
EXPECT_TRUE(host4->IsObservedBy(queue()));
queue()->OnDeferredStartRenderHostDidStopFirstLoad(host1);
queue()->OnDeferredStartRenderHostDestroyed(host2);
EXPECT_TRUE(host1->IsObservedBy(queue()));
EXPECT_TRUE(host2->IsObservedBy(queue()));
queue()->Remove(host1);
queue()->Remove(host2);
queue()->Remove(host3);
queue()->Remove(host4);
EXPECT_FALSE(host1->IsObservedBy(queue()));
EXPECT_FALSE(host2->IsObservedBy(queue()));
EXPECT_FALSE(host3->IsObservedBy(queue()));
EXPECT_FALSE(host4->IsObservedBy(queue()));
}
} // namespace extensions
|