1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
|
// Copyright 2015 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/bind.h"
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
#include "base/message_loop/message_loop.h"
#include "extensions/common/extension.h"
#include "extensions/common/extension_set.h"
#include "extensions/common/features/feature.h"
#include "extensions/renderer/gc_callback.h"
#include "extensions/renderer/scoped_web_frame.h"
#include "extensions/renderer/script_context.h"
#include "extensions/renderer/script_context_set.h"
#include "gin/function_template.h"
#include "gin/public/context_holder.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/WebKit/public/web/WebFrame.h"
#include "v8/include/v8.h"
namespace extensions {
namespace {
void SetToTrue(bool* value) {
if (*value)
ADD_FAILURE() << "Value is already true";
*value = true;
}
class GCCallbackTest : public testing::Test {
public:
GCCallbackTest() : script_context_set_(&active_extensions_) {}
protected:
base::MessageLoop& message_loop() { return message_loop_; }
ScriptContextSet& script_context_set() { return script_context_set_; }
v8::Local<v8::Context> v8_context() {
return v8::Local<v8::Context>::New(v8::Isolate::GetCurrent(), v8_context_);
}
ScriptContext* RegisterScriptContext() {
// No extension group or world ID.
return script_context_set_.Register(
web_frame_.frame(),
v8::Local<v8::Context>::New(v8::Isolate::GetCurrent(), v8_context_), 0,
0);
}
void RequestGarbageCollection() {
v8::Isolate::GetCurrent()->RequestGarbageCollectionForTesting(
v8::Isolate::kFullGarbageCollection);
}
private:
void SetUp() override {
v8::Isolate* isolate = v8::Isolate::GetCurrent();
v8::HandleScope handle_scope(isolate);
v8::Local<v8::Context> local_v8_context = v8::Context::New(isolate);
v8_context_.Reset(isolate, local_v8_context);
// ScriptContexts rely on gin.
gin_context_holder_.reset(new gin::ContextHolder(isolate));
gin_context_holder_->SetContext(local_v8_context);
}
void TearDown() override {
gin_context_holder_.reset();
v8_context_.Reset();
RequestGarbageCollection();
}
base::MessageLoop message_loop_;
ScopedWebFrame web_frame_; // (this will construct the v8::Isolate)
ExtensionIdSet active_extensions_;
ScriptContextSet script_context_set_;
v8::Global<v8::Context> v8_context_;
scoped_ptr<gin::ContextHolder> gin_context_holder_;
DISALLOW_COPY_AND_ASSIGN(GCCallbackTest);
};
TEST_F(GCCallbackTest, GCBeforeContextInvalidated) {
v8::Isolate* isolate = v8::Isolate::GetCurrent();
v8::HandleScope handle_scope(isolate);
v8::Context::Scope context_scope(v8_context());
ScriptContext* script_context = RegisterScriptContext();
bool callback_invoked = false;
bool fallback_invoked = false;
{
// Nest another HandleScope so that |object| and |unreachable_function|'s
// handles will be garbage collected.
v8::HandleScope handle_scope(isolate);
v8::Local<v8::Object> object = v8::Object::New(isolate);
v8::Local<v8::FunctionTemplate> unreachable_function =
gin::CreateFunctionTemplate(isolate,
base::Bind(SetToTrue, &callback_invoked));
// The GCCallback will delete itself, or memory tests will complain.
new GCCallback(script_context, object, unreachable_function->GetFunction(),
base::Bind(SetToTrue, &fallback_invoked));
}
// Trigger a GC. Only the callback should be invoked.
RequestGarbageCollection();
message_loop().RunUntilIdle();
EXPECT_TRUE(callback_invoked);
EXPECT_FALSE(fallback_invoked);
// Invalidate the context. The fallback should not be invoked because the
// callback was already invoked.
script_context_set().Remove(script_context);
message_loop().RunUntilIdle();
EXPECT_FALSE(fallback_invoked);
}
TEST_F(GCCallbackTest, ContextInvalidatedBeforeGC) {
v8::Isolate* isolate = v8::Isolate::GetCurrent();
v8::HandleScope handle_scope(isolate);
v8::Context::Scope context_scope(v8_context());
ScriptContext* script_context = RegisterScriptContext();
bool callback_invoked = false;
bool fallback_invoked = false;
{
// Nest another HandleScope so that |object| and |unreachable_function|'s
// handles will be garbage collected.
v8::HandleScope handle_scope(isolate);
v8::Local<v8::Object> object = v8::Object::New(isolate);
v8::Local<v8::FunctionTemplate> unreachable_function =
gin::CreateFunctionTemplate(isolate,
base::Bind(SetToTrue, &callback_invoked));
// The GCCallback will delete itself, or memory tests will complain.
new GCCallback(script_context, object, unreachable_function->GetFunction(),
base::Bind(SetToTrue, &fallback_invoked));
}
// Invalidate the context. Only the fallback should be invoked.
script_context_set().Remove(script_context);
message_loop().RunUntilIdle();
EXPECT_FALSE(callback_invoked);
EXPECT_TRUE(fallback_invoked);
// Trigger a GC. The callback should not be invoked because the fallback was
// already invoked.
RequestGarbageCollection();
message_loop().RunUntilIdle();
EXPECT_FALSE(callback_invoked);
}
} // namespace
} // namespace extensions
|
