1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
|
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "remoting/host/resizing_host_observer.h"
#include "remoting/host/desktop_resizer.h"
#include <list>
#include "base/compiler_specific.h"
#include "base/logging.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/skia/include/core/SkSize.h"
std::ostream& operator<<(std::ostream& os, const SkISize& size) {
return os << size.width() << "x" << size.height();
}
namespace remoting {
class FakeDesktopResizer : public DesktopResizer {
public:
FakeDesktopResizer(const SkISize& initial_size, bool exact_size_supported,
const SkISize* supported_sizes, int num_supported_sizes)
: initial_size_(initial_size),
current_size_(initial_size),
exact_size_supported_(exact_size_supported),
set_size_call_count_(0) {
for (int i = 0; i < num_supported_sizes; ++i) {
supported_sizes_.push_back(supported_sizes[i]);
}
}
const SkISize& initial_size() { return initial_size_; }
int set_size_call_count() { return set_size_call_count_; }
// remoting::DesktopResizer interface
virtual SkISize GetCurrentSize() OVERRIDE {
return current_size_;
}
virtual std::list<SkISize> GetSupportedSizes(
const SkISize& preferred) OVERRIDE {
std::list<SkISize> result = supported_sizes_;
if (exact_size_supported_) {
result.push_back(preferred);
}
return result;
}
virtual void SetSize(const SkISize& size) OVERRIDE {
current_size_ = size;
++set_size_call_count_;
}
virtual void RestoreSize(const SkISize& size) OVERRIDE {
current_size_ = size;
}
private:
SkISize initial_size_;
SkISize current_size_;
bool exact_size_supported_;
std::list<SkISize> supported_sizes_;
int set_size_call_count_;
};
class ResizingHostObserverTest : public testing::Test {
public:
void SetDesktopResizer(FakeDesktopResizer* desktop_resizer) {
CHECK(!desktop_resizer_.get()) << "Call SetDeskopResizer once per test";
resizing_host_observer_.reset(new ResizingHostObserver(desktop_resizer,
NULL));
desktop_resizer_.reset(desktop_resizer);
resizing_host_observer_->OnClientAuthenticated("");
}
SkISize GetBestSize(const SkISize& client_size) {
resizing_host_observer_->OnClientResolutionChanged(
"", client_size, SkIPoint());
return desktop_resizer_->GetCurrentSize();
}
void VerifySizes(const SkISize* client_sizes, const SkISize* expected_sizes,
int number_of_sizes) {
for (int i = 0; i < number_of_sizes; ++i) {
SkISize best_size = GetBestSize(client_sizes[i]);
EXPECT_EQ(expected_sizes[i], best_size)
<< "Input size = " << client_sizes[i];
}
}
void Reconnect() {
resizing_host_observer_->OnClientDisconnected("");
resizing_host_observer_->OnClientAuthenticated("");
}
// testing::Test interface
virtual void TearDown() OVERRIDE {
resizing_host_observer_->OnClientDisconnected("");
EXPECT_EQ(desktop_resizer_->initial_size(),
desktop_resizer_->GetCurrentSize());
}
private:
scoped_ptr<ResizingHostObserver> resizing_host_observer_;
scoped_ptr<FakeDesktopResizer> desktop_resizer_;
};
// Check that the host is not resized if it reports an initial size of zero
// (even if it GetSupportedSizes does not return an empty list).
TEST_F(ResizingHostObserverTest, ZeroGetCurrentSize) {
SkISize zero = { 0, 0 };
SetDesktopResizer(
new FakeDesktopResizer(zero, true, NULL, 0));
SkISize client_sizes[] = { { 200, 100 }, { 100, 200 } };
SkISize expected_sizes[] = { zero, zero };
VerifySizes(client_sizes, expected_sizes, arraysize(client_sizes));
}
// Check that the host is not resized if GetSupportedSizes returns an empty
// list (even if GetCurrentSize is supported).
TEST_F(ResizingHostObserverTest, EmptyGetSupportedSizes) {
SkISize initial = { 640, 480 };
SetDesktopResizer(
new FakeDesktopResizer(initial, false, NULL, 0));
SkISize client_sizes[] = { { 200, 100 }, { 100, 200 } };
SkISize expected_sizes[] = { initial, initial };
VerifySizes(client_sizes, expected_sizes, arraysize(client_sizes));
}
// Check that if the implementation supports exact size matching, it is used.
TEST_F(ResizingHostObserverTest, SelectExactSize) {
SetDesktopResizer(
new FakeDesktopResizer(SkISize::Make(640, 480), true, NULL, 0));
SkISize client_sizes[] = { { 200, 100 }, { 100, 200 } , { 640, 480 },
{ 480, 640 }, { 1280, 1024 } };
VerifySizes(client_sizes, client_sizes, arraysize(client_sizes));
}
// Check that if the implementation supports a size that is no larger than
// the requested size, then the largest such size is used.
TEST_F(ResizingHostObserverTest, SelectBestSmallerSize) {
SkISize supported_sizes[] = {
SkISize::Make(639, 479), SkISize::Make(640, 480) };
SetDesktopResizer(
new FakeDesktopResizer(SkISize::Make(640, 480), false,
supported_sizes, arraysize(supported_sizes)));
SkISize client_sizes[] = { { 639, 479 }, { 640, 480 }, { 641, 481 },
{ 999, 999 } };
SkISize expected_sizes[] = { supported_sizes[0], supported_sizes[1],
supported_sizes[1], supported_sizes[1] };
VerifySizes(client_sizes, expected_sizes, arraysize(client_sizes));
}
// Check that if the implementation supports only sizes that are larger than
// the requested size, then the one that requires the least down-scaling.
TEST_F(ResizingHostObserverTest, SelectBestScaleFactor) {
SkISize supported_sizes[] = { { 100, 100 }, { 200, 100 } };
SetDesktopResizer(
new FakeDesktopResizer(SkISize::Make(200, 100), false,
supported_sizes, arraysize(supported_sizes)));
SkISize client_sizes[] = { { 1, 1 }, { 99, 99 }, { 199, 99 } };
SkISize expected_sizes[] = { supported_sizes[0], supported_sizes[0],
supported_sizes[1] };
VerifySizes(client_sizes, expected_sizes, arraysize(client_sizes));
}
// Check that if the implementation supports two sizes that have the same
// resultant scale factor, then the widest one is selected.
TEST_F(ResizingHostObserverTest, SelectWidest) {
SkISize supported_sizes[] = { { 640, 480 }, { 480, 640 } };
SetDesktopResizer(
new FakeDesktopResizer(SkISize::Make(480, 640), false,
supported_sizes, arraysize(supported_sizes)));
SkISize client_sizes[] = { { 100, 100 }, { 480, 480 }, { 500, 500 },
{ 640, 640 }, { 1000, 1000 } };
SkISize expected_sizes[] = { supported_sizes[0], supported_sizes[0],
supported_sizes[0], supported_sizes[0],
supported_sizes[0] };
VerifySizes(client_sizes, expected_sizes, arraysize(client_sizes));
}
// Check that resize-to-client is disabled if the size is changed explicitly.
TEST_F(ResizingHostObserverTest, ManualResize) {
FakeDesktopResizer* desktop_resizer =
new FakeDesktopResizer(SkISize::Make(640, 480), true, NULL, 0);
SetDesktopResizer(desktop_resizer);
SkISize client_sizes[] = { { 1, 1 }, { 2, 2 } , { 3, 3 } };
VerifySizes(client_sizes, client_sizes, arraysize(client_sizes));
SkISize explicit_size = SkISize::Make(640, 480);
desktop_resizer->SetSize(explicit_size);
SkISize expected_sizes[] = { explicit_size, explicit_size, explicit_size };
VerifySizes(client_sizes, expected_sizes, arraysize(client_sizes));
// Make sure this behaviour doesn't persist across reconnect.
Reconnect();
VerifySizes(client_sizes, client_sizes, arraysize(client_sizes));
}
// Check that if the best match for the client size doesn't change, then we
// don't call SetSize.
TEST_F(ResizingHostObserverTest, NoSetSizeForSameSize) {
SkISize supported_sizes[] = { { 640, 480 }, { 480, 640 } };
FakeDesktopResizer* desktop_resizer =
new FakeDesktopResizer(SkISize::Make(640, 480), false,
supported_sizes, arraysize(supported_sizes));
SetDesktopResizer(desktop_resizer);
SkISize client_sizes[] = { { 640, 640 }, { 1024, 768 }, { 640, 480 } };
SkISize expected_sizes[] = { { 640, 480 }, { 640, 480 }, { 640, 480 } };
VerifySizes(client_sizes, expected_sizes, arraysize(client_sizes));
EXPECT_EQ(desktop_resizer->set_size_call_count(), 0);
}
} // namespace remoting
|
