1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
|
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <string>
#include "base/bind.h"
#include "base/bind_helpers.h"
#include "base/callback.h"
#include "base/message_loop.h"
#include "base/stl_util.h"
#include "base/synchronization/waitable_event.h"
#include "base/threading/thread.h"
#include "net/socket/socket.h"
#include "remoting/protocol/fake_session.h"
#include "remoting/protocol/message_reader.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "third_party/libjingle/source/talk/base/byteorder.h"
using testing::_;
using testing::DoAll;
using testing::Mock;
using testing::SaveArg;
namespace remoting {
namespace protocol {
namespace {
const char kTestMessage1[] = "Message1";
const char kTestMessage2[] = "Message2";
ACTION(CallDoneTask) {
arg0.Run();
}
} // namespace
class MockMessageReceivedCallback {
public:
MOCK_METHOD1(OnMessage, void(const base::Closure&));
};
class MessageReaderTest : public testing::Test {
public:
MessageReaderTest()
: other_thread_("SecondTestThread"),
run_task_finished_(false, false) {
}
void RunDoneTaskOnOtherThread(const base::Closure& done_task) {
other_thread_.message_loop()->PostTask(
FROM_HERE,
base::Bind(&MessageReaderTest::RunClosure,
base::Unretained(this), done_task));
}
protected:
virtual void SetUp() OVERRIDE {
reader_ = new MessageReader();
}
virtual void TearDown() OVERRIDE {
STLDeleteElements(&messages_);
}
void InitReader() {
reader_->Init(&socket_, base::Bind(
&MessageReaderTest::OnMessage, base::Unretained(this)));
}
void AddMessage(const std::string& message) {
std::string data = std::string(4, ' ') + message;
talk_base::SetBE32(const_cast<char*>(data.data()), message.size());
socket_.AppendInputData(std::vector<char>(data.begin(), data.end()));
}
bool CompareResult(CompoundBuffer* buffer, const std::string& expected) {
std::string result(buffer->total_bytes(), ' ');
buffer->CopyTo(const_cast<char*>(result.data()), result.size());
return result == expected;
}
void RunClosure(const base::Closure& task) {
task.Run();
run_task_finished_.Signal();
}
void OnMessage(scoped_ptr<CompoundBuffer> buffer,
const base::Closure& done_callback) {
messages_.push_back(buffer.release());
callback_.OnMessage(done_callback);
}
MessageLoop message_loop_;
base::Thread other_thread_;
base::WaitableEvent run_task_finished_;
scoped_refptr<MessageReader> reader_;
FakeSocket socket_;
MockMessageReceivedCallback callback_;
std::vector<CompoundBuffer*> messages_;
};
// Receive one message and process it with delay
TEST_F(MessageReaderTest, OneMessage_Delay) {
base::Closure done_task;
AddMessage(kTestMessage1);
EXPECT_CALL(callback_, OnMessage(_))
.Times(1)
.WillOnce(SaveArg<0>(&done_task));
InitReader();
Mock::VerifyAndClearExpectations(&callback_);
Mock::VerifyAndClearExpectations(&socket_);
EXPECT_TRUE(CompareResult(messages_[0], kTestMessage1));
// Verify that the reader starts reading again only after we've
// finished processing the previous message.
EXPECT_FALSE(socket_.read_pending());
done_task.Run();
EXPECT_TRUE(socket_.read_pending());
}
// Receive one message and process it instantly.
TEST_F(MessageReaderTest, OneMessage_Instant) {
AddMessage(kTestMessage1);
EXPECT_CALL(callback_, OnMessage(_))
.Times(1)
.WillOnce(CallDoneTask());
InitReader();
EXPECT_TRUE(socket_.read_pending());
EXPECT_EQ(1U, messages_.size());
}
// Receive two messages in one packet.
TEST_F(MessageReaderTest, TwoMessages_Together) {
base::Closure done_task1;
base::Closure done_task2;
AddMessage(kTestMessage1);
AddMessage(kTestMessage2);
EXPECT_CALL(callback_, OnMessage(_))
.Times(2)
.WillOnce(SaveArg<0>(&done_task1))
.WillOnce(SaveArg<0>(&done_task2));
InitReader();
Mock::VerifyAndClearExpectations(&callback_);
Mock::VerifyAndClearExpectations(&socket_);
EXPECT_TRUE(CompareResult(messages_[0], kTestMessage1));
EXPECT_TRUE(CompareResult(messages_[1], kTestMessage2));
// Verify that the reader starts reading again only after we've
// finished processing the previous message.
EXPECT_FALSE(socket_.read_pending());
done_task1.Run();
EXPECT_FALSE(socket_.read_pending());
done_task2.Run();
EXPECT_TRUE(socket_.read_pending());
}
// Receive two messages in one packet, and process the first one
// instantly.
TEST_F(MessageReaderTest, TwoMessages_Instant) {
base::Closure done_task2;
AddMessage(kTestMessage1);
AddMessage(kTestMessage2);
EXPECT_CALL(callback_, OnMessage(_))
.Times(2)
.WillOnce(CallDoneTask())
.WillOnce(SaveArg<0>(&done_task2));
InitReader();
Mock::VerifyAndClearExpectations(&callback_);
Mock::VerifyAndClearExpectations(&socket_);
EXPECT_TRUE(CompareResult(messages_[1], kTestMessage2));
// Verify that the reader starts reading again only after we've
// finished processing the second message.
EXPECT_FALSE(socket_.read_pending());
done_task2.Run();
EXPECT_TRUE(socket_.read_pending());
}
// Receive two messages in one packet, and process both of them
// instantly.
TEST_F(MessageReaderTest, TwoMessages_Instant2) {
AddMessage(kTestMessage1);
AddMessage(kTestMessage2);
EXPECT_CALL(callback_, OnMessage(_))
.Times(2)
.WillOnce(CallDoneTask())
.WillOnce(CallDoneTask());
InitReader();
EXPECT_TRUE(socket_.read_pending());
}
// Receive two messages in separate packets.
TEST_F(MessageReaderTest, TwoMessages_Separately) {
base::Closure done_task;
AddMessage(kTestMessage1);
EXPECT_CALL(callback_, OnMessage(_))
.Times(1)
.WillOnce(SaveArg<0>(&done_task));
InitReader();
Mock::VerifyAndClearExpectations(&callback_);
Mock::VerifyAndClearExpectations(&socket_);
EXPECT_TRUE(CompareResult(messages_[0], kTestMessage1));
// Verify that the reader starts reading again only after we've
// finished processing the previous message.
EXPECT_FALSE(socket_.read_pending());
done_task.Run();
EXPECT_TRUE(socket_.read_pending());
// Write another message and verify that we receive it.
EXPECT_CALL(callback_, OnMessage(_))
.Times(1)
.WillOnce(SaveArg<0>(&done_task));
AddMessage(kTestMessage2);
EXPECT_TRUE(CompareResult(messages_[1], kTestMessage2));
// Verify that the reader starts reading again only after we've
// finished processing the previous message.
EXPECT_FALSE(socket_.read_pending());
done_task.Run();
EXPECT_TRUE(socket_.read_pending());
}
// Verify that socket operations occur on same thread, even when the OnMessage()
// callback triggers |done_task| to run on a different thread.
TEST_F(MessageReaderTest, UseSocketOnCorrectThread) {
AddMessage(kTestMessage1);
other_thread_.Start();
EXPECT_CALL(callback_, OnMessage(_))
.Times(1)
.WillOnce(Invoke(this, &MessageReaderTest::RunDoneTaskOnOtherThread));
InitReader();
run_task_finished_.Wait();
message_loop_.RunAllPending();
// Write another message and verify that we receive it.
base::Closure done_task;
EXPECT_CALL(callback_, OnMessage(_))
.Times(1)
.WillOnce(SaveArg<0>(&done_task));
AddMessage(kTestMessage2);
EXPECT_TRUE(CompareResult(messages_[1], kTestMessage2));
done_task.Run();
}
} // namespace protocol
} // namespace remoting
|