1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
|
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "sync/engine/verify_updates_command.h"
#include <string>
#include "base/location.h"
#include "sync/engine/syncer.h"
#include "sync/engine/syncer_proto_util.h"
#include "sync/engine/syncer_types.h"
#include "sync/engine/syncer_util.h"
#include "sync/engine/syncproto.h"
#include "sync/internal_api/public/engine/model_safe_worker.h"
#include "sync/protocol/bookmark_specifics.pb.h"
#include "sync/syncable/syncable.h"
namespace browser_sync {
using syncable::WriteTransaction;
using syncable::GET_BY_ID;
using syncable::ModelTypeSet;
using syncable::SYNCER;
namespace {
// This function attempts to determine whether or not this update is genuinely
// new, or if it is a reflection of one of our own commits.
//
// There is a known inaccuracy in its implementation. If this update ends up
// being applied to a local item with a different ID, we will count the change
// as being a non-reflection update. Fortunately, the server usually updates
// our IDs correctly in its commit response, so a new ID during GetUpdate should
// be rare.
//
// The only secnarios I can think of where this might happen are:
// - We commit a new item to the server, but we don't persist the
// server-returned new ID to the database before we shut down. On the GetUpdate
// following the next restart, we will receive an update from the server that
// updates its local ID.
// - When two attempts to create an item with identical UNIQUE_CLIENT_TAG values
// collide at the server. I have seen this in testing. When it happens, the
// test server will send one of the clients a response to upate its local ID so
// that both clients will refer to the item using the same ID going forward. In
// this case, we're right to assume that the update is not a reflection.
//
// For more information, see SyncerUtil::FindLocalIdToUpdate().
bool UpdateContainsNewVersion(syncable::BaseTransaction *trans,
const SyncEntity &update) {
int64 existing_version = -1; // The server always sends positive versions.
syncable::Entry existing_entry(trans, GET_BY_ID, update.id());
if (existing_entry.good())
existing_version = existing_entry.Get(syncable::BASE_VERSION);
return existing_version < update.version();
}
// In the event that IDs match, but tags differ AttemptReuniteClient tag
// will have refused to unify the update.
// We should not attempt to apply it at all since it violates consistency
// rules.
VerifyResult VerifyTagConsistency(const SyncEntity& entry,
const syncable::MutableEntry& same_id) {
if (entry.has_client_defined_unique_tag() &&
entry.client_defined_unique_tag() !=
same_id.Get(syncable::UNIQUE_CLIENT_TAG)) {
return VERIFY_FAIL;
}
return VERIFY_UNDECIDED;
}
} // namespace
VerifyUpdatesCommand::VerifyUpdatesCommand() {}
VerifyUpdatesCommand::~VerifyUpdatesCommand() {}
std::set<ModelSafeGroup> VerifyUpdatesCommand::GetGroupsToChange(
const sessions::SyncSession& session) const {
std::set<ModelSafeGroup> groups_with_updates;
const GetUpdatesResponse& updates =
session.status_controller().updates_response().get_updates();
for (int i = 0; i < updates.entries().size(); i++) {
groups_with_updates.insert(
GetGroupForModelType(syncable::GetModelType(updates.entries(i)),
session.routing_info()));
}
return groups_with_updates;
}
SyncerError VerifyUpdatesCommand::ModelChangingExecuteImpl(
sessions::SyncSession* session) {
DVLOG(1) << "Beginning Update Verification";
syncable::Directory* dir = session->context()->directory();
WriteTransaction trans(FROM_HERE, SYNCER, dir);
sessions::StatusController* status = session->mutable_status_controller();
const GetUpdatesResponse& updates = status->updates_response().get_updates();
int update_count = updates.entries().size();
ModelTypeSet requested_types = browser_sync::GetRoutingInfoTypes(
session->routing_info());
DVLOG(1) << update_count << " entries to verify";
for (int i = 0; i < update_count; i++) {
const SyncEntity& update =
*reinterpret_cast<const SyncEntity *>(&(updates.entries(i)));
ModelSafeGroup g = GetGroupForModelType(update.GetModelType(),
session->routing_info());
if (g != status->group_restriction())
continue;
VerifyUpdateResult result = VerifyUpdate(&trans, update,
requested_types,
session->routing_info());
status->mutable_update_progress()->AddVerifyResult(result.value, update);
status->increment_num_updates_downloaded_by(1);
if (!UpdateContainsNewVersion(&trans, update))
status->increment_num_reflected_updates_downloaded_by(1);
if (update.deleted())
status->increment_num_tombstone_updates_downloaded_by(1);
}
return SYNCER_OK;
}
VerifyUpdatesCommand::VerifyUpdateResult VerifyUpdatesCommand::VerifyUpdate(
syncable::WriteTransaction* trans, const SyncEntity& entry,
const ModelTypeSet& requested_types,
const ModelSafeRoutingInfo& routes) {
syncable::Id id = entry.id();
VerifyUpdateResult result = {VERIFY_FAIL, GROUP_PASSIVE};
const bool deleted = entry.has_deleted() && entry.deleted();
const bool is_directory = entry.IsFolder();
const syncable::ModelType model_type = entry.GetModelType();
if (!id.ServerKnows()) {
LOG(ERROR) << "Illegal negative id in received updates";
return result;
}
{
const std::string name = SyncerProtoUtil::NameFromSyncEntity(entry);
if (name.empty() && !deleted) {
LOG(ERROR) << "Zero length name in non-deleted update";
return result;
}
}
syncable::MutableEntry same_id(trans, GET_BY_ID, id);
result.value = SyncerUtil::VerifyNewEntry(entry, &same_id, deleted);
syncable::ModelType placement_type = !deleted ? entry.GetModelType()
: same_id.good() ? same_id.GetModelType() : syncable::UNSPECIFIED;
result.placement = GetGroupForModelType(placement_type, routes);
if (VERIFY_UNDECIDED == result.value) {
result.value = VerifyTagConsistency(entry, same_id);
}
if (VERIFY_UNDECIDED == result.value) {
if (deleted) {
// For deletes the server could send tombostones for items that
// the client did not request. If so ignore those items.
if (IsRealDataType(placement_type) &&
!requested_types.Has(placement_type)) {
result.value = VERIFY_SKIP;
} else {
result.value = VERIFY_SUCCESS;
}
}
}
// If we have an existing entry, we check here for updates that break
// consistency rules.
if (VERIFY_UNDECIDED == result.value) {
result.value = SyncerUtil::VerifyUpdateConsistency(trans, entry, &same_id,
deleted, is_directory, model_type);
}
if (VERIFY_UNDECIDED == result.value)
result.value = VERIFY_SUCCESS; // No news is good news.
return result; // This might be VERIFY_SUCCESS as well
}
} // namespace browser_sync
|
