1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
|
// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <vector>
#include "testing/gtest/include/gtest/gtest.h"
#include "tools/gn/header_checker.h"
#include "tools/gn/scheduler.h"
#include "tools/gn/target.h"
#include "tools/gn/test_with_scope.h"
namespace {
class HeaderCheckerTest : public testing::Test {
public:
HeaderCheckerTest()
: a_(setup_.settings(), Label(SourceDir("//a/"), "a")),
b_(setup_.settings(), Label(SourceDir("//b/"), "a")),
c_(setup_.settings(), Label(SourceDir("//c/"), "c")) {
a_.deps().push_back(LabelTargetPair(&b_));
b_.deps().push_back(LabelTargetPair(&c_));
// Start with all public visibility.
a_.visibility().SetPublic();
b_.visibility().SetPublic();
c_.visibility().SetPublic();
targets_.push_back(&a_);
targets_.push_back(&b_);
targets_.push_back(&c_);
}
protected:
Scheduler scheduler_;
TestWithScope setup_;
// Some headers that are automatically set up with a dependency chain.
// a -> b -> c
Target a_;
Target b_;
Target c_;
std::vector<const Target*> targets_;
};
} // namespace
TEST_F(HeaderCheckerTest, IsDependencyOf) {
scoped_refptr<HeaderChecker> checker(
new HeaderChecker(setup_.build_settings(), targets_));
std::vector<const Target*> chain;
EXPECT_FALSE(checker->IsDependencyOf(&a_, &a_, &chain));
chain.clear();
EXPECT_TRUE(checker->IsDependencyOf(&b_, &a_, &chain));
ASSERT_EQ(2u, chain.size());
EXPECT_EQ(&b_, chain[0]);
EXPECT_EQ(&a_, chain[1]);
chain.clear();
EXPECT_TRUE(checker->IsDependencyOf(&c_, &a_, &chain));
ASSERT_EQ(3u, chain.size());
EXPECT_EQ(&c_, chain[0]);
EXPECT_EQ(&b_, chain[1]);
EXPECT_EQ(&a_, chain[2]);
chain.clear();
EXPECT_FALSE(checker->IsDependencyOf(&a_, &c_, &chain));
EXPECT_TRUE(chain.empty());
}
TEST_F(HeaderCheckerTest, CheckInclude) {
InputFile input_file(SourceFile("//some_file.cc"));
input_file.SetContents(std::string());
LocationRange range; // Dummy value.
// Add a disconnected target d with a header to check that you have to have
// to depend on a target listing a header.
Target d(setup_.settings(), Label(SourceDir("//"), "d"));
SourceFile d_header("//d_header.h");
d.sources().push_back(SourceFile(d_header));
// Add a header on B and say everything in B is public.
SourceFile b_public("//b_public.h");
b_.sources().push_back(b_public);
c_.set_all_headers_public(true);
// Add a public and private header on C.
SourceFile c_public("//c_public.h");
SourceFile c_private("//c_private.h");
c_.sources().push_back(c_private);
c_.public_headers().push_back(c_public);
c_.set_all_headers_public(false);
targets_.push_back(&d);
scoped_refptr<HeaderChecker> checker(
new HeaderChecker(setup_.build_settings(), targets_));
// A file in target A can't include a header from D because A has no
// dependency on D.
Err err;
EXPECT_FALSE(checker->CheckInclude(&a_, input_file, d_header, range, &err));
EXPECT_TRUE(err.has_error());
// A can include the public header in B.
err = Err();
EXPECT_TRUE(checker->CheckInclude(&a_, input_file, b_public, range, &err));
EXPECT_FALSE(err.has_error());
// Check A depending on the public and private headers in C.
err = Err();
EXPECT_TRUE(checker->CheckInclude(&a_, input_file, c_public, range, &err));
EXPECT_FALSE(err.has_error());
EXPECT_FALSE(checker->CheckInclude(&a_, input_file, c_private, range, &err));
EXPECT_TRUE(err.has_error());
// A can depend on a random file unknown to the build.
err = Err();
EXPECT_TRUE(checker->CheckInclude(&a_, input_file, SourceFile("//random.h"),
range, &err));
EXPECT_FALSE(err.has_error());
// If C is not visible from A, A can't include public headers even if there
// is a dependency path.
c_.visibility().SetPrivate(c_.label().dir());
err = Err();
EXPECT_FALSE(checker->CheckInclude(&a_, input_file, c_public, range, &err));
EXPECT_TRUE(err.has_error());
}
TEST_F(HeaderCheckerTest, DoDirectDependentConfigsApply) {
// Assume we have a chain A -> B -> C -> D.
Target target_a(setup_.settings(), Label(SourceDir("//a/"), "a"));
Target target_b(setup_.settings(), Label(SourceDir("//b/"), "b"));
Target target_c(setup_.settings(), Label(SourceDir("//c/"), "c"));
Target target_d(setup_.settings(), Label(SourceDir("//d/"), "d"));
// C is a group, and B forwards deps from C, so A should get configs from D.
target_a.set_output_type(Target::SOURCE_SET);
target_b.set_output_type(Target::SOURCE_SET);
target_c.set_output_type(Target::GROUP);
target_d.set_output_type(Target::SOURCE_SET);
target_b.forward_dependent_configs().push_back(
LabelTargetPair(&target_c));
// Dependency chain goes from bottom to top.
std::vector<const Target*> chain;
chain.push_back(&target_d);
chain.push_back(&target_c);
chain.push_back(&target_b);
chain.push_back(&target_a);
// This chain should be valid.
size_t badone = 0;
EXPECT_TRUE(HeaderChecker::DoDirectDependentConfigsApply(chain, &badone));
// If C is not a group, it shouldn't work anymore.
target_c.set_output_type(Target::SOURCE_SET);
EXPECT_FALSE(HeaderChecker::DoDirectDependentConfigsApply(chain, &badone));
EXPECT_EQ(1u, badone);
// Or if B stops forwarding from C, it shouldn't work anymore.
target_c.set_output_type(Target::GROUP);
badone = 0;
target_b.forward_dependent_configs().clear();
EXPECT_FALSE(HeaderChecker::DoDirectDependentConfigsApply(chain, &badone));
EXPECT_EQ(2u, badone);
}
|
