1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
|
// Copyright (c) 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "testing/gtest/include/gtest/gtest.h"
#include "tools/gn/input_file.h"
#include "tools/gn/parse_tree.h"
#include "tools/gn/scope.h"
#include "tools/gn/test_with_scope.h"
namespace {
bool HasStringValueEqualTo(const Scope* scope,
const char* name,
const char* expected_value) {
const Value* value = scope->GetValue(name);
if (!value)
return false;
if (value->type() != Value::STRING)
return false;
return value->string_value() == expected_value;
}
} // namespace
TEST(Scope, NonRecursiveMergeTo) {
TestWithScope setup;
// Make a pretend parse node with proper tracking that we can blame for the
// given value.
InputFile input_file(SourceFile("//foo"));
Token assignment_token(Location(&input_file, 1, 1), Token::STRING,
"\"hello\"");
LiteralNode assignment;
assignment.set_value(assignment_token);
Value old_value(&assignment, "hello");
setup.scope()->SetValue("v", old_value, &assignment);
base::StringPiece private_var_name("_private");
setup.scope()->SetValue(private_var_name, old_value, &assignment);
// Detect collisions of values' values.
{
Scope new_scope(setup.settings());
Value new_value(&assignment, "goodbye");
new_scope.SetValue("v", new_value, &assignment);
Err err;
EXPECT_FALSE(setup.scope()->NonRecursiveMergeTo(
&new_scope, Scope::MergeOptions(),
&assignment, "error", &err));
EXPECT_TRUE(err.has_error());
}
// The clobber flag should just overwrite colliding values.
{
Scope new_scope(setup.settings());
Value new_value(&assignment, "goodbye");
new_scope.SetValue("v", new_value, &assignment);
Err err;
Scope::MergeOptions options;
options.clobber_existing = true;
EXPECT_TRUE(setup.scope()->NonRecursiveMergeTo(
&new_scope, options, &assignment, "error", &err));
EXPECT_FALSE(err.has_error());
const Value* found_value = new_scope.GetValue("v");
ASSERT_TRUE(found_value);
EXPECT_TRUE(old_value == *found_value);
}
// Don't flag values that technically collide but have the same value.
{
Scope new_scope(setup.settings());
Value new_value(&assignment, "hello");
new_scope.SetValue("v", new_value, &assignment);
Err err;
Scope::MergeOptions options;
options.clobber_existing = true;
EXPECT_TRUE(setup.scope()->NonRecursiveMergeTo(
&new_scope, options, &assignment, "error", &err));
EXPECT_FALSE(err.has_error());
}
// Copy private values.
{
Scope new_scope(setup.settings());
Err err;
EXPECT_TRUE(setup.scope()->NonRecursiveMergeTo(
&new_scope, Scope::MergeOptions(), &assignment, "error", &err));
EXPECT_FALSE(err.has_error());
EXPECT_TRUE(new_scope.GetValue(private_var_name));
}
// Skip private values.
{
Scope new_scope(setup.settings());
Err err;
Scope::MergeOptions options;
options.skip_private_vars = true;
EXPECT_TRUE(setup.scope()->NonRecursiveMergeTo(
&new_scope, options, &assignment, "error", &err));
EXPECT_FALSE(err.has_error());
EXPECT_FALSE(new_scope.GetValue(private_var_name));
}
// Don't mark used.
{
Scope new_scope(setup.settings());
Err err;
Scope::MergeOptions options;
EXPECT_TRUE(setup.scope()->NonRecursiveMergeTo(
&new_scope, options, &assignment, "error", &err));
EXPECT_FALSE(err.has_error());
EXPECT_FALSE(new_scope.CheckForUnusedVars(&err));
EXPECT_TRUE(err.has_error());
}
// Mark used.
{
Scope new_scope(setup.settings());
Err err;
Scope::MergeOptions options;
options.mark_used = true;
EXPECT_TRUE(setup.scope()->NonRecursiveMergeTo(
&new_scope, options, &assignment, "error", &err));
EXPECT_FALSE(err.has_error());
EXPECT_TRUE(new_scope.CheckForUnusedVars(&err));
EXPECT_FALSE(err.has_error());
}
}
TEST(Scope, MakeClosure) {
// Create 3 nested scopes [const root from setup] <- nested1 <- nested2.
TestWithScope setup;
// Make a pretend parse node with proper tracking that we can blame for the
// given value.
InputFile input_file(SourceFile("//foo"));
Token assignment_token(Location(&input_file, 1, 1), Token::STRING,
"\"hello\"");
LiteralNode assignment;
assignment.set_value(assignment_token);
setup.scope()->SetValue("on_root", Value(&assignment, "on_root"),
&assignment);
// Root scope should be const from the nested caller's perspective.
Scope nested1(static_cast<const Scope*>(setup.scope()));
nested1.SetValue("on_one", Value(&assignment, "on_one"), &assignment);
Scope nested2(&nested1);
nested2.SetValue("on_one", Value(&assignment, "on_two"), &assignment);
nested2.SetValue("on_two", Value(&assignment, "on_two2"), &assignment);
// Making a closure from the root scope.
scoped_ptr<Scope> result = setup.scope()->MakeClosure();
EXPECT_FALSE(result->containing()); // Should have no containing scope.
EXPECT_TRUE(result->GetValue("on_root")); // Value should be copied.
// Making a closure from the second nested scope.
result = nested2.MakeClosure();
EXPECT_EQ(setup.scope(),
result->containing()); // Containing scope should be the root.
EXPECT_TRUE(HasStringValueEqualTo(result.get(), "on_root", "on_root"));
EXPECT_TRUE(HasStringValueEqualTo(result.get(), "on_one", "on_two"));
EXPECT_TRUE(HasStringValueEqualTo(result.get(), "on_two", "on_two2"));
}
TEST(Scope, GetMutableValue) {
TestWithScope setup;
// Make a pretend parse node with proper tracking that we can blame for the
// given value.
InputFile input_file(SourceFile("//foo"));
Token assignment_token(Location(&input_file, 1, 1), Token::STRING,
"\"hello\"");
LiteralNode assignment;
assignment.set_value(assignment_token);
const char kOnConst[] = "on_const";
const char kOnMutable1[] = "on_mutable1";
const char kOnMutable2[] = "on_mutable2";
Value value(&assignment, "hello");
// Create a root scope with one value.
Scope root_scope(setup.settings());
root_scope.SetValue(kOnConst, value, &assignment);
// Create a first nested scope with a different value.
const Scope* const_root_scope = &root_scope;
Scope mutable_scope1(const_root_scope);
mutable_scope1.SetValue(kOnMutable1, value, &assignment);
// Create a second nested scope with a different value.
Scope mutable_scope2(&mutable_scope1);
mutable_scope2.SetValue(kOnMutable2, value, &assignment);
// Check getting root scope values.
EXPECT_TRUE(mutable_scope2.GetValue(kOnConst, true));
EXPECT_FALSE(mutable_scope2.GetMutableValue(kOnConst, true));
// Test reading a value from scope 1.
Value* mutable1_result = mutable_scope2.GetMutableValue(kOnMutable1, false);
ASSERT_TRUE(mutable1_result);
EXPECT_TRUE(*mutable1_result == value);
// Make sure CheckForUnusedVars works on scope1 (we didn't mark the value as
// used in the previous step).
Err err;
EXPECT_FALSE(mutable_scope1.CheckForUnusedVars(&err));
mutable1_result = mutable_scope2.GetMutableValue(kOnMutable1, true);
EXPECT_TRUE(mutable1_result);
err = Err();
EXPECT_TRUE(mutable_scope1.CheckForUnusedVars(&err));
// Test reading a value from scope 2.
Value* mutable2_result = mutable_scope2.GetMutableValue(kOnMutable2, true);
ASSERT_TRUE(mutable2_result);
EXPECT_TRUE(*mutable2_result == value);
}
TEST(Scope, RemovePrivateIdentifiers) {
TestWithScope setup;
setup.scope()->SetValue("a", Value(NULL, true), NULL);
setup.scope()->SetValue("_b", Value(NULL, true), NULL);
setup.scope()->RemovePrivateIdentifiers();
EXPECT_TRUE(setup.scope()->GetValue("a"));
EXPECT_FALSE(setup.scope()->GetValue("_b"));
}
|
