summaryrefslogtreecommitdiffstats
path: root/tools/metrics/histograms/PRESUBMIT.py
blob: 677ae5a93ffa378c851e87b076f5365236ba31c7 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
# Copyright 2013 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

"""
See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
for more details on the presubmit API built into depot_tools.
"""


def CheckChange(input_api, output_api):
  """Checks that histograms.xml is pretty-printed and well-formatted."""
  for f in input_api.AffectedTextFiles():
    p = f.AbsoluteLocalPath()
    if (input_api.basename(p) == 'histograms.xml'
        and input_api.os_path.dirname(p) == input_api.PresubmitLocalPath()):
      cwd = input_api.os_path.dirname(p)
      exit_code = input_api.subprocess.call(
          ['python', 'pretty_print.py', '--presubmit'], cwd=cwd)
      if exit_code != 0:
        return [output_api.PresubmitError(
            'histograms.xml is not formatted correctly; run pretty_print.py '
            'to fix')]

      exit_code = input_api.subprocess.call(
          ['python', 'validate_format.py'], cwd=cwd)
      if exit_code != 0:
        return [output_api.PresubmitError(
            'histograms.xml is not well formatted; run validate_format.py '
            'and fix the reported errors')]
  return []


def CheckChangeOnUpload(input_api, output_api):
  return CheckChange(input_api, output_api)


def CheckChangeOnCommit(input_api, output_api):
  return CheckChange(input_api, output_api)