1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
|
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "ui/views/controls/native/native_view_host.h"
#include "base/basictypes.h"
#include "base/memory/scoped_ptr.h"
#include "ui/aura/window.h"
#include "ui/views/test/views_test_base.h"
#include "ui/views/widget/widget.h"
namespace views {
class NativeViewHostTest : public ViewsTestBase {
public:
NativeViewHostTest() {
}
virtual void SetUp() OVERRIDE {
ViewsTestBase::SetUp();
// Create the top level widget.
toplevel_.reset(new Widget);
Widget::InitParams toplevel_params =
CreateParams(Widget::InitParams::TYPE_WINDOW);
toplevel_params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
toplevel_->Init(toplevel_params);
}
// Create a child widget whose native parent is |native_parent_view|, uses
// |contents_view|, and is attached to |host| which is added as a child to
// |parent_view|.
Widget* CreateChildForHost(gfx::NativeView native_parent_view,
View* parent_view,
View* contents_view,
NativeViewHost* host) {
Widget* child = new Widget;
Widget::InitParams child_params(Widget::InitParams::TYPE_CONTROL);
child_params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
child_params.parent = native_parent_view;
child->Init(child_params);
child->SetContentsView(contents_view);
// Owned by |parent_view|.
parent_view->AddChildView(host);
host->Attach(child->GetNativeView());
return child;
}
Widget* toplevel() {
return toplevel_.get();
}
private:
scoped_ptr<Widget> toplevel_;
DISALLOW_COPY_AND_ASSIGN(NativeViewHostTest);
};
namespace {
// View implementation used by NativeViewHierarchyChanged to count number of
// times NativeViewHierarchyChanged() is invoked.
class NativeViewHierarchyChangedTestView : public View {
public:
NativeViewHierarchyChangedTestView() : notification_count_(0) {
}
void ResetCount() {
notification_count_ = 0;
}
int notification_count() const { return notification_count_; }
// Overriden from View:
virtual void NativeViewHierarchyChanged() OVERRIDE {
++notification_count_;
View::NativeViewHierarchyChanged();
}
private:
int notification_count_;
DISALLOW_COPY_AND_ASSIGN(NativeViewHierarchyChangedTestView);
};
aura::Window* GetNativeParent(aura::Window* window) {
return window->parent();
}
class ViewHierarchyChangedTestHost : public NativeViewHost {
public:
ViewHierarchyChangedTestHost()
: num_parent_changes_(0) {
}
void ResetParentChanges() {
num_parent_changes_ = 0;
}
int num_parent_changes() const {
return num_parent_changes_;
}
// Overriden from NativeViewHost:
virtual void ViewHierarchyChanged(
const ViewHierarchyChangedDetails& details) OVERRIDE {
gfx::NativeView parent_before = native_view() ?
GetNativeParent(native_view()) : NULL;
NativeViewHost::ViewHierarchyChanged(details);
gfx::NativeView parent_after = native_view() ?
GetNativeParent(native_view()) : NULL;
if (parent_before != parent_after)
++num_parent_changes_;
}
private:
int num_parent_changes_;
DISALLOW_COPY_AND_ASSIGN(ViewHierarchyChangedTestHost);
};
} // namespace
// Verifies NativeViewHierarchyChanged is sent.
TEST_F(NativeViewHostTest, NativeViewHierarchyChanged) {
// Create a child widget.
NativeViewHierarchyChangedTestView* test_view =
new NativeViewHierarchyChangedTestView;
NativeViewHost* host = new NativeViewHost;
scoped_ptr<Widget> child(CreateChildForHost(toplevel()->GetNativeView(),
toplevel()->GetRootView(),
test_view,
host));
EXPECT_EQ(0, test_view->notification_count());
test_view->ResetCount();
// Detaching should send a NativeViewHierarchyChanged() notification and
// change the parent.
host->Detach();
EXPECT_EQ(1, test_view->notification_count());
EXPECT_NE(toplevel()->GetNativeView(),
GetNativeParent(child->GetNativeView()));
test_view->ResetCount();
// Attaching should send a NativeViewHierarchyChanged() notification and
// reset the parent.
host->Attach(child->GetNativeView());
EXPECT_EQ(1, test_view->notification_count());
EXPECT_EQ(toplevel()->GetNativeView(),
GetNativeParent(child->GetNativeView()));
}
// Verifies ViewHierarchyChanged handles NativeViewHost remove, add and move
// (reparent) operations with correct parent changes.
// This exercises the non-recursive code paths in
// View::PropagateRemoveNotifications() and View::PropagateAddNotifications().
TEST_F(NativeViewHostTest, ViewHierarchyChangedForHost) {
// Original tree:
// toplevel
// +-- host0 (NativeViewHost)
// +-- child0 (Widget, attached to host0)
// +-- test_host (ViewHierarchyChangedTestHost)
// +-- test_child (Widget, attached to test_host)
// +-- host1 (NativeViewHost)
// +-- child1 (Widget, attached to host1)
// Add two children widgets attached to a NativeViewHost, and a test
// grandchild as child widget of host0.
NativeViewHost* host0 = new NativeViewHost;
scoped_ptr<Widget> child0(CreateChildForHost(toplevel()->GetNativeView(),
toplevel()->GetRootView(),
new View,
host0));
NativeViewHost* host1 = new NativeViewHost;
scoped_ptr<Widget> child1(CreateChildForHost(toplevel()->GetNativeView(),
toplevel()->GetRootView(),
new View,
host1));
ViewHierarchyChangedTestHost* test_host = new ViewHierarchyChangedTestHost;
scoped_ptr<Widget> test_child(CreateChildForHost(host0->native_view(),
host0,
new View,
test_host));
// Remove test_host from host0, expect 1 parent change.
test_host->ResetParentChanges();
EXPECT_EQ(0, test_host->num_parent_changes());
host0->RemoveChildView(test_host);
EXPECT_EQ(1, test_host->num_parent_changes());
// Add test_host back to host0, expect 1 parent change.
test_host->ResetParentChanges();
EXPECT_EQ(0, test_host->num_parent_changes());
host0->AddChildView(test_host);
EXPECT_EQ(1, test_host->num_parent_changes());
// Reparent test_host to host1, expect no parent change because the old and
// new parents, host0 and host1, belong to the same toplevel widget.
test_host->ResetParentChanges();
EXPECT_EQ(0, test_host->num_parent_changes());
host1->AddChildView(test_host);
EXPECT_EQ(0, test_host->num_parent_changes());
// Reparent test_host to contents view of child0, expect 2 parent changes
// because the old parent belongs to the toplevel widget whereas the new
// parent belongs to the child0.
test_host->ResetParentChanges();
EXPECT_EQ(0, test_host->num_parent_changes());
child0->GetContentsView()->AddChildView(test_host);
EXPECT_EQ(2, test_host->num_parent_changes());
}
// Verifies ViewHierarchyChanged handles NativeViewHost's parent remove, add and
// move (reparent) operations with correct parent changes.
// This exercises the recursive code paths in
// View::PropagateRemoveNotifications() and View::PropagateAddNotifications().
TEST_F(NativeViewHostTest, ViewHierarchyChangedForHostParent) {
// Original tree:
// toplevel
// +-- view0 (View)
// +-- host0 (NativeViewHierarchyChangedTestHost)
// +-- child0 (Widget, attached to host0)
// +-- view1 (View)
// +-- host1 (NativeViewHierarchyChangedTestHost)
// +-- child1 (Widget, attached to host1)
// Add two children views.
View* view0 = new View;
toplevel()->GetRootView()->AddChildView(view0);
View* view1 = new View;
toplevel()->GetRootView()->AddChildView(view1);
// To each child view, add a child widget.
ViewHierarchyChangedTestHost* host0 = new ViewHierarchyChangedTestHost;
scoped_ptr<Widget> child0(CreateChildForHost(toplevel()->GetNativeView(),
view0,
new View,
host0));
ViewHierarchyChangedTestHost* host1 = new ViewHierarchyChangedTestHost;
scoped_ptr<Widget> child1(CreateChildForHost(toplevel()->GetNativeView(),
view1,
new View,
host1));
// Remove view0 from top level, expect 1 parent change.
host0->ResetParentChanges();
EXPECT_EQ(0, host0->num_parent_changes());
toplevel()->GetRootView()->RemoveChildView(view0);
EXPECT_EQ(1, host0->num_parent_changes());
// Add view0 back to top level, expect 1 parent change.
host0->ResetParentChanges();
EXPECT_EQ(0, host0->num_parent_changes());
toplevel()->GetRootView()->AddChildView(view0);
EXPECT_EQ(1, host0->num_parent_changes());
// Reparent view0 to view1, expect no parent change because the old and new
// parents of both view0 and view1 belong to the same toplevel widget.
host0->ResetParentChanges();
host1->ResetParentChanges();
EXPECT_EQ(0, host0->num_parent_changes());
EXPECT_EQ(0, host1->num_parent_changes());
view1->AddChildView(view0);
EXPECT_EQ(0, host0->num_parent_changes());
EXPECT_EQ(0, host1->num_parent_changes());
// Restore original view hierarchy by adding back view0 to top level.
// Then, reparent view1 to contents view of child0.
// Expect 2 parent changes because the old parent belongs to the toplevel
// widget whereas the new parent belongs to the 1st child widget.
toplevel()->GetRootView()->AddChildView(view0);
host0->ResetParentChanges();
host1->ResetParentChanges();
EXPECT_EQ(0, host0->num_parent_changes());
EXPECT_EQ(0, host1->num_parent_changes());
child0->GetContentsView()->AddChildView(view1);
EXPECT_EQ(0, host0->num_parent_changes());
EXPECT_EQ(2, host1->num_parent_changes());
}
} // namespace views
|