Fix bug in URLFetcherProxy

The url() function only returns a valid URL once a response has been
received as it represents the final URL that was connected to after
any redirects. It's therefore not correct to use it in the DoStart
method of URLFetcherProxy. Instead, cache the url that gets passed
into the URLFetcherProxy and use that.

Change-Id: I509f5bc490362b45c5814fc7b1bc57168903b17b

1 files changed, 3 insertions, 2 deletions

diff --git a/android/autofill/url_fetcher_proxy.h b/android/autofill/url_fetcher_proxy.h
index c2bc77e..415b730 100644
--- a/android/autofill/url_fetcher_proxy.h
+++ b/android/autofill/url_fetcher_proxy.h
@@ -74,7 +74,8 @@ public:
                   URLFetcher::Delegate* d)
       : URLFetcher(url /*unused*/, URLFetcher::POST /*unused*/, d),
         request_type_(request_type),
-        retry_(true)
+        retry_(true),
+        url_(url)
   {
   }
 
@@ -129,7 +130,7 @@ public:
 private:
   void DoStart()
   {
-    real_fetcher_.reset(new URLFetcher(url(), request_type_, this));
+    real_fetcher_.reset(new URLFetcher(url_, request_type_, this));
     real_fetcher_->set_automatically_retry_on_5xx(retry_);
     // We expect set_upload_data() to have been called on this object.
     real_fetcher_->set_upload_data(upload_content_type_, upload_content_);