summaryrefslogtreecommitdiffstats
path: root/base
diff options
context:
space:
mode:
authorKristian Monsen <kristianm@google.com>2011-11-22 13:35:45 +0000
committerKristian Monsen <kristianm@google.com>2011-11-22 13:35:45 +0000
commit940e47a8a93a8720ca55c0966689f4cdd4bf5b4e (patch)
treeb40b20185de12cf0f660cd8b37be209e5112f39c /base
parent754777ec24185272ad267a324907d384e274b648 (diff)
downloadexternal_chromium-940e47a8a93a8720ca55c0966689f4cdd4bf5b4e.zip
external_chromium-940e47a8a93a8720ca55c0966689f4cdd4bf5b4e.tar.gz
external_chromium-940e47a8a93a8720ca55c0966689f4cdd4bf5b4e.tar.bz2
Fix for bug 5152544, remove warning from chromium port
This is a cherry-pick of http://codereview.chromium.org/8354008/ No more warnings after this is merged. Change-Id: I788d28545e7961d0145a3f1273ce4302f8c432ad
Diffstat (limited to 'base')
-rw-r--r--base/string_split.cc10
1 files changed, 8 insertions, 2 deletions
diff --git a/base/string_split.cc b/base/string_split.cc
index 44b5d06..9af0bbc 100644
--- a/base/string_split.cc
+++ b/base/string_split.cc
@@ -53,7 +53,10 @@ void SplitString(const string16& str,
void SplitString(const std::string& str,
char c,
std::vector<std::string>* r) {
- DCHECK(c >= 0 && c < 0x7F);
+#if CHAR_MIN < 0
+ DCHECK(c >= 0);
+#endif
+ DCHECK(c < 0x7F);
SplitStringT(str, c, true, r);
}
@@ -164,7 +167,10 @@ void SplitStringDontTrim(const std::string& str,
char c,
std::vector<std::string>* r) {
DCHECK(IsStringUTF8(str));
- DCHECK(c >= 0 && c < 0x7F);
+#if CHAR_MIN < 0
+ DCHECK(c >= 0);
+#endif
+ DCHECK(c < 0x7F);
SplitStringT(str, c, false, r);
}