diff options
author | Kristian Monsen <kristianm@google.com> | 2011-06-28 21:49:31 +0100 |
---|---|---|
committer | Kristian Monsen <kristianm@google.com> | 2011-07-08 17:55:00 +0100 |
commit | ddb351dbec246cf1fab5ec20d2d5520909041de1 (patch) | |
tree | 158e3fb57bdcac07c7f1e767fde3c70687c9fbb1 /chrome/browser/visitedlink | |
parent | 6b92e04f5f151c896e3088e86f70db7081009308 (diff) | |
download | external_chromium-ddb351dbec246cf1fab5ec20d2d5520909041de1.zip external_chromium-ddb351dbec246cf1fab5ec20d2d5520909041de1.tar.gz external_chromium-ddb351dbec246cf1fab5ec20d2d5520909041de1.tar.bz2 |
Merge Chromium at r12.0.742.93: Initial merge by git
Change-Id: Ic5ee2fec31358bbee305f7e915442377bfa6cda6
Diffstat (limited to 'chrome/browser/visitedlink')
-rw-r--r-- | chrome/browser/visitedlink/visitedlink_master.cc | 2 | ||||
-rw-r--r-- | chrome/browser/visitedlink/visitedlink_master.h | 4 | ||||
-rw-r--r-- | chrome/browser/visitedlink/visitedlink_unittest.cc | 12 |
3 files changed, 8 insertions, 10 deletions
diff --git a/chrome/browser/visitedlink/visitedlink_master.cc b/chrome/browser/visitedlink/visitedlink_master.cc index ad4ad45..eafaf48 100644 --- a/chrome/browser/visitedlink/visitedlink_master.cc +++ b/chrome/browser/visitedlink/visitedlink_master.cc @@ -261,7 +261,7 @@ bool VisitedLinkMaster::Init() { } VisitedLinkMaster::Hash VisitedLinkMaster::TryToAddURL(const GURL& url) { - // Extra check that we are not off the record. This should not happen. + // Extra check that we are not incognito. This should not happen. if (profile_ && profile_->IsOffTheRecord()) { NOTREACHED(); return null_hash_; diff --git a/chrome/browser/visitedlink/visitedlink_master.h b/chrome/browser/visitedlink/visitedlink_master.h index 93e2aef..87de153 100644 --- a/chrome/browser/visitedlink/visitedlink_master.h +++ b/chrome/browser/visitedlink/visitedlink_master.h @@ -1,4 +1,4 @@ -// Copyright (c) 2010 The Chromium Authors. All rights reserved. +// Copyright (c) 2011 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -14,7 +14,7 @@ #include "base/file_path.h" #include "base/gtest_prod_util.h" -#include "base/ref_counted.h" +#include "base/memory/ref_counted.h" #include "base/shared_memory.h" #include "chrome/browser/history/history.h" #include "chrome/common/visitedlink_common.h" diff --git a/chrome/browser/visitedlink/visitedlink_unittest.cc b/chrome/browser/visitedlink/visitedlink_unittest.cc index dd7aa83..66834ea 100644 --- a/chrome/browser/visitedlink/visitedlink_unittest.cc +++ b/chrome/browser/visitedlink/visitedlink_unittest.cc @@ -12,13 +12,13 @@ #include "base/process_util.h" #include "base/shared_memory.h" #include "base/string_util.h" -#include "chrome/browser/renderer_host/browser_render_process_host.h" #include "chrome/browser/visitedlink/visitedlink_master.h" #include "chrome/browser/visitedlink/visitedlink_event_listener.h" #include "chrome/common/render_messages.h" #include "chrome/renderer/visitedlink_slave.h" #include "chrome/test/testing_profile.h" #include "content/browser/browser_thread.h" +#include "content/browser/renderer_host/browser_render_process_host.h" #include "content/browser/renderer_host/test_render_view_host.h" #include "googleurl/src/gurl.h" #include "testing/gtest/include/gtest/gtest.h" @@ -51,7 +51,7 @@ class TrackingVisitedLinkEventListener : public VisitedLinkMaster::Listener { i < g_slaves.size(); i++) { base::SharedMemoryHandle new_handle = base::SharedMemory::NULLHandle(); table->ShareToProcess(base::GetCurrentProcessHandle(), &new_handle); - g_slaves[i]->Init(new_handle); + g_slaves[i]->OnUpdateVisitedLinks(new_handle); } } } @@ -134,8 +134,7 @@ class VisitedLinkTest : public testing::Test { base::SharedMemoryHandle new_handle = base::SharedMemory::NULLHandle(); master_->shared_memory()->ShareToProcess( base::GetCurrentProcessHandle(), &new_handle); - bool success = slave.Init(new_handle); - ASSERT_TRUE(success); + slave.OnUpdateVisitedLinks(new_handle); g_slaves.push_back(&slave); bool found; @@ -276,7 +275,7 @@ TEST_F(VisitedLinkTest, DeleteAll) { base::SharedMemoryHandle new_handle = base::SharedMemory::NULLHandle(); master_->shared_memory()->ShareToProcess( base::GetCurrentProcessHandle(), &new_handle); - ASSERT_TRUE(slave.Init(new_handle)); + slave.OnUpdateVisitedLinks(new_handle); g_slaves.push_back(&slave); // Add the test URLs. @@ -325,8 +324,7 @@ TEST_F(VisitedLinkTest, Resizing) { base::SharedMemoryHandle new_handle = base::SharedMemory::NULLHandle(); master_->shared_memory()->ShareToProcess( base::GetCurrentProcessHandle(), &new_handle); - bool success = slave.Init(new_handle); - ASSERT_TRUE(success); + slave.OnUpdateVisitedLinks(new_handle); g_slaves.push_back(&slave); int32 used_count = master_->GetUsedCount(); |