diff options
Diffstat (limited to 'chrome/browser/ssl')
-rw-r--r-- | chrome/browser/ssl/ssl_add_cert_handler_mac.mm | 2 | ||||
-rw-r--r-- | chrome/browser/ssl/ssl_blocking_page.cc | 7 | ||||
-rw-r--r-- | chrome/browser/ssl/ssl_browser_tests.cc | 15 | ||||
-rw-r--r-- | chrome/browser/ssl/ssl_error_info.cc | 2 | ||||
-rw-r--r-- | chrome/browser/ssl/ssl_manager.cc | 4 | ||||
-rw-r--r-- | chrome/browser/ssl/ssl_policy.cc | 3 |
6 files changed, 9 insertions, 24 deletions
diff --git a/chrome/browser/ssl/ssl_add_cert_handler_mac.mm b/chrome/browser/ssl/ssl_add_cert_handler_mac.mm index 68b9418..48b9859 100644 --- a/chrome/browser/ssl/ssl_add_cert_handler_mac.mm +++ b/chrome/browser/ssl/ssl_add_cert_handler_mac.mm @@ -7,7 +7,6 @@ #include <SecurityInterface/SFCertificatePanel.h> #include <SecurityInterface/SFCertificateView.h> -#include "app/l10n_util_mac.h" #include "base/logging.h" #include "base/scoped_nsobject.h" #include "chrome/common/logging_chrome.h" @@ -16,6 +15,7 @@ #include "chrome/browser/ui/browser_window.h" #include "grit/generated_resources.h" #include "net/base/x509_certificate.h" +#include "ui/base/l10n/l10n_util_mac.h" @interface SSLAddCertHandlerCocoa : NSObject { diff --git a/chrome/browser/ssl/ssl_blocking_page.cc b/chrome/browser/ssl/ssl_blocking_page.cc index ebec519..8d3b315 100644 --- a/chrome/browser/ssl/ssl_blocking_page.cc +++ b/chrome/browser/ssl/ssl_blocking_page.cc @@ -4,8 +4,6 @@ #include "chrome/browser/ssl/ssl_blocking_page.h" -#include "app/l10n_util.h" -#include "app/resource_bundle.h" #include "base/i18n/rtl.h" #include "base/metrics/histogram.h" #include "base/string_piece.h" @@ -13,7 +11,6 @@ #include "base/values.h" #include "chrome/browser/cert_store.h" #include "chrome/browser/dom_operation_notification_details.h" -#include "chrome/browser/prefs/pref_service.h" #include "chrome/browser/renderer_host/render_process_host.h" #include "chrome/browser/renderer_host/render_view_host.h" #include "chrome/browser/ssl/ssl_cert_error_handler.h" @@ -21,12 +18,12 @@ #include "chrome/browser/tab_contents/navigation_controller.h" #include "chrome/browser/tab_contents/navigation_entry.h" #include "chrome/browser/tab_contents/tab_contents.h" -#include "chrome/browser/ui/browser.h" #include "chrome/common/jstemplate_builder.h" #include "chrome/common/notification_service.h" -#include "chrome/common/pref_names.h" #include "grit/browser_resources.h" #include "grit/generated_resources.h" +#include "ui/base/l10n/l10n_util.h" +#include "ui/base/resource/resource_bundle.h" namespace { diff --git a/chrome/browser/ssl/ssl_browser_tests.cc b/chrome/browser/ssl/ssl_browser_tests.cc index 0e6b44a..1a8dded 100644 --- a/chrome/browser/ssl/ssl_browser_tests.cc +++ b/chrome/browser/ssl/ssl_browser_tests.cc @@ -4,7 +4,6 @@ #include "base/time.h" #include "chrome/app/chrome_command_ids.h" -#include "chrome/browser/prefs/pref_service.h" #include "chrome/browser/tab_contents/interstitial_page.h" #include "chrome/browser/tab_contents/navigation_entry.h" #include "chrome/browser/tab_contents/tab_contents.h" @@ -12,7 +11,6 @@ #include "chrome/browser/ui/browser.h" #include "chrome/browser/ui/browser_navigator.h" #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" -#include "chrome/common/pref_names.h" #include "chrome/test/in_process_browser_test.h" #include "chrome/test/ui_test_utils.h" #include "net/base/cert_status_flags.h" @@ -660,16 +658,10 @@ IN_PROC_BROWSER_TEST_F(SSLUITest, TestRunsCachedInsecureContent) { CheckAuthenticationBrokenState(tab, 0, true, false); } -#if defined(OS_WIN) -// See http://crbug.com/47170 -#define MAYBE_TestCNInvalidStickiness FLAKY_TestCNInvalidStickiness -#else -#define MAYBE_TestCNInvalidStickiness TestCNInvalidStickiness -#endif - // This test ensures the CN invalid status does not 'stick' to a certificate // (see bug #1044942) and that it depends on the host-name. -IN_PROC_BROWSER_TEST_F(SSLUITest, MAYBE_TestCNInvalidStickiness) { +// Disabled, see http://crbug.com/68448 and http://crbug.com/49377. +IN_PROC_BROWSER_TEST_F(SSLUITest, DISABLED_TestCNInvalidStickiness) { ASSERT_TRUE(https_server_.Start()); ASSERT_TRUE(https_server_mismatched_.Start()); @@ -810,7 +802,8 @@ IN_PROC_BROWSER_TEST_F(SSLUITest, FLAKY_TestRedirectGoodToBadHTTPS) { } // Visit a page over http that is a redirect to a page with good HTTPS. -IN_PROC_BROWSER_TEST_F(SSLUITest, TestRedirectHTTPToGoodHTTPS) { +// Disabled, http://crbug.com/70216. +IN_PROC_BROWSER_TEST_F(SSLUITest, DISABLED_TestRedirectHTTPToGoodHTTPS) { ASSERT_TRUE(test_server()->Start()); ASSERT_TRUE(https_server_.Start()); diff --git a/chrome/browser/ssl/ssl_error_info.cc b/chrome/browser/ssl/ssl_error_info.cc index 6769d88..ee3df60 100644 --- a/chrome/browser/ssl/ssl_error_info.cc +++ b/chrome/browser/ssl/ssl_error_info.cc @@ -4,7 +4,6 @@ #include "chrome/browser/ssl/ssl_error_info.h" -#include "app/l10n_util.h" #include "base/utf_string_conversions.h" #include "chrome/browser/cert_store.h" #include "chrome/common/time_format.h" @@ -14,6 +13,7 @@ #include "net/base/cert_status_flags.h" #include "net/base/net_errors.h" #include "net/base/ssl_info.h" +#include "ui/base/l10n/l10n_util.h" SSLErrorInfo::SSLErrorInfo(const string16& title, const string16& details, diff --git a/chrome/browser/ssl/ssl_manager.cc b/chrome/browser/ssl/ssl_manager.cc index 7c9cd8f..7d662c0 100644 --- a/chrome/browser/ssl/ssl_manager.cc +++ b/chrome/browser/ssl/ssl_manager.cc @@ -4,12 +4,10 @@ #include "chrome/browser/ssl/ssl_manager.h" -#include "app/l10n_util.h" #include "base/utf_string_conversions.h" #include "chrome/browser/browser_thread.h" #include "chrome/browser/load_from_memory_cache_details.h" #include "chrome/browser/net/url_request_tracking.h" -#include "chrome/browser/prefs/pref_service.h" #include "chrome/browser/renderer_host/resource_request_details.h" #include "chrome/browser/renderer_host/resource_dispatcher_host.h" #include "chrome/browser/renderer_host/resource_dispatcher_host_request_info.h" @@ -21,9 +19,9 @@ #include "chrome/browser/tab_contents/provisional_load_details.h" #include "chrome/browser/tab_contents/tab_contents.h" #include "chrome/common/notification_service.h" -#include "chrome/common/pref_names.h" #include "grit/generated_resources.h" #include "net/base/cert_status_flags.h" +#include "ui/base/l10n/l10n_util.h" // static void SSLManager::OnSSLCertificateError(ResourceDispatcherHost* rdh, diff --git a/chrome/browser/ssl/ssl_policy.cc b/chrome/browser/ssl/ssl_policy.cc index 6205722..afe861b 100644 --- a/chrome/browser/ssl/ssl_policy.cc +++ b/chrome/browser/ssl/ssl_policy.cc @@ -9,7 +9,6 @@ #include "base/singleton.h" #include "base/string_piece.h" #include "base/string_util.h" -#include "chrome/browser/prefs/pref_service.h" #include "chrome/browser/renderer_host/render_process_host.h" #include "chrome/browser/renderer_host/render_view_host.h" #include "chrome/browser/renderer_host/site_instance.h" @@ -18,9 +17,7 @@ #include "chrome/browser/ssl/ssl_request_info.h" #include "chrome/browser/tab_contents/navigation_entry.h" #include "chrome/browser/tab_contents/tab_contents.h" -#include "chrome/common/chrome_switches.h" #include "chrome/common/jstemplate_builder.h" -#include "chrome/common/pref_names.h" #include "chrome/common/time_format.h" #include "chrome/common/url_constants.h" #include "grit/browser_resources.h" |