diff options
Diffstat (limited to 'webkit/glue/password_form_dom_manager.cc')
| -rw-r--r-- | webkit/glue/password_form_dom_manager.cc | 16 |
1 files changed, 9 insertions, 7 deletions
diff --git a/webkit/glue/password_form_dom_manager.cc b/webkit/glue/password_form_dom_manager.cc index adbb8dd..97f3eef 100644 --- a/webkit/glue/password_form_dom_manager.cc +++ b/webkit/glue/password_form_dom_manager.cc @@ -40,23 +40,25 @@ void PasswordFormDomManager::InitFillData( // Fill basic form data. result->basic_data.origin = form_on_page.origin; result->basic_data.action = form_on_page.action; - // TODO(jhawkins): Is it right to use an empty string for the form control - // type? I don't think the password autocomplete really cares, but we should - // correct this anyway. - // TODO(dhollowa): Similarly, |size| ideally should be set from the form - // control itself. But it is currently unused. + // Three of the parameters below are set to default values because they are + // currently not used by the password autocomplete code: + // * The form control type is initialized to an empty string. + // * The field |max_length| is initialized to 0. + // * The field autofilled state is initialized to false. result->basic_data.fields.push_back( FormField(string16(), form_on_page.username_element, preferred_match->username_value, string16(), - 0)); + 0, + false)); result->basic_data.fields.push_back( FormField(string16(), form_on_page.password_element, preferred_match->password_value, string16(), - 0)); + 0, + false)); result->wait_for_username = wait_for_username_before_autofill; // Copy additional username/value pairs. |