1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
|
// Copyright (c) 2010 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/chromeos/wm_overview_controller.h"
#include <algorithm>
#include <vector>
#include "base/linked_ptr.h"
#include "chrome/browser/browser.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/chromeos/wm_ipc.h"
#include "chrome/browser/chromeos/wm_overview_fav_icon.h"
#include "chrome/browser/chromeos/wm_overview_snapshot.h"
#include "chrome/browser/chromeos/wm_overview_title.h"
#include "chrome/browser/renderer_host/render_view_host.h"
#include "chrome/browser/renderer_host/render_widget_host.h"
#include "chrome/browser/renderer_host/render_widget_host_view.h"
#include "chrome/browser/tab_contents/tab_contents.h"
#include "chrome/browser/tab_contents/tab_contents_view.h"
#include "chrome/browser/tab_contents/thumbnail_generator.h"
#include "chrome/browser/tabs/tab_strip_model.h"
#include "chrome/browser/views/frame/browser_view.h"
#include "chrome/common/notification_service.h"
#include "views/widget/root_view.h"
#include "views/widget/widget_gtk.h"
#include "views/window/window.h"
using std::vector;
#if !defined(OS_CHROMEOS)
#error This file is only meant to be compiled for ChromeOS
#endif
namespace chromeos {
// The time that the delay timer waits before starting the
// configuration pass.
//
// NOTE(gspencer): Yes, this is a pretty short delay, and I could
// remove it and just use the configure timer. The reason I'm not
// doing that is that I have a hunch that we'll be needing to tune
// things further, and this will be one of the knobs.
static const int kDelayTimeMs = 10;
// The time between setting snapshots during the configuration pass,
// so that the CPU has a chance to do something else (to keep overview
// mode responsive).
static const int kConfigureTimeMs = 10;
// This is the size of the web page when we lay it out for a snapshot.
static const int kSnapshotWebPageWidth = 1024;
static const int kSnapshotWebPageHeight = 1280;
static const double kSnapshotWebPageRatio =
static_cast<double>(kSnapshotWebPageWidth) / kSnapshotWebPageHeight;
// This is the maximum percentage of the original browser client area
// that a snapshot can take up.
static const double kSnapshotMaxSizeRatio = 0.77;
// This is the height of the title in pixels.
static const int kTitleHeight = 32;
// The number of additional padding pixels to remove from the title width.
static const int kFavIconPadding = 5;
class BrowserListener : public TabStripModelObserver {
public:
BrowserListener(Browser* browser, WmOverviewController* parent);
~BrowserListener();
// Begin TabStripModelObserver methods
virtual void TabInsertedAt(TabContents* contents,
int index,
bool foreground);
virtual void TabClosingAt(TabStripModel* tab_strip_model,
TabContents* contents,
int index) {}
virtual void TabDetachedAt(TabContents* contents, int index);
virtual void TabMoved(TabContents* contents,
int from_index,
int to_index);
virtual void TabChangedAt(TabContents* contents, int index,
TabStripModelObserver::TabChangeType change_type);
virtual void TabStripEmpty();
virtual void TabDeselectedAt(TabContents* contents, int index) {}
virtual void TabSelectedAt(TabContents* old_contents,
TabContents* new_contents,
int index,
bool user_gesture);
// End TabStripModelObserver methods
// Returns the number of tabs in this child.
int count() const { return browser_->tabstrip_model()->count(); }
// Returns the browser that this child gets its data from.
Browser* browser() const { return browser_; }
// Removes all the snapshots and re-populates them from the browser.
void RecreateSnapshots();
// Mark the given snapshot as dirty, and start the delay timer.
void ReloadSnapshot(int index);
// Updates the selected index and tab count on the toplevel window.
void UpdateSelectedIndex(int index);
// Finds the first cell with no snapshot and invokes ConfigureCell
// for it. Returns false if there are no more cells to configure on
// this listener.
bool ConfigureNextUnconfiguredSnapshot();
// Saves the currently selected tab.
void SaveCurrentTab() { original_selected_tab_ = browser_->selected_index(); }
// Reverts the selected browser tab to the tab that was selected
// when This BrowserListener was created, or the last time
// SaveCurrentTab was called.
void RestoreOriginalSelectedTab();
// Selects the tab at the given index.
void SelectTab(int index, uint32 timestamp);
// Shows any snapshots that are not visible.
void ShowSnapshots();
// Returns the tab contents from the tab model for this child at index.
TabContents* GetTabContentsAt(int index) const {
return browser_->tabstrip_model()->GetTabContentsAt(index);
}
private:
// Calculate the size of a cell based on the browser window's size.
gfx::Size CalculateCellSize();
// Configures a cell from the tab contents.
void ConfigureCell(WmOverviewSnapshot* cell, TabContents* contents);
// Configures a cell from the model.
void ConfigureCell(WmOverviewSnapshot* cell, int index) {
ConfigureCell(cell, GetTabContentsAt(index));
}
// Inserts a new snapshot, initialized from the model, at the given
// index, and renumbers any following snapshots.
void InsertSnapshot(int index);
// Removes the snapshot at index.
void ClearSnapshot(int index);
// Renumbers the index atom in the snapshots starting at the given
// index.
void RenumberSnapshots(int start_index);
Browser* browser_; // Not owned
WmOverviewController* controller_; // Not owned
// Widgets containing snapshot images for this browser. Note that
// these are all subclasses of WidgetGtk, and they are all added to
// parents, so they will be deleted by the parents when they are
// closed.
struct SnapshotNode {
WmOverviewSnapshot* snapshot; // Not owned
WmOverviewTitle* title; // Not owned
WmOverviewFavIcon* fav_icon; // Not owned
};
typedef std::vector<SnapshotNode> SnapshotVector;
SnapshotVector snapshots_;
// True if the snapshots are showing.
bool snapshots_showing_;
// Non-zero if we are currently setting the tab from within SelectTab.
// This is used to make sure we use the right timestamp when sending
// property changes that originated from the window manager.
uint32 select_tab_timestamp_;
// The tab selected the last time SaveCurrentTab is called.
int original_selected_tab_;
DISALLOW_COPY_AND_ASSIGN(BrowserListener);
};
BrowserListener::BrowserListener(Browser* browser,
WmOverviewController* controller)
: browser_(browser),
controller_(controller),
snapshots_showing_(false),
select_tab_timestamp_(0),
original_selected_tab_(-1) {
CHECK(browser_);
CHECK(controller_);
browser_->tabstrip_model()->AddObserver(this);
// This browser didn't already exist, and so we haven't been
// watching it for tab insertions, so we need to create the
// snapshots associated with it.
RecreateSnapshots();
}
BrowserListener::~BrowserListener() {
browser_->tabstrip_model()->RemoveObserver(this);
}
void BrowserListener::TabInsertedAt(TabContents* contents,
int index,
bool foreground) {
InsertSnapshot(index);
RenumberSnapshots(index);
UpdateSelectedIndex(browser_->selected_index());
}
void BrowserListener::TabDetachedAt(TabContents* contents, int index) {
ClearSnapshot(index);
UpdateSelectedIndex(browser_->selected_index());
RenumberSnapshots(index);
}
void BrowserListener::TabMoved(TabContents* contents,
int from_index,
int to_index) {
// Need to reorder tab in the snapshots list, and reset the window
// type atom on the affected snapshots (the one moved, and all the
// ones after it), so that their indices are correct.
SnapshotNode node = snapshots_[from_index];
snapshots_.erase(snapshots_.begin() + from_index);
snapshots_.insert(snapshots_.begin() + to_index, node);
RenumberSnapshots(std::min(to_index, from_index));
UpdateSelectedIndex(browser_->selected_index());
}
void BrowserListener::TabChangedAt(
TabContents* contents,
int index,
TabStripModelObserver::TabChangeType change_type) {
if (change_type != TabStripModelObserver::LOADING_ONLY) {
snapshots_[index].title->SetTitle(contents->GetTitle());
snapshots_[index].title->SetUrl(contents->GetURL());
snapshots_[index].fav_icon->SetFavIcon(contents->GetFavIcon());
if (change_type != TabStripModelObserver::TITLE_NOT_LOADING)
ReloadSnapshot(index);
}
}
void BrowserListener::TabStripEmpty() {
snapshots_.clear();
}
void BrowserListener::TabSelectedAt(TabContents* old_contents,
TabContents* new_contents,
int index,
bool user_gesture) {
UpdateSelectedIndex(index);
}
void BrowserListener::ReloadSnapshot(int index) {
snapshots_[index].snapshot->reload_snapshot();
controller_->StartDelayTimer();
}
void BrowserListener::RecreateSnapshots() {
snapshots_.clear();
for (int i = 0; i < count(); ++i)
InsertSnapshot(i);
RenumberSnapshots(0);
}
void BrowserListener::UpdateSelectedIndex(int index) {
WmIpcWindowType type = WmIpc::instance()->GetWindowType(
GTK_WIDGET(browser_->window()->GetNativeHandle()), NULL);
// Make sure we only operate on toplevel windows.
if (type == WM_IPC_WINDOW_CHROME_TOPLEVEL) {
std::vector<int> params;
params.push_back(browser_->tab_count());
params.push_back(index);
params.push_back(select_tab_timestamp_ ? select_tab_timestamp_ :
gtk_get_current_event_time());
WmIpc::instance()->SetWindowType(
GTK_WIDGET(browser_->window()->GetNativeHandle()),
WM_IPC_WINDOW_CHROME_TOPLEVEL,
¶ms);
}
}
bool BrowserListener::ConfigureNextUnconfiguredSnapshot() {
for (SnapshotVector::size_type i = 0; i < snapshots_.size(); ++i) {
WmOverviewSnapshot* cell = snapshots_[i].snapshot;
if (!cell->configured_snapshot()) {
ConfigureCell(cell, i);
return true;
}
}
return false;
}
void BrowserListener::RestoreOriginalSelectedTab() {
if (original_selected_tab_ >= 0) {
browser_->SelectTabContentsAt(original_selected_tab_, false);
UpdateSelectedIndex(browser_->selected_index());
}
}
void BrowserListener::ShowSnapshots() {
for (SnapshotVector::size_type i = 0; i < snapshots_.size(); ++i) {
const SnapshotNode& node = snapshots_[i];
if (!node.snapshot->IsVisible())
node.snapshot->Show();
if (!snapshots_[i].title->IsVisible())
node.title->Show();
if (!snapshots_[i].fav_icon->IsVisible())
node.fav_icon->Show();
}
}
void BrowserListener::SelectTab(int index, uint32 timestamp) {
uint32 old_value = select_tab_timestamp_;
select_tab_timestamp_ = timestamp;
browser_->SelectTabContentsAt(index, true);
select_tab_timestamp_ = old_value;
}
gfx::Size BrowserListener::CalculateCellSize() {
// Make the page size and the cell size a fixed size for overview
// mode. The cell size is calculated based on the desired maximum
// size on the screen, so it's related to the width and height of
// the browser client area. In this way, when this snapshot gets
// to the window manager, it will already have the correct size,
// and will be scaled by 1.0, meaning that it won't be resampled
// and will not be blurry.
gfx::Rect bounds = static_cast<BrowserView*>(browser_->window())->
GetClientAreaBounds();
const gfx::Size max_size = gfx::Size(
bounds.width() * kSnapshotMaxSizeRatio,
bounds.height() * kSnapshotMaxSizeRatio);
const double max_size_ratio = static_cast<double>(max_size.width()) /
max_size.height();
gfx::Size cell_size;
if (kSnapshotWebPageRatio > max_size_ratio) {
const double scale_factor =
static_cast<double>(max_size.width())/ kSnapshotWebPageWidth;
cell_size = gfx::Size(max_size.width(),
kSnapshotWebPageHeight * scale_factor + 0.5);
} else {
const double scale_factor =
static_cast<double>(max_size.height())/ kSnapshotWebPageHeight;
cell_size = gfx::Size(kSnapshotWebPageWidth * scale_factor + 0.5,
max_size.height());
}
return cell_size;
}
void BrowserListener::ConfigureCell(WmOverviewSnapshot* cell,
TabContents* contents) {
if (contents) {
ThumbnailGenerator* generator =
g_browser_process->GetThumbnailGenerator();
// TODO: Make sure that if the cell gets deleted before the
// callback is called that it sticks around until it gets
// called. (some kind of "in flight" list that uses linked_ptr
// to make sure they don't actually get deleted?) Also, make
// sure that any request for a thumbnail eventually returns
// (even if it has bogus data), so we don't leak orphaned cells,
// which could happen if a tab is closed while it is being
// rendered.
ThumbnailGenerator::ThumbnailReadyCallback* callback =
NewCallback(cell, &WmOverviewSnapshot::SetImage);
generator->AskForSnapshot(contents->render_view_host(),
false,
callback,
gfx::Size(kSnapshotWebPageWidth,
kSnapshotWebPageHeight),
CalculateCellSize());
} else {
// This happens because the contents haven't been loaded yet.
// Make sure we set the snapshot image to something, otherwise
// configured_snapshot remains false and
// ConfigureNextUnconfiguredSnapshot would get stuck.
cell->SetImage(SkBitmap());
}
}
void BrowserListener::InsertSnapshot(int index) {
SnapshotNode node;
node.snapshot = new WmOverviewSnapshot;
gfx::Size cell_size = CalculateCellSize();
node.snapshot->Init(cell_size, browser_, index);
node.fav_icon = new WmOverviewFavIcon;
node.fav_icon->Init(node.snapshot);
node.fav_icon->SetFavIcon(browser_->GetTabContentsAt(index)->GetFavIcon());
node.title = new WmOverviewTitle;
node.title->Init(gfx::Size(cell_size.width() -
WmOverviewFavIcon::kIconSize - kFavIconPadding,
kTitleHeight), node.snapshot);
node.title->SetTitle(browser_->GetTabContentsAt(index)->GetTitle());
snapshots_.insert(snapshots_.begin() + index, node);
node.snapshot->reload_snapshot();
controller_->StartDelayTimer();
}
// Removes the snapshot at index.
void BrowserListener::ClearSnapshot(int index) {
snapshots_[index].snapshot->CloseNow();
snapshots_[index].title->CloseNow();
snapshots_[index].fav_icon->CloseNow();
snapshots_.erase(snapshots_.begin() + index);
}
void BrowserListener::RenumberSnapshots(int start_index) {
for (SnapshotVector::size_type i = start_index; i < snapshots_.size(); ++i) {
if (snapshots_[i].snapshot->index() != static_cast<int>(i))
snapshots_[i].snapshot->UpdateIndex(browser_, i);
}
}
///////////////////////////////////
// WmOverviewController methods
// static
WmOverviewController* WmOverviewController::instance() {
static WmOverviewController* instance = NULL;
if (!instance) {
instance = Singleton<WmOverviewController>::get();
}
return instance;
}
WmOverviewController::WmOverviewController()
: layout_mode_(ACTIVE_MODE) {
AddAllBrowsers();
if (registrar_.IsEmpty()) {
// Make sure we get notifications for when the tab contents are
// connected, so we know when a new browser has been created.
registrar_.Add(this,
NotificationType::TAB_CONTENTS_CONNECTED,
NotificationService::AllSources());
// Ask for notification when the snapshot source image has changed
// and needs to be refreshed.
registrar_.Add(this,
NotificationType::THUMBNAIL_GENERATOR_SNAPSHOT_CHANGED,
NotificationService::AllSources());
}
BrowserList::AddObserver(this);
WmMessageListener::instance()->AddObserver(this);
}
WmOverviewController::~WmOverviewController() {
WmMessageListener::instance()->RemoveObserver(this);
BrowserList::RemoveObserver(this);
listeners_.clear();
}
void WmOverviewController::Observe(NotificationType type,
const NotificationSource& source,
const NotificationDetails& details) {
switch (type.value) {
// Now that the tab contents are ready, we create the listeners
// and snapshots for any new browsers out there. This actually
// results in us traversing the list of browsers more often than
// necessary (whenever a tab is connected, as opposed to only when
// a new browser is created), but other notifications aren't
// sufficient to know when the first tab of a new browser has its
// dimensions set. The implementation of AddAllBrowsers avoids
// doing anything to already-existing browsers, so it's not a huge
// problem, but still, it would be nice if there were a more
// appropriate (browser-level) notification.
case NotificationType::TAB_CONTENTS_CONNECTED:
AddAllBrowsers();
break;
case NotificationType::THUMBNAIL_GENERATOR_SNAPSHOT_CHANGED: {
// It's OK to do this in active mode too -- nothing will happen
// except invalidation of the snapshot, because the delay timer
// won't start until we're in overview mode.
RenderWidgetHost* renderer = Details<RenderViewHost>(details).ptr();
SnapshotImageChanged(renderer);
break;
}
default:
// Do nothing.
break;
}
}
void WmOverviewController::SnapshotImageChanged(RenderWidgetHost* renderer) {
// Find out which TabContents this renderer is attached to, and then
// invalidate the associated snapshot so it'll update.
BrowserListenerVector::iterator iter = listeners_.begin();
while (iter != listeners_.end()) {
for (int i = 0; i < (*iter)->count(); i++) {
RenderWidgetHostView* view =
(*iter)->GetTabContentsAt(i)->GetRenderWidgetHostView();
if (view && view->GetRenderWidgetHost() == renderer) {
(*iter)->ReloadSnapshot(i);
return;
}
}
++iter;
}
}
void WmOverviewController::OnBrowserRemoved(const Browser* browser) {
for (BrowserListenerVector::iterator i = listeners_.begin();
i != listeners_.end(); ++i) {
if ((*i)->browser() == browser) {
listeners_.erase(i);
return;
}
}
}
BrowserView* GetBrowserViewForGdkWindow(GdkWindow* gdk_window) {
gpointer data = NULL;
gdk_window_get_user_data(gdk_window, &data);
GtkWidget* widget = reinterpret_cast<GtkWidget*>(data);
if (widget) {
GtkWindow* gtk_window = GTK_WINDOW(widget);
return BrowserView::GetBrowserViewForNativeWindow(gtk_window);
} else {
return NULL;
}
}
void WmOverviewController::ProcessWmMessage(const WmIpc::Message& message,
GdkWindow* window) {
switch (message.type()) {
case WM_IPC_MESSAGE_CHROME_NOTIFY_LAYOUT_MODE: {
layout_mode_ = message.param(0) == 0 ? ACTIVE_MODE : OVERVIEW_MODE;
if (layout_mode_ == ACTIVE_MODE || BrowserList::size() == 0) {
Hide(message.param(1) != 0);
} else {
Show();
}
break;
}
case WM_IPC_MESSAGE_CHROME_NOTIFY_TAB_SELECT: {
BrowserView* browser_window = GetBrowserViewForGdkWindow(window);
// Find out which listener this goes to, and send it there.
for (BrowserListenerVector::iterator i = listeners_.begin();
i != listeners_.end(); ++i) {
if ((*i)->browser()->window() == browser_window) {
// param(0): index of the tab to select.
// param(1): timestamp of the event.
(*i)->SelectTab(message.param(0), message.param(1));
break;
}
}
break;
}
default:
break;
}
}
void WmOverviewController::StartDelayTimer() {
// We leave the delay timer running if it already is -- this means
// we're rate limiting the number of times we can reconfigure the
// snapshots. If we were to restart the delay timer, it could
// result in a very long delay until they get configured if tabs
// keep changing.
if (layout_mode_ == OVERVIEW_MODE &&
!delay_timer_.IsRunning() && !configure_timer_.IsRunning()) {
delay_timer_.Start(
base::TimeDelta::FromMilliseconds(kDelayTimeMs), this,
&WmOverviewController::StartConfiguring);
}
}
void WmOverviewController::RestoreTabSelections() {
for (BrowserListenerVector::iterator i = listeners_.begin();
i != listeners_.end(); ++i) {
(*i)->RestoreOriginalSelectedTab();
}
}
void WmOverviewController::SaveTabSelections() {
for (BrowserListenerVector::iterator i = listeners_.begin();
i != listeners_.end(); ++i) {
(*i)->SaveCurrentTab();
}
}
void WmOverviewController::Show() {
SaveTabSelections();
// Reset the timers.
configure_timer_.Stop();
delay_timer_.Stop();
for (BrowserListenerVector::iterator i = listeners_.begin();
i != listeners_.end(); ++i) {
(*i)->ShowSnapshots();
}
StartDelayTimer();
}
void WmOverviewController::Hide(bool cancelled) {
configure_timer_.Stop();
delay_timer_.Stop();
if (cancelled) {
RestoreTabSelections();
}
}
void WmOverviewController::StartConfiguring() {
configure_timer_.Stop();
configure_timer_.Start(
base::TimeDelta::FromMilliseconds(kConfigureTimeMs), this,
&WmOverviewController::ConfigureNextUnconfiguredSnapshot);
}
// Just configure one unconfigured cell. If there aren't any left,
// then stop the timer.
void WmOverviewController::ConfigureNextUnconfiguredSnapshot() {
for (BrowserListenerVector::size_type i = 0; i < listeners_.size(); ++i) {
BrowserListener* listener = listeners_[i].get();
if (listener->ConfigureNextUnconfiguredSnapshot())
return;
}
configure_timer_.Stop();
}
void WmOverviewController::AddAllBrowsers() {
// Make a copy so the old ones aren't deleted yet.
BrowserListenerVector old_listeners;
listeners_.swap(old_listeners);
// Iterator through the browser list, adding all the browsers in the
// new order. If they were in the old list of listeners, just copy
// that linked pointer, instead of making a new listener, so that we
// can avoid lots of spurious destroy/create messages.
BrowserList::const_iterator iterator = BrowserList::begin();
while (iterator != BrowserList::end()) {
// Don't add a browser to the list if that type of browser doesn't
// have snapshots in overview mode.
if ((*iterator)->type() != Browser::TYPE_NORMAL &&
(*iterator)->type() != Browser::TYPE_APP &&
(*iterator)->type() != Browser::TYPE_EXTENSION_APP) {
++iterator;
continue;
}
BrowserListenerVector::value_type item(
BrowserListenerVector::value_type(NULL));
for (BrowserListenerVector::iterator old_iter = old_listeners.begin();
old_iter != old_listeners.end(); ++old_iter) {
if ((*old_iter)->browser() == *iterator) {
item = *old_iter;
break;
}
}
// This browser isn't tracked by any listener, so create it.
if (item.get() == NULL) {
item = BrowserListenerVector::value_type(
new BrowserListener(*iterator, this));
}
listeners_.push_back(item);
++iterator;
}
}
} // namespace chromeos
|