1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
|
// Copyright (c) 2010 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#import <Cocoa/Cocoa.h>
#import "base/scoped_nsobject.h"
#include "chrome/app/chrome_dll_resource.h"
#include "chrome/browser/cocoa/browser_test_helper.h"
#import "chrome/browser/cocoa/cocoa_test_helper.h"
#import "chrome/browser/cocoa/gradient_button_cell.h"
#import "chrome/browser/cocoa/toolbar_controller.h"
#import "chrome/browser/cocoa/view_resizer_pong.h"
#include "chrome/browser/prefs/pref_service.h"
#include "chrome/common/pref_names.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
// An NSView that fakes out hitTest:.
@interface HitView : NSView {
id hitTestReturn_;
}
@end
@implementation HitView
- (void)setHitTestReturn:(id)rtn {
hitTestReturn_ = rtn;
}
- (NSView *)hitTest:(NSPoint)aPoint {
return hitTestReturn_;
}
@end
namespace {
class ToolbarControllerTest : public CocoaTest {
public:
// Indexes that match the ordering returned by the private ToolbarController
// |-toolbarViews| method.
enum {
kBackIndex, kForwardIndex, kReloadIndex, kHomeIndex,
kWrenchIndex, kLocationIndex, kBrowserActionContainerViewIndex
};
ToolbarControllerTest() {
Browser* browser = helper_.browser();
CommandUpdater* updater = browser->command_updater();
// The default state for the commands is true, set a couple to false to
// ensure they get picked up correct on initialization
updater->UpdateCommandEnabled(IDC_BACK, false);
updater->UpdateCommandEnabled(IDC_FORWARD, false);
resizeDelegate_.reset([[ViewResizerPong alloc] init]);
bar_.reset(
[[ToolbarController alloc] initWithModel:browser->toolbar_model()
commands:browser->command_updater()
profile:helper_.profile()
browser:browser
resizeDelegate:resizeDelegate_.get()]);
EXPECT_TRUE([bar_ view]);
NSView* parent = [test_window() contentView];
[parent addSubview:[bar_ view]];
}
// Make sure the enabled state of the view is the same as the corresponding
// command in the updater. The views are in the declaration order of outlets.
void CompareState(CommandUpdater* updater, NSArray* views) {
EXPECT_EQ(updater->IsCommandEnabled(IDC_BACK),
[[views objectAtIndex:kBackIndex] isEnabled] ? true : false);
EXPECT_EQ(updater->IsCommandEnabled(IDC_FORWARD),
[[views objectAtIndex:kForwardIndex] isEnabled] ? true : false);
EXPECT_EQ(updater->IsCommandEnabled(IDC_RELOAD),
[[views objectAtIndex:kReloadIndex] isEnabled] ? true : false);
EXPECT_EQ(updater->IsCommandEnabled(IDC_HOME),
[[views objectAtIndex:kHomeIndex] isEnabled] ? true : false);
}
BrowserTestHelper helper_;
scoped_nsobject<ViewResizerPong> resizeDelegate_;
scoped_nsobject<ToolbarController> bar_;
};
TEST_VIEW(ToolbarControllerTest, [bar_ view])
// Test the initial state that everything is sync'd up
TEST_F(ToolbarControllerTest, InitialState) {
CommandUpdater* updater = helper_.browser()->command_updater();
CompareState(updater, [bar_ toolbarViews]);
}
// Make sure a "titlebar only" toolbar with location bar works.
TEST_F(ToolbarControllerTest, TitlebarOnly) {
NSView* view = [bar_ view];
[bar_ setHasToolbar:NO hasLocationBar:YES];
EXPECT_NE(view, [bar_ view]);
// Simulate a popup going fullscreen and back by performing the reparenting
// that happens during fullscreen transitions
NSView* superview = [view superview];
[view removeFromSuperview];
[superview addSubview:view];
[bar_ setHasToolbar:YES hasLocationBar:YES];
EXPECT_EQ(view, [bar_ view]);
// Leave it off to make sure that's fine
[bar_ setHasToolbar:NO hasLocationBar:YES];
}
// Make sure it works in the completely undecorated case.
TEST_F(ToolbarControllerTest, NoLocationBar) {
NSView* view = [bar_ view];
[bar_ setHasToolbar:NO hasLocationBar:NO];
EXPECT_NE(view, [bar_ view]);
EXPECT_TRUE([[bar_ view] isHidden]);
// Simulate a popup going fullscreen and back by performing the reparenting
// that happens during fullscreen transitions
NSView* superview = [view superview];
[view removeFromSuperview];
[superview addSubview:view];
}
// Make some changes to the enabled state of a few of the buttons and ensure
// that we're still in sync.
TEST_F(ToolbarControllerTest, UpdateEnabledState) {
CommandUpdater* updater = helper_.browser()->command_updater();
EXPECT_FALSE(updater->IsCommandEnabled(IDC_BACK));
EXPECT_FALSE(updater->IsCommandEnabled(IDC_FORWARD));
updater->UpdateCommandEnabled(IDC_BACK, true);
updater->UpdateCommandEnabled(IDC_FORWARD, true);
CompareState(updater, [bar_ toolbarViews]);
}
// Focus the location bar and make sure that it's the first responder.
TEST_F(ToolbarControllerTest, FocusLocation) {
NSWindow* window = test_window();
[window makeFirstResponder:[window contentView]];
EXPECT_EQ([window firstResponder], [window contentView]);
[bar_ focusLocationBar:YES];
EXPECT_NE([window firstResponder], [window contentView]);
NSView* locationBar = [[bar_ toolbarViews] objectAtIndex:kLocationIndex];
EXPECT_EQ([window firstResponder], [(id)locationBar currentEditor]);
}
TEST_F(ToolbarControllerTest, LoadingState) {
// In its initial state, the reload button has a tag of
// IDC_RELOAD. When loading, it should be IDC_STOP.
NSButton* reload = [[bar_ toolbarViews] objectAtIndex:kReloadIndex];
EXPECT_EQ([reload tag], IDC_RELOAD);
[bar_ setIsLoading:YES force:YES];
EXPECT_EQ([reload tag], IDC_STOP);
[bar_ setIsLoading:NO force:YES];
EXPECT_EQ([reload tag], IDC_RELOAD);
}
// Check that toggling the state of the home button changes the visible
// state of the home button and moves the other items accordingly.
TEST_F(ToolbarControllerTest, ToggleHome) {
PrefService* prefs = helper_.profile()->GetPrefs();
bool showHome = prefs->GetBoolean(prefs::kShowHomeButton);
NSView* homeButton = [[bar_ toolbarViews] objectAtIndex:kHomeIndex];
EXPECT_EQ(showHome, ![homeButton isHidden]);
NSView* locationBar = [[bar_ toolbarViews] objectAtIndex:kLocationIndex];
NSRect originalLocationBarFrame = [locationBar frame];
// Toggle the pref and make sure the button changed state and the other
// views moved.
prefs->SetBoolean(prefs::kShowHomeButton, !showHome);
EXPECT_EQ(showHome, [homeButton isHidden]);
EXPECT_NE(NSMinX(originalLocationBarFrame), NSMinX([locationBar frame]));
EXPECT_NE(NSWidth(originalLocationBarFrame), NSWidth([locationBar frame]));
}
// Ensure that we don't toggle the buttons when we have a strip marked as not
// having the full toolbar. Also ensure that the location bar doesn't change
// size.
TEST_F(ToolbarControllerTest, DontToggleWhenNoToolbar) {
[bar_ setHasToolbar:NO hasLocationBar:YES];
NSView* homeButton = [[bar_ toolbarViews] objectAtIndex:kHomeIndex];
NSView* locationBar = [[bar_ toolbarViews] objectAtIndex:kLocationIndex];
NSRect locationBarFrame = [locationBar frame];
EXPECT_EQ([homeButton isHidden], YES);
[bar_ showOptionalHomeButton];
EXPECT_EQ([homeButton isHidden], YES);
NSRect newLocationBarFrame = [locationBar frame];
EXPECT_TRUE(NSEqualRects(locationBarFrame, newLocationBarFrame));
newLocationBarFrame = [locationBar frame];
EXPECT_TRUE(NSEqualRects(locationBarFrame, newLocationBarFrame));
}
TEST_F(ToolbarControllerTest, BookmarkBubblePoint) {
const NSPoint starPoint = [bar_ bookmarkBubblePoint];
const NSRect barFrame =
[[bar_ view] convertRect:[[bar_ view] bounds] toView:nil];
// Make sure the star is completely inside the location bar.
EXPECT_TRUE(NSPointInRect(starPoint, barFrame));
}
TEST_F(ToolbarControllerTest, HoverButtonForEvent) {
scoped_nsobject<HitView> view([[HitView alloc]
initWithFrame:NSMakeRect(0,0,100,100)]);
[bar_ setView:view];
NSEvent* event = [NSEvent mouseEventWithType:NSMouseMoved
location:NSMakePoint(10,10)
modifierFlags:0
timestamp:0
windowNumber:0
context:nil
eventNumber:0
clickCount:0
pressure:0.0];
// NOT a match.
[view setHitTestReturn:bar_.get()];
EXPECT_FALSE([bar_ hoverButtonForEvent:event]);
// Not yet...
scoped_nsobject<NSButton> button([[NSButton alloc] init]);
[view setHitTestReturn:button];
EXPECT_FALSE([bar_ hoverButtonForEvent:event]);
// Now!
scoped_nsobject<GradientButtonCell> cell([[GradientButtonCell alloc] init]);
[button setCell:cell.get()];
EXPECT_TRUE([bar_ hoverButtonForEvent:nil]);
}
} // namespace
|
