1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
|
// Copyright (c) 2010 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/basictypes.h"
#include "base/compiler_specific.h"
#include "base/file_path.h"
#include "base/file_util.h"
#include "base/path_service.h"
#include "base/scoped_ptr.h"
#include "base/string16.h"
#include "base/utf_string_conversions.h"
#include "chrome/browser/bookmarks/bookmark_model.h"
#include "chrome/browser/history/archived_database.h"
#include "chrome/browser/history/expire_history_backend.h"
#include "chrome/browser/history/history_database.h"
#include "chrome/browser/history/history_notifications.h"
#include "chrome/browser/history/text_database_manager.h"
#include "chrome/browser/history/thumbnail_database.h"
#include "chrome/browser/history/top_sites.h"
#include "chrome/common/notification_service.h"
#include "chrome/common/thumbnail_score.h"
#include "chrome/test/testing_profile.h"
#include "chrome/tools/profiles/thumbnail-inl.h"
#include "gfx/codec/jpeg_codec.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/skia/include/core/SkBitmap.h"
using base::Time;
using base::TimeDelta;
using base::TimeTicks;
// Filename constants.
static const FilePath::CharType kTestDir[] = FILE_PATH_LITERAL("ExpireTest");
static const FilePath::CharType kHistoryFile[] = FILE_PATH_LITERAL("History");
static const FilePath::CharType kArchivedHistoryFile[] =
FILE_PATH_LITERAL("Archived History");
static const FilePath::CharType kThumbnailFile[] =
FILE_PATH_LITERAL("Thumbnails");
// The test must be in the history namespace for the gtest forward declarations
// to work. It also eliminates a bunch of ugly "history::".
namespace history {
// ExpireHistoryTest -----------------------------------------------------------
class ExpireHistoryTest : public testing::Test,
public BroadcastNotificationDelegate {
public:
ExpireHistoryTest()
: bookmark_model_(NULL),
ALLOW_THIS_IN_INITIALIZER_LIST(expirer_(this, &bookmark_model_)),
now_(Time::Now()) {
}
protected:
// Called by individual tests when they want data populated.
void AddExampleData(URLID url_ids[3], Time visit_times[4]);
// Add visits with source information.
void AddExampleSourceData(const GURL& url, URLID* id);
// Returns true if the given favicon/thumanil has an entry in the DB.
bool HasFavIcon(FavIconID favicon_id);
bool HasThumbnail(URLID url_id);
// Returns the number of text matches for the given URL in the example data
// added by AddExampleData.
int CountTextMatchesForURL(const GURL& url);
// EXPECTs that each URL-specific history thing (basically, everything but
// favicons) is gone.
void EnsureURLInfoGone(const URLRow& row);
// Clears the list of notifications received.
void ClearLastNotifications() {
for (size_t i = 0; i < notifications_.size(); i++)
delete notifications_[i].second;
notifications_.clear();
}
void StarURL(const GURL& url) {
bookmark_model_.AddURL(
bookmark_model_.GetBookmarkBarNode(), 0, string16(), url);
}
static bool IsStringInFile(const FilePath& filename, const char* str);
BookmarkModel bookmark_model_;
MessageLoop message_loop_;
ExpireHistoryBackend expirer_;
scoped_ptr<HistoryDatabase> main_db_;
scoped_ptr<ArchivedDatabase> archived_db_;
scoped_ptr<ThumbnailDatabase> thumb_db_;
scoped_ptr<TextDatabaseManager> text_db_;
TestingProfile profile_;
scoped_refptr<TopSites> top_sites_;
// Time at the beginning of the test, so everybody agrees what "now" is.
const Time now_;
// Notifications intended to be broadcast, we can check these values to make
// sure that the deletor is doing the correct broadcasts. We own the details
// pointers.
typedef std::vector< std::pair<NotificationType, HistoryDetails*> >
NotificationList;
NotificationList notifications_;
// Directory for the history files.
FilePath dir_;
private:
void SetUp() {
FilePath temp_dir;
PathService::Get(base::DIR_TEMP, &temp_dir);
dir_ = temp_dir.Append(kTestDir);
file_util::Delete(dir_, true);
file_util::CreateDirectory(dir_);
FilePath history_name = dir_.Append(kHistoryFile);
main_db_.reset(new HistoryDatabase);
if (main_db_->Init(history_name, FilePath()) != sql::INIT_OK)
main_db_.reset();
FilePath archived_name = dir_.Append(kArchivedHistoryFile);
archived_db_.reset(new ArchivedDatabase);
if (!archived_db_->Init(archived_name))
archived_db_.reset();
FilePath thumb_name = dir_.Append(kThumbnailFile);
thumb_db_.reset(new ThumbnailDatabase);
if (thumb_db_->Init(thumb_name, NULL) != sql::INIT_OK)
thumb_db_.reset();
text_db_.reset(new TextDatabaseManager(dir_,
main_db_.get(), main_db_.get()));
if (!text_db_->Init(NULL))
text_db_.reset();
expirer_.SetDatabases(main_db_.get(), archived_db_.get(), thumb_db_.get(),
text_db_.get());
top_sites_ = profile_.GetTopSites();
}
void TearDown() {
ClearLastNotifications();
expirer_.SetDatabases(NULL, NULL, NULL, NULL);
main_db_.reset();
archived_db_.reset();
thumb_db_.reset();
text_db_.reset();
TopSites::DeleteTopSites(top_sites_);
file_util::Delete(dir_, true);
}
// BroadcastNotificationDelegate implementation.
void BroadcastNotifications(NotificationType type,
HistoryDetails* details_deleted) {
// This gets called when there are notifications to broadcast. Instead, we
// store them so we can tell that the correct notifications were sent.
notifications_.push_back(std::make_pair(type, details_deleted));
}
};
// The example data consists of 4 visits. The middle two visits are to the
// same URL, while the first and last are for unique ones. This allows a test
// for the oldest or newest to include both a URL that should get totally
// deleted (the one on the end) with one that should only get a visit deleted
// (with the one in the middle) when it picks the proper threshold time.
//
// Each visit has indexed data, each URL has thumbnail. The first two URLs will
// share the same favicon, while the last one will have a unique favicon. The
// second visit for the middle URL is typed.
//
// The IDs of the added URLs, and the times of the four added visits will be
// added to the given arrays.
void ExpireHistoryTest::AddExampleData(URLID url_ids[3], Time visit_times[4]) {
if (!main_db_.get() || !text_db_.get())
return;
// Four times for each visit.
visit_times[3] = Time::Now();
visit_times[2] = visit_times[3] - TimeDelta::FromDays(1);
visit_times[1] = visit_times[3] - TimeDelta::FromDays(2);
visit_times[0] = visit_times[3] - TimeDelta::FromDays(3);
// Two favicons. The first two URLs will share the same one, while the last
// one will have a unique favicon.
FavIconID favicon1 = thumb_db_->AddFavIcon(GURL("http://favicon/url1"));
FavIconID favicon2 = thumb_db_->AddFavIcon(GURL("http://favicon/url2"));
// Three URLs.
URLRow url_row1(GURL("http://www.google.com/1"));
url_row1.set_last_visit(visit_times[0]);
url_row1.set_favicon_id(favicon1);
url_row1.set_visit_count(1);
url_ids[0] = main_db_->AddURL(url_row1);
URLRow url_row2(GURL("http://www.google.com/2"));
url_row2.set_last_visit(visit_times[2]);
url_row2.set_favicon_id(favicon1);
url_row2.set_visit_count(2);
url_row2.set_typed_count(1);
url_ids[1] = main_db_->AddURL(url_row2);
URLRow url_row3(GURL("http://www.google.com/3"));
url_row3.set_last_visit(visit_times[3]);
url_row3.set_favicon_id(favicon2);
url_row3.set_visit_count(1);
url_ids[2] = main_db_->AddURL(url_row3);
// Thumbnails for each URL.
scoped_ptr<SkBitmap> thumbnail(
gfx::JPEGCodec::Decode(kGoogleThumbnail, sizeof(kGoogleThumbnail)));
ThumbnailScore score(0.25, true, true, Time::Now());
Time time;
GURL gurl;
top_sites_->SetPageThumbnail(url_row1.url(), *thumbnail, score);
top_sites_->SetPageThumbnail(url_row2.url(), *thumbnail, score);
top_sites_->SetPageThumbnail(url_row3.url(), *thumbnail, score);
// Four visits.
VisitRow visit_row1;
visit_row1.url_id = url_ids[0];
visit_row1.visit_time = visit_times[0];
visit_row1.is_indexed = true;
main_db_->AddVisit(&visit_row1, SOURCE_BROWSED);
VisitRow visit_row2;
visit_row2.url_id = url_ids[1];
visit_row2.visit_time = visit_times[1];
visit_row2.is_indexed = true;
main_db_->AddVisit(&visit_row2, SOURCE_BROWSED);
VisitRow visit_row3;
visit_row3.url_id = url_ids[1];
visit_row3.visit_time = visit_times[2];
visit_row3.is_indexed = true;
visit_row3.transition = PageTransition::TYPED;
main_db_->AddVisit(&visit_row3, SOURCE_BROWSED);
VisitRow visit_row4;
visit_row4.url_id = url_ids[2];
visit_row4.visit_time = visit_times[3];
visit_row4.is_indexed = true;
main_db_->AddVisit(&visit_row4, SOURCE_BROWSED);
// Full text index for each visit.
text_db_->AddPageData(url_row1.url(), visit_row1.url_id, visit_row1.visit_id,
visit_row1.visit_time, UTF8ToUTF16("title"),
UTF8ToUTF16("body"));
text_db_->AddPageData(url_row2.url(), visit_row2.url_id, visit_row2.visit_id,
visit_row2.visit_time, UTF8ToUTF16("title"),
UTF8ToUTF16("body"));
text_db_->AddPageData(url_row2.url(), visit_row3.url_id, visit_row3.visit_id,
visit_row3.visit_time, UTF8ToUTF16("title"),
UTF8ToUTF16("body"));
// Note the special text in this URL. We'll search the file for this string
// to make sure it doesn't hang around after the delete.
text_db_->AddPageData(url_row3.url(), visit_row4.url_id, visit_row4.visit_id,
visit_row4.visit_time, UTF8ToUTF16("title"),
UTF8ToUTF16("goats body"));
}
void ExpireHistoryTest::AddExampleSourceData(const GURL& url, URLID* id) {
if (!main_db_.get())
return;
Time last_visit_time = Time::Now();
// Add one URL.
URLRow url_row1(url);
url_row1.set_last_visit(last_visit_time);
url_row1.set_visit_count(4);
URLID url_id = main_db_->AddURL(url_row1);
*id = url_id;
// Four times for each visit.
VisitRow visit_row1(url_id, last_visit_time - TimeDelta::FromDays(4), 0,
PageTransition::TYPED, 0);
main_db_->AddVisit(&visit_row1, SOURCE_SYNCED);
VisitRow visit_row2(url_id, last_visit_time - TimeDelta::FromDays(3), 0,
PageTransition::TYPED, 0);
main_db_->AddVisit(&visit_row2, SOURCE_BROWSED);
VisitRow visit_row3(url_id, last_visit_time - TimeDelta::FromDays(2), 0,
PageTransition::TYPED, 0);
main_db_->AddVisit(&visit_row3, SOURCE_EXTENSION);
VisitRow visit_row4(url_id, last_visit_time, 0, PageTransition::TYPED, 0);
main_db_->AddVisit(&visit_row4, SOURCE_FIREFOX_IMPORTED);
}
bool ExpireHistoryTest::HasFavIcon(FavIconID favicon_id) {
if (!thumb_db_.get())
return false;
Time last_updated;
std::vector<unsigned char> icon_data_unused;
GURL icon_url;
return thumb_db_->GetFavIcon(favicon_id, &last_updated, &icon_data_unused,
&icon_url);
}
bool ExpireHistoryTest::HasThumbnail(URLID url_id) {
URLRow info;
if (!main_db_->GetURLRow(url_id, &info))
return false;
GURL url = info.url();
RefCountedBytes *data;
return top_sites_->GetPageThumbnail(url, &data);
}
int ExpireHistoryTest::CountTextMatchesForURL(const GURL& url) {
if (!text_db_.get())
return 0;
// "body" should match all pages in the example data.
std::vector<TextDatabase::Match> results;
QueryOptions options;
Time first_time;
text_db_->GetTextMatches(UTF8ToUTF16("body"), options,
&results, &first_time);
int count = 0;
for (size_t i = 0; i < results.size(); i++) {
if (results[i].url == url)
count++;
}
return count;
}
void ExpireHistoryTest::EnsureURLInfoGone(const URLRow& row) {
// Verify the URL no longer exists.
URLRow temp_row;
EXPECT_FALSE(main_db_->GetURLRow(row.id(), &temp_row));
// The indexed data should be gone.
EXPECT_EQ(0, CountTextMatchesForURL(row.url()));
// There should be no visits.
VisitVector visits;
main_db_->GetVisitsForURL(row.id(), &visits);
EXPECT_EQ(0U, visits.size());
// Thumbnail should be gone.
EXPECT_FALSE(HasThumbnail(row.id()));
// Check the notifications. There should be a delete notification with this
// URL in it. There should also be a "typed URL changed" notification if the
// row is marked typed.
bool found_delete_notification = false;
bool found_typed_changed_notification = false;
for (size_t i = 0; i < notifications_.size(); i++) {
if (notifications_[i].first == NotificationType::HISTORY_URLS_DELETED) {
const URLsDeletedDetails* deleted_details =
reinterpret_cast<URLsDeletedDetails*>(notifications_[i].second);
if (deleted_details->urls.find(row.url()) !=
deleted_details->urls.end()) {
found_delete_notification = true;
}
} else if (notifications_[i].first ==
NotificationType::HISTORY_TYPED_URLS_MODIFIED) {
// See if we got a typed URL changed notification.
const URLsModifiedDetails* modified_details =
reinterpret_cast<URLsModifiedDetails*>(notifications_[i].second);
for (size_t cur_url = 0; cur_url < modified_details->changed_urls.size();
cur_url++) {
if (modified_details->changed_urls[cur_url].url() == row.url())
found_typed_changed_notification = true;
}
} else if (notifications_[i].first ==
NotificationType::HISTORY_URL_VISITED) {
// See if we got a visited URL notification.
const URLVisitedDetails* visited_details =
reinterpret_cast<URLVisitedDetails*>(notifications_[i].second);
if (visited_details->row.url() == row.url())
found_typed_changed_notification = true;
}
}
EXPECT_TRUE(found_delete_notification);
EXPECT_EQ(row.typed_count() > 0, found_typed_changed_notification);
}
TEST_F(ExpireHistoryTest, DeleteFaviconsIfPossible) {
// Add a favicon record.
const GURL favicon_url("http://www.google.com/favicon.ico");
FavIconID icon_id = thumb_db_->AddFavIcon(favicon_url);
EXPECT_TRUE(icon_id);
EXPECT_TRUE(HasFavIcon(icon_id));
// The favicon should be deletable with no users.
std::set<FavIconID> favicon_set;
favicon_set.insert(icon_id);
expirer_.DeleteFaviconsIfPossible(favicon_set);
EXPECT_FALSE(HasFavIcon(icon_id));
// Add back the favicon.
icon_id = thumb_db_->AddFavIcon(favicon_url);
EXPECT_TRUE(icon_id);
EXPECT_TRUE(HasFavIcon(icon_id));
// Add a page that references the favicon.
URLRow row(GURL("http://www.google.com/2"));
row.set_visit_count(1);
row.set_favicon_id(icon_id);
EXPECT_TRUE(main_db_->AddURL(row));
// Favicon should not be deletable.
favicon_set.clear();
favicon_set.insert(icon_id);
expirer_.DeleteFaviconsIfPossible(favicon_set);
EXPECT_TRUE(HasFavIcon(icon_id));
}
// static
bool ExpireHistoryTest::IsStringInFile(const FilePath& filename,
const char* str) {
std::string contents;
EXPECT_TRUE(file_util::ReadFileToString(filename, &contents));
return contents.find(str) != std::string::npos;
}
// Deletes a URL with a favicon that it is the last referencer of, so that it
// should also get deleted.
// Fails near end of month. http://crbug.com/43586
TEST_F(ExpireHistoryTest, FLAKY_DeleteURLAndFavicon) {
URLID url_ids[3];
Time visit_times[4];
AddExampleData(url_ids, visit_times);
// Verify things are the way we expect with a URL row, favicon, thumbnail.
URLRow last_row;
ASSERT_TRUE(main_db_->GetURLRow(url_ids[2], &last_row));
EXPECT_TRUE(HasFavIcon(last_row.favicon_id()));
EXPECT_TRUE(HasThumbnail(url_ids[2]));
VisitVector visits;
main_db_->GetVisitsForURL(url_ids[2], &visits);
ASSERT_EQ(1U, visits.size());
EXPECT_EQ(1, CountTextMatchesForURL(last_row.url()));
// In this test we also make sure that any pending entries in the text
// database manager are removed.
text_db_->AddPageURL(last_row.url(), last_row.id(), visits[0].visit_id,
visits[0].visit_time);
// Compute the text DB filename.
FilePath fts_filename = dir_.Append(
TextDatabase::IDToFileName(text_db_->TimeToID(visit_times[3])));
// When checking the file, the database must be closed. We then re-initialize
// it just like the test set-up did.
text_db_.reset();
EXPECT_TRUE(IsStringInFile(fts_filename, "goats"));
text_db_.reset(new TextDatabaseManager(dir_,
main_db_.get(), main_db_.get()));
ASSERT_TRUE(text_db_->Init(NULL));
expirer_.SetDatabases(main_db_.get(), archived_db_.get(), thumb_db_.get(),
text_db_.get());
// Delete the URL and its dependencies.
expirer_.DeleteURL(last_row.url());
// The string should be removed from the file. FTS can mark it as gone but
// doesn't remove it from the file, we want to be sure we're doing the latter.
text_db_.reset();
EXPECT_FALSE(IsStringInFile(fts_filename, "goats"));
text_db_.reset(new TextDatabaseManager(dir_,
main_db_.get(), main_db_.get()));
ASSERT_TRUE(text_db_->Init(NULL));
expirer_.SetDatabases(main_db_.get(), archived_db_.get(), thumb_db_.get(),
text_db_.get());
// Run the text database expirer. This will flush any pending entries so we
// can check that nothing was committed. We use a time far in the future so
// that anything added recently will get flushed.
TimeTicks expiration_time = TimeTicks::Now() + TimeDelta::FromDays(1);
text_db_->FlushOldChangesForTime(expiration_time);
// All the normal data + the favicon should be gone.
EnsureURLInfoGone(last_row);
EXPECT_FALSE(HasFavIcon(last_row.favicon_id()));
}
// Deletes a URL with a favicon that other URLs reference, so that the favicon
// should not get deleted. This also tests deleting more than one visit.
TEST_F(ExpireHistoryTest, DeleteURLWithoutFavicon) {
URLID url_ids[3];
Time visit_times[4];
AddExampleData(url_ids, visit_times);
// Verify things are the way we expect with a URL row, favicon, thumbnail.
URLRow last_row;
ASSERT_TRUE(main_db_->GetURLRow(url_ids[1], &last_row));
EXPECT_TRUE(HasFavIcon(last_row.favicon_id()));
EXPECT_TRUE(HasThumbnail(url_ids[1]));
VisitVector visits;
main_db_->GetVisitsForURL(url_ids[1], &visits);
EXPECT_EQ(2U, visits.size());
EXPECT_EQ(1, CountTextMatchesForURL(last_row.url()));
// Delete the URL and its dependencies.
expirer_.DeleteURL(last_row.url());
// All the normal data + the favicon should be gone.
EnsureURLInfoGone(last_row);
EXPECT_TRUE(HasFavIcon(last_row.favicon_id()));
}
// DeleteURL should not delete starred urls.
TEST_F(ExpireHistoryTest, DontDeleteStarredURL) {
URLID url_ids[3];
Time visit_times[4];
AddExampleData(url_ids, visit_times);
URLRow url_row;
ASSERT_TRUE(main_db_->GetURLRow(url_ids[2], &url_row));
// Star the last URL.
StarURL(url_row.url());
// Attempt to delete the url.
expirer_.DeleteURL(url_row.url());
// Because the url is starred, it shouldn't be deleted.
GURL url = url_row.url();
ASSERT_TRUE(main_db_->GetRowForURL(url, &url_row));
// And the favicon should exist.
EXPECT_TRUE(HasFavIcon(url_row.favicon_id()));
// But there should be no fts.
ASSERT_EQ(0, CountTextMatchesForURL(url_row.url()));
// And no visits.
VisitVector visits;
main_db_->GetVisitsForURL(url_row.id(), &visits);
ASSERT_EQ(0U, visits.size());
// Should still have the thumbnail.
ASSERT_TRUE(HasThumbnail(url_row.id()));
// Unstar the URL and delete again.
bookmark_model_.SetURLStarred(url, string16(), false);
expirer_.DeleteURL(url);
// Now it should be completely deleted.
EnsureURLInfoGone(url_row);
}
// Expires all URLs more recent than a given time, with no starred items.
// Our time threshold is such that one URL should be updated (we delete one of
// the two visits) and one is deleted.
TEST_F(ExpireHistoryTest, FlushRecentURLsUnstarred) {
URLID url_ids[3];
Time visit_times[4];
AddExampleData(url_ids, visit_times);
URLRow url_row1, url_row2;
ASSERT_TRUE(main_db_->GetURLRow(url_ids[1], &url_row1));
ASSERT_TRUE(main_db_->GetURLRow(url_ids[2], &url_row2));
// In this test we also make sure that any pending entries in the text
// database manager are removed.
VisitVector visits;
main_db_->GetVisitsForURL(url_ids[2], &visits);
ASSERT_EQ(1U, visits.size());
text_db_->AddPageURL(url_row2.url(), url_row2.id(), visits[0].visit_id,
visits[0].visit_time);
// This should delete the last two visits.
std::set<GURL> restrict_urls;
expirer_.ExpireHistoryBetween(restrict_urls, visit_times[2], Time());
// Run the text database expirer. This will flush any pending entries so we
// can check that nothing was committed. We use a time far in the future so
// that anything added recently will get flushed.
TimeTicks expiration_time = TimeTicks::Now() + TimeDelta::FromDays(1);
text_db_->FlushOldChangesForTime(expiration_time);
// Verify that the middle URL had its last visit deleted only.
visits.clear();
main_db_->GetVisitsForURL(url_ids[1], &visits);
EXPECT_EQ(1U, visits.size());
EXPECT_EQ(0, CountTextMatchesForURL(url_row1.url()));
// Verify that the middle URL visit time and visit counts were updated.
URLRow temp_row;
ASSERT_TRUE(main_db_->GetURLRow(url_ids[1], &temp_row));
EXPECT_TRUE(visit_times[2] == url_row1.last_visit()); // Previous value.
EXPECT_TRUE(visit_times[1] == temp_row.last_visit()); // New value.
EXPECT_EQ(2, url_row1.visit_count());
EXPECT_EQ(1, temp_row.visit_count());
EXPECT_EQ(1, url_row1.typed_count());
EXPECT_EQ(0, temp_row.typed_count());
// Verify that the middle URL's favicon and thumbnail is still there.
EXPECT_TRUE(HasFavIcon(url_row1.favicon_id()));
EXPECT_TRUE(HasThumbnail(url_row1.id()));
// Verify that the last URL was deleted.
EnsureURLInfoGone(url_row2);
EXPECT_FALSE(HasFavIcon(url_row2.favicon_id()));
}
// Expires only a specific URLs more recent than a given time, with no starred
// items. Our time threshold is such that the URL should be updated (we delete
// one of the two visits).
TEST_F(ExpireHistoryTest, FlushRecentURLsUnstarredRestricted) {
URLID url_ids[3];
Time visit_times[4];
AddExampleData(url_ids, visit_times);
URLRow url_row1, url_row2;
ASSERT_TRUE(main_db_->GetURLRow(url_ids[1], &url_row1));
ASSERT_TRUE(main_db_->GetURLRow(url_ids[2], &url_row2));
// In this test we also make sure that any pending entries in the text
// database manager are removed.
VisitVector visits;
main_db_->GetVisitsForURL(url_ids[2], &visits);
ASSERT_EQ(1U, visits.size());
text_db_->AddPageURL(url_row2.url(), url_row2.id(), visits[0].visit_id,
visits[0].visit_time);
// This should delete the last two visits.
std::set<GURL> restrict_urls;
restrict_urls.insert(url_row1.url());
expirer_.ExpireHistoryBetween(restrict_urls, visit_times[2], Time());
// Run the text database expirer. This will flush any pending entries so we
// can check that nothing was committed. We use a time far in the future so
// that anything added recently will get flushed.
TimeTicks expiration_time = TimeTicks::Now() + TimeDelta::FromDays(1);
text_db_->FlushOldChangesForTime(expiration_time);
// Verify that the middle URL had its last visit deleted only.
visits.clear();
main_db_->GetVisitsForURL(url_ids[1], &visits);
EXPECT_EQ(1U, visits.size());
EXPECT_EQ(0, CountTextMatchesForURL(url_row1.url()));
// Verify that the middle URL visit time and visit counts were updated.
URLRow temp_row;
ASSERT_TRUE(main_db_->GetURLRow(url_ids[1], &temp_row));
EXPECT_TRUE(visit_times[2] == url_row1.last_visit()); // Previous value.
EXPECT_TRUE(visit_times[1] == temp_row.last_visit()); // New value.
EXPECT_EQ(2, url_row1.visit_count());
EXPECT_EQ(1, temp_row.visit_count());
EXPECT_EQ(1, url_row1.typed_count());
EXPECT_EQ(0, temp_row.typed_count());
// Verify that the middle URL's favicon and thumbnail is still there.
EXPECT_TRUE(HasFavIcon(url_row1.favicon_id()));
EXPECT_TRUE(HasThumbnail(url_row1.id()));
// Verify that the last URL was not touched.
EXPECT_TRUE(main_db_->GetURLRow(url_ids[2], &temp_row));
EXPECT_TRUE(HasFavIcon(url_row2.favicon_id()));
EXPECT_TRUE(HasThumbnail(url_row2.id()));
}
// Expire a starred URL, it shouldn't get deleted
TEST_F(ExpireHistoryTest, FlushRecentURLsStarred) {
URLID url_ids[3];
Time visit_times[4];
AddExampleData(url_ids, visit_times);
URLRow url_row1, url_row2;
ASSERT_TRUE(main_db_->GetURLRow(url_ids[1], &url_row1));
ASSERT_TRUE(main_db_->GetURLRow(url_ids[2], &url_row2));
// Star the last two URLs.
StarURL(url_row1.url());
StarURL(url_row2.url());
// This should delete the last two visits.
std::set<GURL> restrict_urls;
expirer_.ExpireHistoryBetween(restrict_urls, visit_times[2], Time());
// The URL rows should still exist.
URLRow new_url_row1, new_url_row2;
ASSERT_TRUE(main_db_->GetURLRow(url_ids[1], &new_url_row1));
ASSERT_TRUE(main_db_->GetURLRow(url_ids[2], &new_url_row2));
// The visit times should be updated.
EXPECT_TRUE(new_url_row1.last_visit() == visit_times[1]);
EXPECT_TRUE(new_url_row2.last_visit().is_null()); // No last visit time.
// Visit/typed count should not be updated for bookmarks.
EXPECT_EQ(0, new_url_row1.typed_count());
EXPECT_EQ(1, new_url_row1.visit_count());
EXPECT_EQ(0, new_url_row2.typed_count());
EXPECT_EQ(0, new_url_row2.visit_count());
// Thumbnails and favicons should still exist. Note that we keep thumbnails
// that may have been updated since the time threshold. Since the URL still
// exists in history, this should not be a privacy problem, we only update
// the visit counts in this case for consistency anyway.
EXPECT_TRUE(HasFavIcon(new_url_row1.favicon_id()));
EXPECT_TRUE(HasThumbnail(new_url_row1.id()));
EXPECT_TRUE(HasFavIcon(new_url_row2.favicon_id()));
EXPECT_TRUE(HasThumbnail(new_url_row2.id()));
}
TEST_F(ExpireHistoryTest, ArchiveHistoryBeforeUnstarred) {
URLID url_ids[3];
Time visit_times[4];
AddExampleData(url_ids, visit_times);
URLRow url_row1, url_row2;
ASSERT_TRUE(main_db_->GetURLRow(url_ids[1], &url_row1));
ASSERT_TRUE(main_db_->GetURLRow(url_ids[2], &url_row2));
// Archive the oldest two visits. This will actually result in deleting them
// since their transition types are empty (not important).
expirer_.ArchiveHistoryBefore(visit_times[1]);
// The first URL should be deleted, the second should not be affected.
URLRow temp_row;
EXPECT_FALSE(main_db_->GetURLRow(url_ids[0], &temp_row));
EXPECT_TRUE(main_db_->GetURLRow(url_ids[1], &temp_row));
EXPECT_TRUE(main_db_->GetURLRow(url_ids[2], &temp_row));
// Make sure the archived database has nothing in it.
EXPECT_FALSE(archived_db_->GetRowForURL(url_row1.url(), NULL));
EXPECT_FALSE(archived_db_->GetRowForURL(url_row2.url(), NULL));
// Now archive one more visit so that the middle URL should be removed. This
// one will actually be archived instead of deleted.
expirer_.ArchiveHistoryBefore(visit_times[2]);
EXPECT_FALSE(main_db_->GetURLRow(url_ids[1], &temp_row));
EXPECT_TRUE(main_db_->GetURLRow(url_ids[2], &temp_row));
// Make sure the archived database has an entry for the second URL.
URLRow archived_row;
// Note that the ID is different in the archived DB, so look up by URL.
EXPECT_TRUE(archived_db_->GetRowForURL(url_row1.url(), &archived_row));
VisitVector archived_visits;
archived_db_->GetVisitsForURL(archived_row.id(), &archived_visits);
EXPECT_EQ(1U, archived_visits.size());
}
TEST_F(ExpireHistoryTest, ArchiveHistoryBeforeStarred) {
URLID url_ids[3];
Time visit_times[4];
AddExampleData(url_ids, visit_times);
URLRow url_row0, url_row1;
ASSERT_TRUE(main_db_->GetURLRow(url_ids[0], &url_row0));
ASSERT_TRUE(main_db_->GetURLRow(url_ids[1], &url_row1));
// Star the URLs.
StarURL(url_row0.url());
StarURL(url_row1.url());
// Now archive the first three visits (first two URLs). The first two visits
// should be, the third deleted, but the URL records should not.
expirer_.ArchiveHistoryBefore(visit_times[2]);
// The first URL should have its visit deleted, but it should still be present
// in the main DB and not in the archived one since it is starred.
URLRow temp_row;
ASSERT_TRUE(main_db_->GetURLRow(url_ids[0], &temp_row));
// Note that the ID is different in the archived DB, so look up by URL.
EXPECT_FALSE(archived_db_->GetRowForURL(temp_row.url(), NULL));
VisitVector visits;
main_db_->GetVisitsForURL(temp_row.id(), &visits);
EXPECT_EQ(0U, visits.size());
// The second URL should have its first visit deleted and its second visit
// archived. It should be present in both the main DB (because it's starred)
// and the archived DB (for the archived visit).
ASSERT_TRUE(main_db_->GetURLRow(url_ids[1], &temp_row));
main_db_->GetVisitsForURL(temp_row.id(), &visits);
EXPECT_EQ(0U, visits.size());
// Note that the ID is different in the archived DB, so look up by URL.
ASSERT_TRUE(archived_db_->GetRowForURL(temp_row.url(), &temp_row));
archived_db_->GetVisitsForURL(temp_row.id(), &visits);
ASSERT_EQ(1U, visits.size());
EXPECT_TRUE(visit_times[2] == visits[0].visit_time);
// The third URL should be unchanged.
EXPECT_TRUE(main_db_->GetURLRow(url_ids[2], &temp_row));
EXPECT_FALSE(archived_db_->GetRowForURL(temp_row.url(), NULL));
}
// Tests the return values from ArchiveSomeOldHistory. The rest of the
// functionality of this function is tested by the ArchiveHistoryBefore*
// tests which use this function internally.
TEST_F(ExpireHistoryTest, ArchiveSomeOldHistory) {
URLID url_ids[3];
Time visit_times[4];
AddExampleData(url_ids, visit_times);
const ExpiringVisitsReader* reader = expirer_.GetAllVisitsReader();
// Deleting a time range with no URLs should return false (nothing found).
EXPECT_FALSE(expirer_.ArchiveSomeOldHistory(
visit_times[0] - TimeDelta::FromDays(100), reader, 1));
// Deleting a time range with not up the the max results should also return
// false (there will only be one visit deleted in this range).
EXPECT_FALSE(expirer_.ArchiveSomeOldHistory(visit_times[0], reader, 2));
// Deleting a time range with the max number of results should return true
// (max deleted).
EXPECT_TRUE(expirer_.ArchiveSomeOldHistory(visit_times[2], reader, 1));
}
TEST_F(ExpireHistoryTest, ExpiringVisitsReader) {
URLID url_ids[3];
Time visit_times[4];
AddExampleData(url_ids, visit_times);
const ExpiringVisitsReader* all = expirer_.GetAllVisitsReader();
const ExpiringVisitsReader* auto_subframes =
expirer_.GetAutoSubframeVisitsReader();
VisitVector visits;
Time now = Time::Now();
// Verify that the early expiration threshold, stored in the meta table is
// initialized.
EXPECT_TRUE(main_db_->GetEarlyExpirationThreshold() ==
Time::FromInternalValue(1L));
// First, attempt reading AUTO_SUBFRAME visits. We should get none.
EXPECT_FALSE(auto_subframes->Read(now, main_db_.get(), &visits, 1));
EXPECT_EQ(0U, visits.size());
// Verify that the early expiration threshold was updated, since there are no
// AUTO_SUBFRAME visits in the given time range.
EXPECT_TRUE(now <= main_db_->GetEarlyExpirationThreshold());
// Now, read all visits and verify that there's at least one.
EXPECT_TRUE(all->Read(now, main_db_.get(), &visits, 1));
EXPECT_EQ(1U, visits.size());
}
// Tests how ArchiveSomeOldHistory treats source information.
TEST_F(ExpireHistoryTest, ArchiveSomeOldHistoryWithSource) {
const GURL url("www.testsource.com");
URLID url_id;
AddExampleSourceData(url, &url_id);
const ExpiringVisitsReader* reader = expirer_.GetAllVisitsReader();
// Archiving all the visits we added.
ASSERT_FALSE(expirer_.ArchiveSomeOldHistory(Time::Now(), reader, 10));
URLRow archived_row;
ASSERT_TRUE(archived_db_->GetRowForURL(url, &archived_row));
VisitVector archived_visits;
archived_db_->GetVisitsForURL(archived_row.id(), &archived_visits);
ASSERT_EQ(4U, archived_visits.size());
VisitSourceMap sources;
archived_db_->GetVisitsSource(archived_visits, &sources);
ASSERT_EQ(3U, sources.size());
int result = 0;
VisitSourceMap::iterator iter;
for (int i = 0; i < 4; i++) {
iter = sources.find(archived_visits[i].visit_id);
if (iter == sources.end())
continue;
switch (iter->second) {
case history::SOURCE_EXTENSION:
result |= 0x1;
break;
case history::SOURCE_FIREFOX_IMPORTED:
result |= 0x2;
break;
case history::SOURCE_SYNCED:
result |= 0x4;
default:
break;
}
}
EXPECT_EQ(0x7, result);
main_db_->GetVisitsSource(archived_visits, &sources);
EXPECT_EQ(0U, sources.size());
main_db_->GetVisitsForURL(url_id, &archived_visits);
EXPECT_EQ(0U, archived_visits.size());
}
// TODO(brettw) add some visits with no URL to make sure everything is updated
// properly. Have the visits also refer to nonexistent FTS rows.
//
// Maybe also refer to invalid favicons.
} // namespace history
|