1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
|
// Copyright (c) 2010 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#import "chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h"
#include "base/mac/mac_util.h"
#include "base/sys_string_conversions.h"
#include "base/utf_string_conversions.h" // TODO(viettrungluu): remove
#include "chrome/browser/bookmarks/bookmark_model.h"
#include "chrome/browser/metrics/user_metrics.h"
#import "chrome/browser/ui/cocoa/bookmarks/bookmark_button.h"
#import "chrome/browser/ui/cocoa/browser_window_controller.h"
#import "chrome/browser/ui/cocoa/info_bubble_view.h"
#include "chrome/common/notification_observer.h"
#include "chrome/common/notification_registrar.h"
#include "chrome/common/notification_service.h"
#include "grit/generated_resources.h"
#include "ui/base/l10n/l10n_util_mac.h"
// Simple class to watch for tab creation/destruction and close the bubble.
// Bridge between Chrome-style notifications and ObjC-style notifications.
class BookmarkBubbleNotificationBridge : public NotificationObserver {
public:
BookmarkBubbleNotificationBridge(BookmarkBubbleController* controller,
SEL selector);
virtual ~BookmarkBubbleNotificationBridge() {}
void Observe(NotificationType type,
const NotificationSource& source,
const NotificationDetails& details);
private:
NotificationRegistrar registrar_;
BookmarkBubbleController* controller_; // weak; owns us.
SEL selector_; // SEL sent to controller_ on notification.
};
BookmarkBubbleNotificationBridge::BookmarkBubbleNotificationBridge(
BookmarkBubbleController* controller, SEL selector)
: controller_(controller), selector_(selector) {
// registrar_ will automatically RemoveAll() when destroyed so we
// don't need to do so explicitly.
registrar_.Add(this, NotificationType::TAB_CONTENTS_CONNECTED,
NotificationService::AllSources());
registrar_.Add(this, NotificationType::TAB_CLOSED,
NotificationService::AllSources());
}
// At this time all notifications instigate the same behavior (go
// away) so we don't bother checking which notification came in.
void BookmarkBubbleNotificationBridge::Observe(
NotificationType type,
const NotificationSource& source,
const NotificationDetails& details) {
[controller_ performSelector:selector_ withObject:controller_];
}
// An object to represent the ChooseAnotherFolder item in the pop up.
@interface ChooseAnotherFolder : NSObject
@end
@implementation ChooseAnotherFolder
@end
@interface BookmarkBubbleController (PrivateAPI)
- (void)updateBookmarkNode;
- (void)fillInFolderList;
- (void)parentWindowWillClose:(NSNotification*)notification;
@end
@implementation BookmarkBubbleController
@synthesize node = node_;
+ (id)chooseAnotherFolderObject {
// Singleton object to act as a representedObject for the "choose another
// folder" item in the pop up.
static ChooseAnotherFolder* object = nil;
if (!object) {
object = [[ChooseAnotherFolder alloc] init];
}
return object;
}
- (id)initWithParentWindow:(NSWindow*)parentWindow
model:(BookmarkModel*)model
node:(const BookmarkNode*)node
alreadyBookmarked:(BOOL)alreadyBookmarked {
NSString* nibPath =
[base::mac::MainAppBundle() pathForResource:@"BookmarkBubble"
ofType:@"nib"];
if ((self = [super initWithWindowNibPath:nibPath owner:self])) {
parentWindow_ = parentWindow;
model_ = model;
node_ = node;
alreadyBookmarked_ = alreadyBookmarked;
// Watch to see if the parent window closes, and if so, close this one.
NSNotificationCenter* center = [NSNotificationCenter defaultCenter];
[center addObserver:self
selector:@selector(parentWindowWillClose:)
name:NSWindowWillCloseNotification
object:parentWindow_];
}
return self;
}
- (void)dealloc {
[[NSNotificationCenter defaultCenter] removeObserver:self];
[super dealloc];
}
// If this is a new bookmark somewhere visible (e.g. on the bookmark
// bar), pulse it. Else, call ourself recursively with our parent
// until we find something visible to pulse.
- (void)startPulsingBookmarkButton:(const BookmarkNode*)node {
while (node) {
if ((node->GetParent() == model_->GetBookmarkBarNode()) ||
(node == model_->other_node())) {
pulsingBookmarkNode_ = node;
NSValue *value = [NSValue valueWithPointer:node];
NSDictionary *dict = [NSDictionary
dictionaryWithObjectsAndKeys:value,
bookmark_button::kBookmarkKey,
[NSNumber numberWithBool:YES],
bookmark_button::kBookmarkPulseFlagKey,
nil];
[[NSNotificationCenter defaultCenter]
postNotificationName:bookmark_button::kPulseBookmarkButtonNotification
object:self
userInfo:dict];
return;
}
node = node->GetParent();
}
}
- (void)stopPulsingBookmarkButton {
if (!pulsingBookmarkNode_)
return;
NSValue *value = [NSValue valueWithPointer:pulsingBookmarkNode_];
pulsingBookmarkNode_ = NULL;
NSDictionary *dict = [NSDictionary
dictionaryWithObjectsAndKeys:value,
bookmark_button::kBookmarkKey,
[NSNumber numberWithBool:NO],
bookmark_button::kBookmarkPulseFlagKey,
nil];
[[NSNotificationCenter defaultCenter]
postNotificationName:bookmark_button::kPulseBookmarkButtonNotification
object:self
userInfo:dict];
}
// Close the bookmark bubble without changing anything. Unlike a
// typical dialog's OK/Cancel, where Cancel is "do nothing", all
// buttons on the bubble have the capacity to change the bookmark
// model. This is an IBOutlet-looking entry point to remove the
// dialog without touching the model.
- (void)dismissWithoutEditing:(id)sender {
[self close];
}
- (void)parentWindowWillClose:(NSNotification*)notification {
[self close];
}
- (void)windowWillClose:(NSNotification*)notification {
// We caught a close so we don't need to watch for the parent closing.
[[NSNotificationCenter defaultCenter] removeObserver:self];
bookmark_observer_.reset(NULL);
chrome_observer_.reset(NULL);
[self stopPulsingBookmarkButton];
[self autorelease];
}
// We want this to be a child of a browser window. addChildWindow:
// (called from this function) will bring the window on-screen;
// unfortunately, [NSWindowController showWindow:] will also bring it
// on-screen (but will cause unexpected changes to the window's
// position). We cannot have an addChildWindow: and a subsequent
// showWindow:. Thus, we have our own version.
- (void)showWindow:(id)sender {
BrowserWindowController* bwc =
[BrowserWindowController browserWindowControllerForWindow:parentWindow_];
[bwc lockBarVisibilityForOwner:self withAnimation:NO delay:NO];
NSWindow* window = [self window]; // completes nib load
[bubble_ setArrowLocation:info_bubble::kTopRight];
// Insure decent positioning even in the absence of a browser controller,
// which will occur for some unit tests.
NSPoint arrowtip = bwc ? [bwc bookmarkBubblePoint] :
NSMakePoint([window frame].size.width, [window frame].size.height);
NSPoint origin = [parentWindow_ convertBaseToScreen:arrowtip];
NSPoint bubbleArrowtip = [bubble_ arrowTip];
bubbleArrowtip = [bubble_ convertPoint:bubbleArrowtip toView:nil];
origin.y -= bubbleArrowtip.y;
origin.x -= bubbleArrowtip.x;
[window setFrameOrigin:origin];
[parentWindow_ addChildWindow:window ordered:NSWindowAbove];
// Default is IDS_BOOMARK_BUBBLE_PAGE_BOOKMARK; "Bookmark".
// If adding for the 1st time the string becomes "Bookmark Added!"
if (!alreadyBookmarked_) {
NSString* title =
l10n_util::GetNSString(IDS_BOOMARK_BUBBLE_PAGE_BOOKMARKED);
[bigTitle_ setStringValue:title];
}
[self fillInFolderList];
// Ping me when things change out from under us. Unlike a normal
// dialog, the bookmark bubble's cancel: means "don't add this as a
// bookmark", not "cancel editing". We must take extra care to not
// touch the bookmark in this selector.
bookmark_observer_.reset(new BookmarkModelObserverForCocoa(
node_, model_,
self,
@selector(dismissWithoutEditing:)));
chrome_observer_.reset(new BookmarkBubbleNotificationBridge(
self, @selector(dismissWithoutEditing:)));
// Pulse something interesting on the bookmark bar.
[self startPulsingBookmarkButton:node_];
[window makeKeyAndOrderFront:self];
}
- (void)close {
[[BrowserWindowController browserWindowControllerForWindow:parentWindow_]
releaseBarVisibilityForOwner:self withAnimation:YES delay:NO];
[parentWindow_ removeChildWindow:[self window]];
// If you quit while the bubble is open, sometimes we get a
// DidResignKey before we get our parent's WindowWillClose and
// sometimes not. We protect against a multiple close (or reference
// to parentWindow_ at a bad time) by clearing it out once we're
// done, and by removing ourself from future notifications.
[[NSNotificationCenter defaultCenter]
removeObserver:self
name:NSWindowWillCloseNotification
object:parentWindow_];
parentWindow_ = nil;
[super close];
}
// Shows the bookmark editor sheet for more advanced editing.
- (void)showEditor {
[self ok:self];
// Send the action up through the responder chain.
[NSApp sendAction:@selector(editBookmarkNode:) to:nil from:self];
}
- (IBAction)edit:(id)sender {
UserMetrics::RecordAction(UserMetricsAction("BookmarkBubble_Edit"),
model_->profile());
[self showEditor];
}
- (IBAction)ok:(id)sender {
[self stopPulsingBookmarkButton]; // before parent changes
[self updateBookmarkNode];
[self close];
}
// By implementing this, ESC causes the window to go away. If clicking the
// star was what prompted this bubble to appear (i.e., not already bookmarked),
// remove the bookmark.
- (IBAction)cancel:(id)sender {
if (!alreadyBookmarked_) {
// |-remove:| calls |-close| so don't do it.
[self remove:sender];
} else {
[self ok:sender];
}
}
- (IBAction)remove:(id)sender {
[self stopPulsingBookmarkButton];
// TODO(viettrungluu): get rid of conversion and utf_string_conversions.h.
model_->SetURLStarred(node_->GetURL(), node_->GetTitle(), false);
UserMetrics::RecordAction(UserMetricsAction("BookmarkBubble_Unstar"),
model_->profile());
node_ = NULL; // no longer valid
[self ok:sender];
}
// The controller is the target of the pop up button box action so it can
// handle when "choose another folder" was picked.
- (IBAction)folderChanged:(id)sender {
DCHECK([sender isEqual:folderPopUpButton_]);
// It is possible that due to model change our parent window has been closed
// but the popup is still showing and able to notify the controller of a
// folder change. We ignore the sender in this case.
if (!parentWindow_)
return;
NSMenuItem* selected = [folderPopUpButton_ selectedItem];
ChooseAnotherFolder* chooseItem = [[self class] chooseAnotherFolderObject];
if ([[selected representedObject] isEqual:chooseItem]) {
UserMetrics::RecordAction(
UserMetricsAction("BookmarkBubble_EditFromCombobox"),
model_->profile());
[self showEditor];
}
}
// The controller is the delegate of the window so it receives did resign key
// notifications. When key is resigned mirror Windows behavior and close the
// window.
- (void)windowDidResignKey:(NSNotification*)notification {
NSWindow* window = [self window];
DCHECK_EQ([notification object], window);
if ([window isVisible]) {
// If the window isn't visible, it is already closed, and this notification
// has been sent as part of the closing operation, so no need to close.
[self ok:self];
}
}
// Look at the dialog; if the user has changed anything, update the
// bookmark node to reflect this.
- (void)updateBookmarkNode {
if (!node_) return;
// First the title...
NSString* oldTitle = base::SysUTF16ToNSString(node_->GetTitle());
NSString* newTitle = [nameTextField_ stringValue];
if (![oldTitle isEqual:newTitle]) {
model_->SetTitle(node_, base::SysNSStringToUTF16(newTitle));
UserMetrics::RecordAction(
UserMetricsAction("BookmarkBubble_ChangeTitleInBubble"),
model_->profile());
}
// Then the parent folder.
const BookmarkNode* oldParent = node_->GetParent();
NSMenuItem* selectedItem = [folderPopUpButton_ selectedItem];
id representedObject = [selectedItem representedObject];
if ([representedObject isEqual:[[self class] chooseAnotherFolderObject]]) {
// "Choose another folder..."
return;
}
const BookmarkNode* newParent =
static_cast<const BookmarkNode*>([representedObject pointerValue]);
DCHECK(newParent);
if (oldParent != newParent) {
int index = newParent->GetChildCount();
model_->Move(node_, newParent, index);
UserMetrics::RecordAction(UserMetricsAction("BookmarkBubble_ChangeParent"),
model_->profile());
}
}
// Fill in all information related to the folder pop up button.
- (void)fillInFolderList {
[nameTextField_ setStringValue:base::SysUTF16ToNSString(node_->GetTitle())];
DCHECK([folderPopUpButton_ numberOfItems] == 0);
[self addFolderNodes:model_->root_node()
toPopUpButton:folderPopUpButton_
indentation:0];
NSMenu* menu = [folderPopUpButton_ menu];
NSString* title = [[self class] chooseAnotherFolderString];
NSMenuItem *item = [menu addItemWithTitle:title
action:NULL
keyEquivalent:@""];
ChooseAnotherFolder* obj = [[self class] chooseAnotherFolderObject];
[item setRepresentedObject:obj];
// Finally, select the current parent.
NSValue* parentValue = [NSValue valueWithPointer:node_->GetParent()];
NSInteger idx = [menu indexOfItemWithRepresentedObject:parentValue];
[folderPopUpButton_ selectItemAtIndex:idx];
}
@end // BookmarkBubbleController
@implementation BookmarkBubbleController(ExposedForUnitTesting)
+ (NSString*)chooseAnotherFolderString {
return l10n_util::GetNSStringWithFixup(
IDS_BOOMARK_BUBBLE_CHOOSER_ANOTHER_FOLDER);
}
// For the given folder node, walk the tree and add folder names to
// the given pop up button.
- (void)addFolderNodes:(const BookmarkNode*)parent
toPopUpButton:(NSPopUpButton*)button
indentation:(int)indentation {
if (!model_->is_root(parent)) {
NSString* title = base::SysUTF16ToNSString(parent->GetTitle());
NSMenu* menu = [button menu];
NSMenuItem* item = [menu addItemWithTitle:title
action:NULL
keyEquivalent:@""];
[item setRepresentedObject:[NSValue valueWithPointer:parent]];
[item setIndentationLevel:indentation];
++indentation;
}
for (int i = 0; i < parent->GetChildCount(); i++) {
const BookmarkNode* child = parent->GetChild(i);
if (child->is_folder())
[self addFolderNodes:child
toPopUpButton:button
indentation:indentation];
}
}
- (void)setTitle:(NSString*)title parentFolder:(const BookmarkNode*)parent {
[nameTextField_ setStringValue:title];
[self setParentFolderSelection:parent];
}
// Pick a specific parent node in the selection by finding the right
// pop up button index.
- (void)setParentFolderSelection:(const BookmarkNode*)parent {
// Expectation: There is a parent mapping for all items in the
// folderPopUpButton except the last one ("Choose another folder...").
NSMenu* menu = [folderPopUpButton_ menu];
NSValue* parentValue = [NSValue valueWithPointer:parent];
NSInteger idx = [menu indexOfItemWithRepresentedObject:parentValue];
DCHECK(idx != -1);
[folderPopUpButton_ selectItemAtIndex:idx];
}
- (NSPopUpButton*)folderPopUpButton {
return folderPopUpButton_;
}
@end // implementation BookmarkBubbleController(ExposedForUnitTesting)
|