summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid 'Digit' Turner <digit@google.com>2011-01-17 00:19:37 +0100
committerMike Lockwood <lockwood@android.com>2011-02-27 18:39:41 -0800
commit1a7408cd64dfc5e08f6d200c51d9fd3eb75e4d07 (patch)
treed9de5779a349dd91011b8916612f4fa3bc88e204
parentf13ec7a3ac18ad87936ddab2e18f57c3bf91bfb6 (diff)
downloadframeworks_base-1a7408cd64dfc5e08f6d200c51d9fd3eb75e4d07.zip
frameworks_base-1a7408cd64dfc5e08f6d200c51d9fd3eb75e4d07.tar.gz
frameworks_base-1a7408cd64dfc5e08f6d200c51d9fd3eb75e4d07.tar.bz2
UsbService: Remove stack-trace message during boot. DO NOT MERGE
This removes a stack trace message during the boot under emulation. The observers tried to access a null reference when no USB configuration is supported by the emulated device. So do not start them in this case. + Change a Slog.w into a Slog.i since this is an acceptable condition. Change-Id: I801f352574716d7868f182bb6e5ee49e5b12e4f1
-rw-r--r--services/java/com/android/server/UsbService.java13
1 files changed, 9 insertions, 4 deletions
diff --git a/services/java/com/android/server/UsbService.java b/services/java/com/android/server/UsbService.java
index 672c95e..578db0e 100644
--- a/services/java/com/android/server/UsbService.java
+++ b/services/java/com/android/server/UsbService.java
@@ -134,14 +134,17 @@ class UsbService {
mContext = context;
init(); // set initial status
- mUEventObserver.startObserving(USB_CONNECTED_MATCH);
- mUEventObserver.startObserving(USB_CONFIGURATION_MATCH);
- mUEventObserver.startObserving(USB_FUNCTIONS_MATCH);
+ if (mConfiguration >= 0) {
+ mUEventObserver.startObserving(USB_CONNECTED_MATCH);
+ mUEventObserver.startObserving(USB_CONFIGURATION_MATCH);
+ mUEventObserver.startObserving(USB_FUNCTIONS_MATCH);
+ }
}
private final void init() {
char[] buffer = new char[1024];
+ mConfiguration = -1;
try {
FileReader file = new FileReader(USB_CONNECTED_PATH);
int len = file.read(buffer, 0, 1024);
@@ -153,10 +156,12 @@ class UsbService {
file.close();
mConfiguration = Integer.valueOf((new String(buffer, 0, len)).trim());
} catch (FileNotFoundException e) {
- Slog.w(TAG, "This kernel does not have USB configuration switch support");
+ Slog.i(TAG, "This kernel does not have USB configuration switch support");
} catch (Exception e) {
Slog.e(TAG, "" , e);
}
+ if (mConfiguration < 0)
+ return;
try {
File[] files = new File(USB_COMPOSITE_CLASS_PATH).listFiles();