summaryrefslogtreecommitdiffstats
path: root/camera
diff options
context:
space:
mode:
authorMathias Agopian <mathias@google.com>2010-02-16 19:42:32 -0800
committerMathias Agopian <mathias@google.com>2010-02-16 20:45:21 -0800
commit5a48712501982c7276c1455e280e0b95149bdd0b (patch)
tree335603441add0116c3cffe84c64f0056a3d30fbb /camera
parent102f49f361b9d8d780b0f683f417f8c02a4e25f3 (diff)
downloadframeworks_base-5a48712501982c7276c1455e280e0b95149bdd0b.zip
frameworks_base-5a48712501982c7276c1455e280e0b95149bdd0b.tar.gz
frameworks_base-5a48712501982c7276c1455e280e0b95149bdd0b.tar.bz2
fix [2447659] fix improper usage of the YCbCr_420_SP format
Diffstat (limited to 'camera')
-rw-r--r--camera/libcameraservice/CameraService.cpp6
1 files changed, 4 insertions, 2 deletions
diff --git a/camera/libcameraservice/CameraService.cpp b/camera/libcameraservice/CameraService.cpp
index f66a2d3..7e81e90 100644
--- a/camera/libcameraservice/CameraService.cpp
+++ b/camera/libcameraservice/CameraService.cpp
@@ -607,8 +607,9 @@ status_t CameraService::Client::registerPreviewBuffers()
CameraParameters params(mHardware->getParameters());
params.getPreviewSize(&w, &h);
+ // don't use a hardcoded format here
ISurface::BufferHeap buffers(w, h, w, h,
- HAL_PIXEL_FORMAT_YCbCr_420_SP,
+ HAL_PIXEL_FORMAT_YCrCb_420_SP,
mOrientation,
0,
mHardware->getPreviewHeap());
@@ -928,8 +929,9 @@ void CameraService::Client::handleShutter(
h &= ~1;
LOGV("Snapshot image width=%d, height=%d", w, h);
}
+ // FIXME: don't use hardcoded format constants here
ISurface::BufferHeap buffers(w, h, w, h,
- HAL_PIXEL_FORMAT_YCbCr_420_SP, mOrientation, 0,
+ HAL_PIXEL_FORMAT_YCrCb_420_SP, mOrientation, 0,
mHardware->getRawHeap());
mSurface->registerBuffers(buffers);