summaryrefslogtreecommitdiffstats
path: root/media/libmedia
diff options
context:
space:
mode:
authorMarco Nelissen <marcone@google.com>2009-07-10 09:34:59 -0700
committerMarco Nelissen <marcone@google.com>2009-07-10 13:43:41 -0700
commit0fc736f321b01995d9f5913d2490cbb479554266 (patch)
tree091b71ef6efb72b9dea36bb4d70d6ff5f8f1af87 /media/libmedia
parentb88993f073a353fba6a2d6e4510fad5a2a5b170d (diff)
downloadframeworks_base-0fc736f321b01995d9f5913d2490cbb479554266.zip
frameworks_base-0fc736f321b01995d9f5913d2490cbb479554266.tar.gz
frameworks_base-0fc736f321b01995d9f5913d2490cbb479554266.tar.bz2
Don't pass references to temporary objects, and handle the case where we dont have a Surface.
Diffstat (limited to 'media/libmedia')
-rw-r--r--media/libmedia/mediaplayer.cpp5
1 files changed, 4 insertions, 1 deletions
diff --git a/media/libmedia/mediaplayer.cpp b/media/libmedia/mediaplayer.cpp
index 6b35fa7..aeb43c5 100644
--- a/media/libmedia/mediaplayer.cpp
+++ b/media/libmedia/mediaplayer.cpp
@@ -233,7 +233,10 @@ status_t MediaPlayer::setVideoSurface(const sp<Surface>& surface)
LOGV("setVideoSurface");
Mutex::Autolock _l(mLock);
if (mPlayer == 0) return NO_INIT;
- return mPlayer->setVideoSurface(surface->getISurface());
+ if (surface != NULL)
+ return mPlayer->setVideoSurface(surface->getISurface());
+ else
+ return mPlayer->setVideoSurface(NULL);
}
// must call with lock held