summaryrefslogtreecommitdiffstats
path: root/media/mtp/MtpProperty.cpp
diff options
context:
space:
mode:
authorMike Lockwood <lockwood@android.com>2010-08-09 14:49:28 -0400
committerMike Lockwood <lockwood@android.com>2010-08-09 14:49:28 -0400
commit97c8d9046ea9500ab77970eaa3f66bc1034ff43e (patch)
tree8b2c4aa5f026dbece9586320670a5f9ec37dfada /media/mtp/MtpProperty.cpp
parentd3793f38f974f3c661289e4fa140b51655c5ed71 (diff)
downloadframeworks_base-97c8d9046ea9500ab77970eaa3f66bc1034ff43e.zip
frameworks_base-97c8d9046ea9500ab77970eaa3f66bc1034ff43e.tar.gz
frameworks_base-97c8d9046ea9500ab77970eaa3f66bc1034ff43e.tar.bz2
MTP: Fix reading and writing property descriptors
We were missing support for the group code, resulting in an off by 4 bytes problem. Change-Id: I4a640c67b8d36e1bd658b6185178a71966d4b0b6 Signed-off-by: Mike Lockwood <lockwood@android.com>
Diffstat (limited to 'media/mtp/MtpProperty.cpp')
-rw-r--r--media/mtp/MtpProperty.cpp4
1 files changed, 4 insertions, 0 deletions
diff --git a/media/mtp/MtpProperty.cpp b/media/mtp/MtpProperty.cpp
index d6beb8a..932ad6a 100644
--- a/media/mtp/MtpProperty.cpp
+++ b/media/mtp/MtpProperty.cpp
@@ -31,6 +31,7 @@ MtpProperty::MtpProperty()
mDefaultArrayValues(NULL),
mCurrentArrayLength(0),
mCurrentArrayValues(NULL),
+ mGroupCode(0),
mFormFlag(kFormNone),
mEnumLength(0),
mEnumValues(NULL)
@@ -52,6 +53,7 @@ MtpProperty::MtpProperty(MtpPropertyCode propCode,
mDefaultArrayValues(NULL),
mCurrentArrayLength(0),
mCurrentArrayValues(NULL),
+ mGroupCode(0),
mFormFlag(kFormNone),
mEnumLength(0),
mEnumValues(NULL)
@@ -142,6 +144,7 @@ void MtpProperty::read(MtpDataPacket& packet, bool deviceProp) {
if (deviceProp)
readValue(packet, mCurrentValue);
}
+ mGroupCode = packet.getUInt32();
mFormFlag = packet.getUInt8();
if (mFormFlag == kFormRange) {
@@ -178,6 +181,7 @@ void MtpProperty::write(MtpDataPacket& packet) {
default:
writeValue(packet, mDefaultValue);
}
+ packet.putUInt32(mGroupCode);
packet.putUInt8(mFormFlag);
if (mFormFlag == kFormRange) {
writeValue(packet, mMinimumValue);