summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--gen.c3
-rw-r--r--samsung-ril.c4
2 files changed, 4 insertions, 3 deletions
diff --git a/gen.c b/gen.c
index 0a3d8d0..ad171c8 100644
--- a/gen.c
+++ b/gen.c
@@ -33,6 +33,7 @@ int ipc_gen_phone_res_id = 0;
/**
* IPC_GEN_PHONE_RES has shared aseq (in the header), group, index and type (in the data)
+ * with the original request it responds to.
* On this implementation, we just check aseq and command (group and index).
* aseq permits to identify the queued request and do what's wanted.
* It can be either call a function with the struct ipc_message_info,
@@ -48,6 +49,8 @@ int ipc_gen_phone_res_id = 0;
* On a custom function, don't forget to get a clean new aseq if you're going to
* send some data to the modem, just liek this:
* aseq = ril_request_reg_id(reqGetToken(info->aseq));
+ *
+ * Please use GEN_PHONE_RES engine as often as possible!
*/
/**
diff --git a/samsung-ril.c b/samsung-ril.c
index 34b2014..edb5487 100644
--- a/samsung-ril.c
+++ b/samsung-ril.c
@@ -36,9 +36,7 @@
*
* General:
* - SIM SMS I/O
- * - ipc_disp_icon_info: trace on RILJ & emulate RIl_REQUEST_SIGNAL_STRENGTH
- * - gen phone res queue → apply to max functions
- * - DTMF burst queue + lock, DTMF_START lock
+ * - Review code with requests that produce GEN_PHONE_RES messages to use the GEN_PHONE_RES engine
*
* Data-related:
* - find a reliable way to configure data iface