diff options
author | Damian Minkov <damencho@jitsi.org> | 2011-02-14 08:45:42 +0000 |
---|---|---|
committer | Damian Minkov <damencho@jitsi.org> | 2011-02-14 08:45:42 +0000 |
commit | ce0a364300135ce1a191a6e819baa6da8c2a19e7 (patch) | |
tree | 6a40a108546af1aa4fd30c22737515aec5d4b75d /src/net/java | |
parent | 3fdd1d10482da0518e1add78e12fc4711be0c031 (diff) | |
download | jitsi-ce0a364300135ce1a191a6e819baa6da8c2a19e7.zip jitsi-ce0a364300135ce1a191a6e819baa6da8c2a19e7.tar.gz jitsi-ce0a364300135ce1a191a6e819baa6da8c2a19e7.tar.bz2 |
Some typos and javadoc.
Diffstat (limited to 'src/net/java')
-rw-r--r-- | src/net/java/sip/communicator/plugin/loggingutils/LoggingConfigForm.java | 19 | ||||
-rw-r--r-- | src/net/java/sip/communicator/plugin/loggingutils/LoggingUtilsActivator.java | 2 |
2 files changed, 14 insertions, 7 deletions
diff --git a/src/net/java/sip/communicator/plugin/loggingutils/LoggingConfigForm.java b/src/net/java/sip/communicator/plugin/loggingutils/LoggingConfigForm.java index ce019b2..ade8dff 100644 --- a/src/net/java/sip/communicator/plugin/loggingutils/LoggingConfigForm.java +++ b/src/net/java/sip/communicator/plugin/loggingutils/LoggingConfigForm.java @@ -246,7 +246,7 @@ public class LoggingConfigForm * from default settings. * @return the upload location. */ - private String getUploadLocation() + static String getUploadLocation() { // check first in configuration it can be manually set // or by provisioning @@ -623,6 +623,8 @@ public class LoggingConfigForm public void run() { uploadLogs( + getUploadLocation(), + LogsCollector.getDefaultFileName(), paramNames.toArray(new String[]{}), paramValues.toArray(new String[]{})); } @@ -649,15 +651,22 @@ public class LoggingConfigForm /** * Upload files to pre-configured url. + * @param uploadLocation the location we are uploading to. + * @param fileName the filename we use for the resulting filename we upload. + * @param params the optional parameter names. + * @param values the optional parameter values. */ - private void uploadLogs(String[] params, String[] values) + static void uploadLogs( + String uploadLocation, + String fileName, + String[] params, + String[] values) { try { File tempDir = LoggingUtilsActivator.getFileAccessService() .getTemporaryDirectory(); - File newDest = new File( - tempDir, LogsCollector.getDefaultFileName()); + File newDest = new File(tempDir, fileName); File optionalFile = null; @@ -685,8 +694,6 @@ public class LoggingConfigForm if(optionalFile != null) optionalFile.delete(); - String uploadLocation = getUploadLocation(); - if(uploadLocation == null) return; diff --git a/src/net/java/sip/communicator/plugin/loggingutils/LoggingUtilsActivator.java b/src/net/java/sip/communicator/plugin/loggingutils/LoggingUtilsActivator.java index f7e0ef5..d0a1449 100644 --- a/src/net/java/sip/communicator/plugin/loggingutils/LoggingUtilsActivator.java +++ b/src/net/java/sip/communicator/plugin/loggingutils/LoggingUtilsActivator.java @@ -34,7 +34,7 @@ public class LoggingUtilsActivator /** * The OSGI bundle context. */ - private static BundleContext bundleContext = null; + static BundleContext bundleContext = null; /** * The resource service. |