diff options
3 files changed, 9 insertions, 12 deletions
diff --git a/src/net/java/sip/communicator/impl/protocol/irc/IrcStack.java b/src/net/java/sip/communicator/impl/protocol/irc/IrcStack.java index 308e403..775516c 100644 --- a/src/net/java/sip/communicator/impl/protocol/irc/IrcStack.java +++ b/src/net/java/sip/communicator/impl/protocol/irc/IrcStack.java @@ -1296,11 +1296,6 @@ public class IrcStack @Override public void onUserNotice(final UserNotice msg) { - // TODO Probably better to deliver NOTICEs to all channels, instead - // of setting up private chat. You are not supposed to reply to - // NOTICEs and setting up a private chat session kind of does that. - // Even though the user should respond themslves in the default - // Jitsi set up. final String user = msg.getSource().getNick(); final String text = Utils.styleAsNotice(Utils.parseIrcMessage(msg.getText()), user); @@ -1361,11 +1356,12 @@ public class IrcStack return; } - // FIXME Re-enabled/Disabled user presence status updates, probably + // TODO Implement notion of Presence for IRC. + // Re-enabled/Disabled user presence status updates, probably // not going to do user presence, since we cannot detect all changes // and Jitsi does act upon different presence statuses. - // FIXME Off-line contact still gets sent a message. Is this desired + // Off-line contact still gets sent a message. Is this desired // behavior? // final String userNick = msg.getSource().getNick(); @@ -1402,10 +1398,10 @@ public class IrcStack // .fireContactPresenceStatusChangeEvent(user, parentGroup, // previousStatus, member.getPresenceStatus(), true); - // TODO Update status to online in case a message arrives from this + // Update status to online in case a message arrives from this // particular user. - // TODO What happens if user is thought to be offline (so presence + // What happens if user is thought to be offline (so presence // set this way) and it turns out the user is online? Can we send it // a message then? (Or would Jitsi block this, because there is no // support for off-line messaging.) diff --git a/src/net/java/sip/communicator/impl/protocol/irc/OperationSetMultiUserChatIrcImpl.java b/src/net/java/sip/communicator/impl/protocol/irc/OperationSetMultiUserChatIrcImpl.java index a69aac0..6e19de2 100644 --- a/src/net/java/sip/communicator/impl/protocol/irc/OperationSetMultiUserChatIrcImpl.java +++ b/src/net/java/sip/communicator/impl/protocol/irc/OperationSetMultiUserChatIrcImpl.java @@ -210,7 +210,9 @@ public class OperationSetMultiUserChatIrcImpl } /** - * Informs the sender of an invitation that we decline their invitation. + * There is no such thing as a rejection to an invitatation. The notion of + * an invite in IRC is just an addition to a white list. There is nothing to + * reject. * * @param invitation the invitation we are rejecting. * @param reason the reason of rejecting @@ -218,7 +220,6 @@ public class OperationSetMultiUserChatIrcImpl public void rejectInvitation(final ChatRoomInvitation invitation, final String reason) { - //TODO Implement reject invitation. } /** diff --git a/src/net/java/sip/communicator/impl/protocol/irc/OperationSetPersistentPresenceIrcImpl.java b/src/net/java/sip/communicator/impl/protocol/irc/OperationSetPersistentPresenceIrcImpl.java index f5a6272..89729f4 100644 --- a/src/net/java/sip/communicator/impl/protocol/irc/OperationSetPersistentPresenceIrcImpl.java +++ b/src/net/java/sip/communicator/impl/protocol/irc/OperationSetPersistentPresenceIrcImpl.java @@ -264,7 +264,7 @@ public class OperationSetPersistentPresenceIrcImpl { LOGGER.warn("Unresolved contactgroup: " + groupUID + " " + persistentData + " parent: " + parentGroup.getGroupName()); - // TODO implement createUnresolvedContactGroup + // FIXME implement createUnresolvedContactGroup return null; } |