aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJan Sembera <jsembera@suse.cz>2008-12-09 15:48:32 -0800
committerDavid S. Miller <davem@davemloft.net>2008-12-09 15:48:32 -0800
commit24fc7b86dc0470616803be2f921c8cd5c459175d (patch)
tree0bcb5ae6211c642eb2f8a6e150243ac7c44da1eb
parentfbf0229e946deb9e6c711f9eaa5c8d670c3a28fd (diff)
downloadkernel_samsung_smdk4412-24fc7b86dc0470616803be2f921c8cd5c459175d.zip
kernel_samsung_smdk4412-24fc7b86dc0470616803be2f921c8cd5c459175d.tar.gz
kernel_samsung_smdk4412-24fc7b86dc0470616803be2f921c8cd5c459175d.tar.bz2
ipv6: silence log messages for locally generated multicast
This patch fixes minor annoyance during transmission of unsolicited neighbor advertisements from userspace to multicast addresses (as far as I can see in RFC, this is allowed and the similar functionality for IPv4 has been in arping for a long time). Outgoing multicast packets get reinserted into local processing as if they are received from the network. The machine thus sees its own NA and fills the logs with error messages. This patch removes the message if NA has been generated locally. Signed-off-by: Jan Sembera <jsembera@suse.cz> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/ipv6/ndisc.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
index 1724383..d0f54d1 100644
--- a/net/ipv6/ndisc.c
+++ b/net/ipv6/ndisc.c
@@ -912,8 +912,13 @@ static void ndisc_recv_na(struct sk_buff *skb)
is invalid, but ndisc specs say nothing
about it. It could be misconfiguration, or
an smart proxy agent tries to help us :-)
+
+ We should not print the error if NA has been
+ received from loopback - it is just our own
+ unsolicited advertisement.
*/
- ND_PRINTK1(KERN_WARNING
+ if (skb->pkt_type != PACKET_LOOPBACK)
+ ND_PRINTK1(KERN_WARNING
"ICMPv6 NA: someone advertises our address on %s!\n",
ifp->idev->dev->name);
in6_ifa_put(ifp);