aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Carpenter <error27@gmail.com>2010-11-13 11:24:22 +0300
committerGreg Kroah-Hartman <gregkh@suse.de>2010-11-16 12:31:50 -0800
commit2e3161390130f50fdbb4b989c667f42e5008107f (patch)
tree70ba420f8ca3627173848cf99ca4e07465846a33
parentf05321cca53da7c7abad4bc726699e9f27bf4922 (diff)
downloadkernel_samsung_smdk4412-2e3161390130f50fdbb4b989c667f42e5008107f.zip
kernel_samsung_smdk4412-2e3161390130f50fdbb4b989c667f42e5008107f.tar.gz
kernel_samsung_smdk4412-2e3161390130f50fdbb4b989c667f42e5008107f.tar.bz2
Staging: bcm: signedness bug in InitCardAndDownloadFirmware()
status is used to store negative error codes throughout. The only place where this is a runtime bug is if create_worker_threads() fails. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--drivers/staging/bcm/Misc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/bcm/Misc.c b/drivers/staging/bcm/Misc.c
index 023c511..9588fbe 100644
--- a/drivers/staging/bcm/Misc.c
+++ b/drivers/staging/bcm/Misc.c
@@ -1079,7 +1079,7 @@ int run_card_proc(PMINI_ADAPTER ps_adapter )
int InitCardAndDownloadFirmware(PMINI_ADAPTER ps_adapter)
{
- UINT status = STATUS_SUCCESS;
+ int status;
UINT value = 0;
/*
* Create the threads first and then download the