aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGuy Cohen <guy.cohen@intel.com>2008-09-09 10:54:53 +0800
committerJohn W. Linville <linville@tuxdriver.com>2008-09-11 15:53:39 -0400
commit90d7795e152f9b7095adef77b71a4448f092e3b6 (patch)
treec7c92298411edd5c42b01eb564a5a0711709285d
parent12e5e22d38577a5a16dd47e7144722817a55e52e (diff)
downloadkernel_samsung_smdk4412-90d7795e152f9b7095adef77b71a4448f092e3b6.zip
kernel_samsung_smdk4412-90d7795e152f9b7095adef77b71a4448f092e3b6.tar.gz
kernel_samsung_smdk4412-90d7795e152f9b7095adef77b71a4448f092e3b6.tar.bz2
iwlwifi: fix searching for best rate in new search column
This patch fixes a bug in Rate Scaling. When moving from SISO to MIMO we need to choose the lowest higher rate, instead of choosing the highest in MIMO. No doing this can lead to a high packet loss in the highest rate in MIMO, leading not to move MIMO although lower in MIMO could give a better TPT. Signed-off-by: Guy Cohen <guy.cohen@intel.com> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com> Signed-off-by: Zhu Yi <yi.zhu@intel.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
-rw-r--r--drivers/net/wireless/iwlwifi/iwl-agn-rs.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-rs.c b/drivers/net/wireless/iwlwifi/iwl-agn-rs.c
index 4fc3a0f..de00be1 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn-rs.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn-rs.c
@@ -436,7 +436,7 @@ static int rs_collect_tx_data(struct iwl_rate_scale_data *windows,
/* Shift bitmap by one frame (throw away oldest history),
* OR in "1", and increment "success" if this
* frame was successful. */
- window->data <<= 1;;
+ window->data <<= 1;
if (successes > 0) {
window->success_counter++;
window->data |= 0x1;
@@ -1128,6 +1128,7 @@ static s32 rs_get_best_rate(struct iwl_priv *priv,
/* Higher rate not available, use the original */
} else {
+ new_rate = rate;
break;
}
}