diff options
| author | Devin Heitmueller <dheitmueller@kernellabs.com> | 2009-10-15 01:14:34 -0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2009-11-07 12:55:08 -0200 |
| commit | 96fbf771d86a90ff006bc62ca4d4de6474b3de31 (patch) | |
| tree | 814208369b0861b61be34ccb44ada1ec52998dc2 | |
| parent | 2de26c0a4a218a351bb1970eeaddf2905b47ff13 (diff) | |
| download | kernel_samsung_smdk4412-96fbf771d86a90ff006bc62ca4d4de6474b3de31.zip kernel_samsung_smdk4412-96fbf771d86a90ff006bc62ca4d4de6474b3de31.tar.gz kernel_samsung_smdk4412-96fbf771d86a90ff006bc62ca4d4de6474b3de31.tar.bz2 | |
V4L/DVB (13190): em28xx: fix panic that can occur when starting audio streaming
Because the counters were not reset when starting up streaming, they would
be reused from the previous run. This can result in cases such that when the
second instance of streaming starts up, the "cnt" variable in
em28xx_audio_isocirq() can end up being negative, resulting in attempting to
write to memory before the start of runtime->dma_area (as well as having a
negative number of bytes to copy).
Signed-off-by: Devin Heitmueller <dheitmueller@kernellabs.com>
CC: stable@kernel.org
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
| -rw-r--r-- | drivers/media/video/em28xx/em28xx-audio.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/media/video/em28xx/em28xx-audio.c b/drivers/media/video/em28xx/em28xx-audio.c index 7bd8a70..ac947ae 100644 --- a/drivers/media/video/em28xx/em28xx-audio.c +++ b/drivers/media/video/em28xx/em28xx-audio.c @@ -383,6 +383,11 @@ static int snd_em28xx_hw_capture_free(struct snd_pcm_substream *substream) static int snd_em28xx_prepare(struct snd_pcm_substream *substream) { + struct em28xx *dev = snd_pcm_substream_chip(substream); + + dev->adev.hwptr_done_capture = 0; + dev->adev.capture_transfer_done = 0; + return 0; } |