diff options
| author | Michael S. Tsirkin <mst@redhat.com> | 2015-01-04 17:28:27 +0200 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2015-02-20 00:49:34 +0000 |
| commit | c578662ec973f2cdc5e7a81f9fec1bfb45440342 (patch) | |
| tree | 36c2456f8d7b24ac1f0bc7fe1197482a068b1634 | |
| parent | 119d5897cc5f9f73e352a1c647d21b9d506b8c0a (diff) | |
| download | kernel_samsung_smdk4412-c578662ec973f2cdc5e7a81f9fec1bfb45440342.zip kernel_samsung_smdk4412-c578662ec973f2cdc5e7a81f9fec1bfb45440342.tar.gz kernel_samsung_smdk4412-c578662ec973f2cdc5e7a81f9fec1bfb45440342.tar.bz2 | |
virtio_pci: document why we defer kfree
commit a1eb03f546d651a8f39c7d0692b1f7f5b4e7e3cd upstream.
The reason we defer kfree until release function is because it's a
general rule for kobjects: kfree of the reference counter itself is only
legal in the release function.
Previous patch didn't make this clear, document this in code.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
[bwh: Backported to 3.2: adjust filename]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
| -rw-r--r-- | drivers/virtio/virtio_pci.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c index 65c907d..13f6cd8 100644 --- a/drivers/virtio/virtio_pci.c +++ b/drivers/virtio/virtio_pci.c @@ -615,6 +615,9 @@ static void virtio_pci_release_dev(struct device *_d) struct virtio_device *vdev = dev_to_virtio(_d); struct virtio_pci_device *vp_dev = to_vp_device(vdev); + /* As struct device is a kobject, it's not safe to + * free the memory (including the reference counter itself) + * until it's release callback. */ kfree(vp_dev); } |