diff options
| author | Julia Lawall <julia@diku.dk> | 2010-08-28 12:41:05 -0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2010-10-21 01:04:53 -0200 |
| commit | f78729b40a01a72b189a0618e1cf58facb68c129 (patch) | |
| tree | bf3de8a2f7102500566eb0f49c90940c3bd0662f | |
| parent | 6b81bef8cde141d8d8172a35633af27e17cf487a (diff) | |
| download | kernel_samsung_smdk4412-f78729b40a01a72b189a0618e1cf58facb68c129.zip kernel_samsung_smdk4412-f78729b40a01a72b189a0618e1cf58facb68c129.tar.gz kernel_samsung_smdk4412-f78729b40a01a72b189a0618e1cf58facb68c129.tar.bz2 | |
V4L/DVB: drivers/media/dvb/siano: Remove double test
The same expression is tested twice and the result is the same each time.
The sematic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@expression@
expression E;
@@
(
* E
|| ... || E
|
* E
&& ... && E
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
| -rw-r--r-- | drivers/media/dvb/siano/smscoreapi.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/media/dvb/siano/smscoreapi.c b/drivers/media/dvb/siano/smscoreapi.c index ff3b0fa..135e45b 100644 --- a/drivers/media/dvb/siano/smscoreapi.c +++ b/drivers/media/dvb/siano/smscoreapi.c @@ -1504,8 +1504,7 @@ int smscore_gpio_set_level(struct smscore_device_t *coredev, u8 PinNum, u32 msgData[3]; /* keep it 3 ! */ } *pMsg; - if ((NewLevel > 1) || (PinNum > MAX_GPIO_PIN_NUMBER) || - (PinNum > MAX_GPIO_PIN_NUMBER)) + if ((NewLevel > 1) || (PinNum > MAX_GPIO_PIN_NUMBER)) return -EINVAL; totalLen = sizeof(struct SmsMsgHdr_ST) + |