diff options
author | yonghua zheng <younghua.zheng@gmail.com> | 2013-08-13 16:01:03 -0700 |
---|---|---|
committer | Ben Hutchings <ben@decadent.org.uk> | 2013-09-10 01:57:23 +0100 |
commit | bd20948dc24c3a1cf5ea18385943783f11c2c751 (patch) | |
tree | d923ca4e6741961b6c94709517162528d9ce7be8 /arch/m68k | |
parent | 1cf253ee0a4a3102a1dc89a3001abb31a8b60c00 (diff) | |
download | kernel_samsung_smdk4412-bd20948dc24c3a1cf5ea18385943783f11c2c751.zip kernel_samsung_smdk4412-bd20948dc24c3a1cf5ea18385943783f11c2c751.tar.gz kernel_samsung_smdk4412-bd20948dc24c3a1cf5ea18385943783f11c2c751.tar.bz2 |
fs/proc/task_mmu.c: fix buffer overflow in add_page_map()
commit 8c8296223f3abb142be8fc31711b18a704c0e7d8 upstream.
Recently we met quite a lot of random kernel panic issues after enabling
CONFIG_PROC_PAGE_MONITOR. After debuggind we found this has something
to do with following bug in pagemap:
In struct pagemapread:
struct pagemapread {
int pos, len;
pagemap_entry_t *buffer;
bool v2;
};
pos is number of PM_ENTRY_BYTES in buffer, but len is the size of
buffer, it is a mistake to compare pos and len in add_page_map() for
checking buffer is full or not, and this can lead to buffer overflow and
random kernel panic issue.
Correct len to be total number of PM_ENTRY_BYTES in buffer.
[akpm@linux-foundation.org: document pagemapread.pos and .len units, fix PM_ENTRY_BYTES definition]
Signed-off-by: Yonghua Zheng <younghua.zheng@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
[bwh: Backported to 3.2:
- Adjust context
- There is no pagemap_entry_t definition; keep using u64]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'arch/m68k')
0 files changed, 0 insertions, 0 deletions