diff options
| author | Marcin Slusarz <marcin.slusarz@gmail.com> | 2011-09-09 14:16:42 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-11-21 14:31:16 -0800 |
| commit | 53b6b123d40eda9bde41232b2c76d0e1e896b83d (patch) | |
| tree | 4056b1b4436e459460d92af85ab092ec0c38ab60 /drivers/gpu/drm/radeon/atombios_dp.c | |
| parent | 1db61fd3401a6520375293de302b3a9034edca1b (diff) | |
| download | kernel_samsung_smdk4412-53b6b123d40eda9bde41232b2c76d0e1e896b83d.zip kernel_samsung_smdk4412-53b6b123d40eda9bde41232b2c76d0e1e896b83d.tar.gz kernel_samsung_smdk4412-53b6b123d40eda9bde41232b2c76d0e1e896b83d.tar.bz2 | |
drm/nouveau: initialize chan->fence.lock before use
commit 5e60ee780e792efe6dce97eceb110b1d30bab850 upstream.
Fence lock needs to be initialized before any call to nouveau_channel_put
because it calls nouveau_channel_idle->nouveau_fence_update which uses
fence lock.
BUG: spinlock bad magic on CPU#0, test/24134
lock: ffff88019f90dba8, .magic: 00000000, .owner: <none>/-1, .owner_cpu: 0
Pid: 24134, comm: test Not tainted 3.0.0-nv+ #800
Call Trace:
spin_bug+0x9c/0xa3
do_raw_spin_lock+0x29/0x13c
_raw_spin_lock+0x1e/0x22
nouveau_fence_update+0x2d/0xf1
nouveau_channel_idle+0x22/0xa0
nouveau_channel_put_unlocked+0x84/0x1bd
nouveau_channel_put+0x20/0x24
nouveau_channel_alloc+0x4ec/0x585
nouveau_ioctl_fifo_alloc+0x50/0x130
drm_ioctl+0x289/0x361
do_vfs_ioctl+0x4dd/0x52c
sys_ioctl+0x42/0x65
system_call_fastpath+0x16/0x1b
It's easily triggerable from userspace.
Additionally remove double initialization of chan->fence.pending.
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/gpu/drm/radeon/atombios_dp.c')
0 files changed, 0 insertions, 0 deletions