diff options
| author | Michael S. Tsirkin <mst@dev.mellanox.co.il> | 2007-05-28 14:37:27 +0300 |
|---|---|---|
| committer | Roland Dreier <rolandd@cisco.com> | 2007-05-29 16:07:09 -0700 |
| commit | ec56dc0b7f6c3fec20bbc2e98ff1a06edf2fc9b9 (patch) | |
| tree | 3bb5379d1bc2cd42526fe3d97b728f0d743bca30 /drivers/infiniband/ulp/ipoib/ipoib.h | |
| parent | 8b7e15772a286d0ef8e4f8eca422ce5368b6fa97 (diff) | |
| download | kernel_samsung_smdk4412-ec56dc0b7f6c3fec20bbc2e98ff1a06edf2fc9b9.zip kernel_samsung_smdk4412-ec56dc0b7f6c3fec20bbc2e98ff1a06edf2fc9b9.tar.gz kernel_samsung_smdk4412-ec56dc0b7f6c3fec20bbc2e98ff1a06edf2fc9b9.tar.bz2 | |
IPoIB/cm: Fix performance regression on Mellanox
commit 518b1646 ("IPoIB/cm: Fix SRQ WR leak") introduced a severe
performance regression on Mellanox cards, because keeping a QP in the
error state for extended periods of time moves hardware to the slow
path (until the QP is destroyed). For example, MPI latency goes from
~3 usecs to ~7 usecs.
Fix this by posting a send WR on one of the QPs that are being
flushed, instead of using a separate drain QP that is kept in the
error state.
This fixes bug <https://bugs.openfabrics.org/show_bug.cgi?id=636>,
reported and bisected by Scott Weitzenkamp at Cisco and debugged by
Sasha Mikheev at Voltaire.
Signed-off-by: Michael S. Tsirkin <mst@dev.mellanox.co.il>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
Diffstat (limited to 'drivers/infiniband/ulp/ipoib/ipoib.h')
| -rw-r--r-- | drivers/infiniband/ulp/ipoib/ipoib.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/infiniband/ulp/ipoib/ipoib.h b/drivers/infiniband/ulp/ipoib/ipoib.h index 158759e..285c143 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib.h +++ b/drivers/infiniband/ulp/ipoib/ipoib.h @@ -156,7 +156,7 @@ struct ipoib_cm_data { * - and then invoke a Destroy QP or Reset QP. * * We use the second option and wait for a completion on the - * rx_drain_qp before destroying QPs attached to our SRQ. + * same CQ before destroying QPs attached to our SRQ. */ enum ipoib_cm_state { @@ -199,7 +199,6 @@ struct ipoib_cm_dev_priv { struct ib_srq *srq; struct ipoib_cm_rx_buf *srq_ring; struct ib_cm_id *id; - struct ib_qp *rx_drain_qp; /* generates WR described in 10.3.1 */ struct list_head passive_ids; /* state: LIVE */ struct list_head rx_error_list; /* state: ERROR */ struct list_head rx_flush_list; /* state: FLUSH, drain not started */ |