diff options
| author | Erik Andrén <erik.andren@gmail.com> | 2009-01-28 04:02:49 -0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2009-06-16 18:20:49 -0300 |
| commit | 52fa70b7f448da8b763e8c2f566d309d7399a20b (patch) | |
| tree | daa88a9e7a42105677f18ac0c1c878baa0ddf711 /drivers/media/video/gspca/m5602/m5602_core.c | |
| parent | 934f78c3069943cf0654a6f809adf0375b078c38 (diff) | |
| download | kernel_samsung_smdk4412-52fa70b7f448da8b763e8c2f566d309d7399a20b.zip kernel_samsung_smdk4412-52fa70b7f448da8b763e8c2f566d309d7399a20b.tar.gz kernel_samsung_smdk4412-52fa70b7f448da8b763e8c2f566d309d7399a20b.tar.bz2 | |
V4L/DVB (11648): gspca - m5602: Remove some needless error checking and add comments
Signed-off-by: Erik Andrén <erik.andren@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/video/gspca/m5602/m5602_core.c')
| -rw-r--r-- | drivers/media/video/gspca/m5602/m5602_core.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/drivers/media/video/gspca/m5602/m5602_core.c b/drivers/media/video/gspca/m5602/m5602_core.c index ca77dab..8ca5643 100644 --- a/drivers/media/video/gspca/m5602/m5602_core.c +++ b/drivers/media/video/gspca/m5602/m5602_core.c @@ -112,18 +112,16 @@ int m5602_read_sensor(struct sd *sd, const u8 address, if (err < 0) return err; + /* Sensors with registers that only are one byte width are differently read */ + /* FIXME: This works with the ov9650, but has issues with the po1030 */ if (sd->sensor->i2c_regW == 1) { - err = m5602_write_bridge(sd, M5602_XB_I2C_CTRL, len); + err = m5602_write_bridge(sd, M5602_XB_I2C_CTRL, 1); if (err < 0) return err; err = m5602_write_bridge(sd, M5602_XB_I2C_CTRL, 0x08); - if (err < 0) - return err; } else { err = m5602_write_bridge(sd, M5602_XB_I2C_CTRL, 0x18 + len); - if (err < 0) - return err; } for (i = 0; (i < len) && !err; i++) { |