aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/wireless/mwifiex/cmdevt.c
diff options
context:
space:
mode:
authorChristoph Fritz <chf.fritz@googlemail.com>2011-05-08 22:50:09 +0200
committerJohn W. Linville <linville@tuxdriver.com>2011-05-10 15:54:50 -0400
commitb53575ecf939a4f752de87eabf1adbcfa4478a6c (patch)
tree0e98918a3602d0abd1ff6bcc5dea9cef0763c99d /drivers/net/wireless/mwifiex/cmdevt.c
parent3ed3f49473985718ce51f84d990ed5b8b6472598 (diff)
downloadkernel_samsung_smdk4412-b53575ecf939a4f752de87eabf1adbcfa4478a6c.zip
kernel_samsung_smdk4412-b53575ecf939a4f752de87eabf1adbcfa4478a6c.tar.gz
kernel_samsung_smdk4412-b53575ecf939a4f752de87eabf1adbcfa4478a6c.tar.bz2
mwifiex: fix null derefs, mem leaks and trivia
This patch: - adds kfree() where necessary - prevents potential null dereferences - makes use of kfree_skb() - replaces -1 for failed kzallocs with -ENOMEM Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com> Reviewed-by: Kiran Divekar <dkiran@marvell.com> Tested-by: Amitkumar Karwar <akarwar@marvell.com> Acked-by: Bing Zhao <bzhao@marvell.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/mwifiex/cmdevt.c')
-rw-r--r--drivers/net/wireless/mwifiex/cmdevt.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wireless/mwifiex/cmdevt.c b/drivers/net/wireless/mwifiex/cmdevt.c
index b75cc92..1c8b4f7 100644
--- a/drivers/net/wireless/mwifiex/cmdevt.c
+++ b/drivers/net/wireless/mwifiex/cmdevt.c
@@ -292,7 +292,7 @@ int mwifiex_alloc_cmd_buffer(struct mwifiex_adapter *adapter)
if (!cmd_array) {
dev_err(adapter->dev, "%s: failed to alloc cmd_array\n",
__func__);
- return -1;
+ return -ENOMEM;
}
adapter->cmd_pool = cmd_array;