diff options
author | Trond Myklebust <Trond.Myklebust@netapp.com> | 2013-01-07 14:30:46 -0500 |
---|---|---|
committer | Ben Hutchings <ben@decadent.org.uk> | 2013-02-06 04:33:27 +0000 |
commit | 88d6d79b6a8f4469311a0b55098c98ea15ccbc94 (patch) | |
tree | b59cd497e642d428610029a1ae55a8ff4aed66a5 /drivers/target | |
parent | 96908901a62457cdb9272d6658cd9903ac824115 (diff) | |
download | kernel_samsung_smdk4412-88d6d79b6a8f4469311a0b55098c98ea15ccbc94.zip kernel_samsung_smdk4412-88d6d79b6a8f4469311a0b55098c98ea15ccbc94.tar.gz kernel_samsung_smdk4412-88d6d79b6a8f4469311a0b55098c98ea15ccbc94.tar.bz2 |
SUNRPC: Ensure we release the socket write lock if the rpc_task exits early
commit 87ed50036b866db2ec2ba16b2a7aec4a2b0b7c39 upstream.
If the rpc_task exits while holding the socket write lock before it has
allocated an rpc slot, then the usual mechanism for releasing the write
lock in xprt_release() is defeated.
The problem occurs if the call to xprt_lock_write() initially fails, so
that the rpc_task is put on the xprt->sending wait queue. If the task
exits after being assigned the lock by __xprt_lock_write_func, but
before it has retried the call to xprt_lock_and_alloc_slot(), then
it calls xprt_release() while holding the write lock, but will
immediately exit due to the test for task->tk_rqstp != NULL.
Reported-by: Chris Perl <chris.perl@gmail.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'drivers/target')
0 files changed, 0 insertions, 0 deletions