diff options
author | Eric Dumazet <eric.dumazet@gmail.com> | 2009-10-02 10:32:18 +0000 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-10-07 01:07:42 -0700 |
commit | d250a5f90e53f5e150618186230795352d154c88 (patch) | |
tree | 1c95ec673ce613f346db300d3f5539f018066081 /net/core/ethtool.c | |
parent | 92d326f61b553250780786e9dd8609d4b32f8de7 (diff) | |
download | kernel_samsung_smdk4412-d250a5f90e53f5e150618186230795352d154c88.zip kernel_samsung_smdk4412-d250a5f90e53f5e150618186230795352d154c88.tar.gz kernel_samsung_smdk4412-d250a5f90e53f5e150618186230795352d154c88.tar.bz2 |
pkt_sched: gen_estimator: Dont report fake rate estimators
Jarek Poplawski a écrit :
>
>
> Hmm... So you made me to do some "real" work here, and guess what?:
> there is one serious checkpatch warning! ;-) Plus, this new parameter
> should be added to the function description. Otherwise:
> Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
>
> Thanks,
> Jarek P.
>
> PS: I guess full "Don't" would show we really mean it...
Okay :) Here is the last round, before the night !
Thanks again
[RFC] pkt_sched: gen_estimator: Don't report fake rate estimators
We currently send TCA_STATS_RATE_EST elements to netlink users, even if no estimator
is running.
# tc -s -d qdisc
qdisc pfifo_fast 0: dev eth0 root bands 3 priomap 1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1
Sent 112833764978 bytes 1495081739 pkt (dropped 0, overlimits 0 requeues 0)
rate 0bit 0pps backlog 0b 0p requeues 0
User has no way to tell if the "rate 0bit 0pps" is a real estimation, or a fake
one (because no estimator is active)
After this patch, tc command output is :
$ tc -s -d qdisc
qdisc pfifo_fast 0: dev eth0 root bands 3 priomap 1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1
Sent 561075 bytes 1196 pkt (dropped 0, overlimits 0 requeues 0)
backlog 0b 0p requeues 0
We add a parameter to gnet_stats_copy_rate_est() function so that
it can use gen_estimator_active(bstats, r), as suggested by Jarek.
This parameter can be NULL if check is not necessary, (htb for
example has a mandatory rate estimator)
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core/ethtool.c')
0 files changed, 0 insertions, 0 deletions