diff options
| author | David S. Miller <davem@davemloft.net> | 2015-05-01 22:02:47 -0400 |
|---|---|---|
| committer | Wolfgang Wiedmeyer <wolfgit@wiedmeyer.de> | 2015-10-18 20:53:02 +0200 |
| commit | a39819e88ea4546218b581d7f061a99ca91d825b (patch) | |
| tree | 48ea3c0b2316fe276af7b93291c074c7836e43fc /net | |
| parent | 4c52bc8a2ff3c0373d371995eaef34df98e1fa4c (diff) | |
| download | kernel_samsung_smdk4412-a39819e88ea4546218b581d7f061a99ca91d825b.zip kernel_samsung_smdk4412-a39819e88ea4546218b581d7f061a99ca91d825b.tar.gz kernel_samsung_smdk4412-a39819e88ea4546218b581d7f061a99ca91d825b.tar.bz2 | |
ipv4: Missing sk_nulls_node_init() in ping_unhash().
If we don't do that, then the poison value is left in the ->pprev
backlink.
This can cause crashes if we do a disconnect, followed by a connect().
Tested-by: Linus Torvalds <torvalds@linux-foundation.org>
Reported-by: Wen Xu <hotdog3645@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Tested-by: Wolfgang Wiedmeyer <wolfgit@wiedmeyer.de>
Diffstat (limited to 'net')
| -rw-r--r-- | net/ipv4/ping.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c index 39b403f..46f8f3f 100644 --- a/net/ipv4/ping.c +++ b/net/ipv4/ping.c @@ -138,6 +138,7 @@ static void ping_v4_unhash(struct sock *sk) if (sk_hashed(sk)) { write_lock_bh(&ping_table.lock); hlist_nulls_del(&sk->sk_nulls_node); + sk_nulls_node_init(&sk->sk_nulls_node); sock_put(sk); isk->inet_num = isk->inet_sport = 0; sock_prot_inuse_add(sock_net(sk), sk->sk_prot, -1); |