diff options
| author | Raymond Hill <rhill@raymondhill.net> | 2014-12-06 15:00:31 -0200 |
|---|---|---|
| committer | Raymond Hill <rhill@raymondhill.net> | 2014-12-06 15:00:31 -0200 |
| commit | 0501c0712ac968b17bf072de161e5573c0861c86 (patch) | |
| tree | bd05632f3b049cbd99640b3897ebee62105b1d0f | |
| parent | 665c05c0a3ffe92933eeffef70b033028fed48f9 (diff) | |
| download | uBlock-0501c0712ac968b17bf072de161e5573c0861c86.zip uBlock-0501c0712ac968b17bf072de161e5573c0861c86.tar.gz uBlock-0501c0712ac968b17bf072de161e5573c0861c86.tar.bz2 | |
this fixes #399
| -rw-r--r-- | src/js/contentscript-end.js | 16 |
1 files changed, 6 insertions, 10 deletions
diff --git a/src/js/contentscript-end.js b/src/js/contentscript-end.js index 4cd84bc..25c6200 100644 --- a/src/js/contentscript-end.js +++ b/src/js/contentscript-end.js @@ -501,11 +501,9 @@ var messager = vAPI.messaging.channel('contentscript-end.js'); // If `!important` is not there, going back using history will // likely cause the hidden element to re-appear. if ( details.collapse ) { - if ( target.parentNode ) { - target.parentNode.removeChild(target); - } else { - target.style.setProperty('display', 'none', 'important'); - } + // https://github.com/gorhill/uBlock/issues/399 + // Never remove elements from the DOM, just hide them + target.style.setProperty('display', 'none', 'important'); } else { target.style.setProperty('visibility', 'hidden', 'important'); } @@ -570,11 +568,9 @@ var messager = vAPI.messaging.channel('contentscript-end.js'); request = requests[i]; elem = elements[request.index]; if ( collapse ) { - if ( elem.parentNode ) { - elem.parentNode.removeChild(elem); - } else { - elem.style.setProperty('display', 'none', 'important'); - } + // https://github.com/gorhill/uBlock/issues/399 + // Never remove elements from the DOM, just hide them + elem.style.setProperty('display', 'none', 'important'); } else { elem.style.setProperty('visibility', 'hidden', 'important'); } |