diff options
author | afakhry <afakhry@chromium.org> | 2014-12-09 16:19:28 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-12-10 00:19:56 +0000 |
commit | 8a7b35a069e1133fa3d51fb344b750a90bd21f5d (patch) | |
tree | 1487b9bea4d6b1b6cf2f50c4f23b4589396d5c6c /ash/wm | |
parent | 4ae97b7b61308ab58413c135b4ed70955b698335 (diff) | |
download | chromium_src-8a7b35a069e1133fa3d51fb344b750a90bd21f5d.zip chromium_src-8a7b35a069e1133fa3d51fb344b750a90bd21f5d.tar.gz chromium_src-8a7b35a069e1133fa3d51fb344b750a90bd21f5d.tar.bz2 |
Cleaning up MruWindowTracker::BuildWindowList()
Removing the top_most_at_end parameter which was always set to false and
was never used.
The previous CL (https://codereview.chromium.org/752253002) was reverted as it caused ash_unittests to fail on Windows:
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(dbg)(1)
http://build.chromium.org/p/chromium.win/builders/Win8%20Aura
This is a retry, but we keep reversing the windows list after we build it.
R=oshima@chromium.org
BUG=None
Review URL: https://codereview.chromium.org/785273002
Cr-Commit-Position: refs/heads/master@{#307593}
Diffstat (limited to 'ash/wm')
-rw-r--r-- | ash/wm/maximize_mode/maximize_mode_window_manager.cc | 3 | ||||
-rw-r--r-- | ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc | 9 | ||||
-rw-r--r-- | ash/wm/mru_window_tracker.cc | 15 | ||||
-rw-r--r-- | ash/wm/mru_window_tracker.h | 7 | ||||
-rw-r--r-- | ash/wm/window_positioner.cc | 4 |
5 files changed, 14 insertions, 24 deletions
diff --git a/ash/wm/maximize_mode/maximize_mode_window_manager.cc b/ash/wm/maximize_mode/maximize_mode_window_manager.cc index 6b7fc36..7506bee 100644 --- a/ash/wm/maximize_mode/maximize_mode_window_manager.cc +++ b/ash/wm/maximize_mode/maximize_mode_window_manager.cc @@ -182,8 +182,7 @@ MaximizeModeWindowManager::MaximizeModeWindowManager() } void MaximizeModeWindowManager::MaximizeAllWindows() { - MruWindowTracker::WindowList windows = - MruWindowTracker::BuildWindowList(false); + MruWindowTracker::WindowList windows = MruWindowTracker::BuildWindowList(); // Add all existing Mru windows. for (MruWindowTracker::WindowList::iterator window = windows.begin(); window != windows.end(); ++window) { diff --git a/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc b/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc index 534108a..d2e06a1 100644 --- a/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc +++ b/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc @@ -679,8 +679,7 @@ TEST_F(MaximizeModeWindowManagerTest, ModeChangeKeepsMRUOrder) { // The windows should be in the reverse order of creation in the MRU list. { - MruWindowTracker::WindowList windows = - MruWindowTracker::BuildWindowList(false); + MruWindowTracker::WindowList windows = MruWindowTracker::BuildWindowList(); EXPECT_EQ(w1.get(), windows[4]); EXPECT_EQ(w2.get(), windows[3]); EXPECT_EQ(w3.get(), windows[2]); @@ -693,8 +692,7 @@ TEST_F(MaximizeModeWindowManagerTest, ModeChangeKeepsMRUOrder) { ASSERT_TRUE(manager); EXPECT_EQ(5, manager->GetNumberOfManagedWindows()); { - MruWindowTracker::WindowList windows = - MruWindowTracker::BuildWindowList(false); + MruWindowTracker::WindowList windows = MruWindowTracker::BuildWindowList(); // We do not test maximization here again since that was done already. EXPECT_EQ(w1.get(), windows[4]); EXPECT_EQ(w2.get(), windows[3]); @@ -706,8 +704,7 @@ TEST_F(MaximizeModeWindowManagerTest, ModeChangeKeepsMRUOrder) { // Destroying should still keep the order. DestroyMaximizeModeWindowManager(); { - MruWindowTracker::WindowList windows = - MruWindowTracker::BuildWindowList(false); + MruWindowTracker::WindowList windows = MruWindowTracker::BuildWindowList(); // We do not test maximization here again since that was done already. EXPECT_EQ(w1.get(), windows[4]); EXPECT_EQ(w2.get(), windows[3]); diff --git a/ash/wm/mru_window_tracker.cc b/ash/wm/mru_window_tracker.cc index ef00dfc..0952f49 100644 --- a/ash/wm/mru_window_tracker.cc +++ b/ash/wm/mru_window_tracker.cc @@ -54,11 +54,8 @@ bool CompareWindowState(aura::Window* w1, aura::Window* w2) { // Returns a list of windows ordered by their stacking order. // If |mru_windows| is passed, these windows are moved to the front of the list. -// If |top_most_at_end|, the list is returned in descending (bottom-most / least -// recently used) order. MruWindowTracker::WindowList BuildWindowListInternal( - const std::list<aura::Window*>* mru_windows, - bool top_most_at_end) { + const std::list<aura::Window*>* mru_windows) { MruWindowTracker::WindowList windows; aura::Window::Windows root_windows = Shell::GetAllRootWindows(); @@ -115,8 +112,7 @@ MruWindowTracker::WindowList BuildWindowListInternal( std::stable_sort(windows.begin(), windows.end(), CompareWindowState); // Window cycling expects the topmost window at the front of the list. - if (!top_most_at_end) - std::reverse(windows.begin(), windows.end()); + std::reverse(windows.begin(), windows.end()); return windows; } @@ -143,13 +139,12 @@ MruWindowTracker::~MruWindowTracker() { } // static -MruWindowTracker::WindowList MruWindowTracker::BuildWindowList( - bool top_most_at_end) { - return BuildWindowListInternal(NULL, top_most_at_end); +MruWindowTracker::WindowList MruWindowTracker::BuildWindowList() { + return BuildWindowListInternal(NULL); } MruWindowTracker::WindowList MruWindowTracker::BuildMruWindowList() { - return BuildWindowListInternal(&mru_windows_, false); + return BuildWindowListInternal(&mru_windows_); } void MruWindowTracker::SetIgnoreActivations(bool ignore) { diff --git a/ash/wm/mru_window_tracker.h b/ash/wm/mru_window_tracker.h index 6f6dd5f..4ed06a3 100644 --- a/ash/wm/mru_window_tracker.h +++ b/ash/wm/mru_window_tracker.h @@ -40,10 +40,9 @@ class ASH_EXPORT MruWindowTracker // the vector based on the current set of windows across all valid root // windows. As a result it is not necessarily the same as the set of // windows being iterated over. - // If |top_most_at_end| the window list will return in ascending (lowest - // window in stacking order first) order instead of the default descending - // (top most window first) order. - static WindowList BuildWindowList(bool top_most_at_end); + // The returned window list will be in descending (top most window first) + // order. + static WindowList BuildWindowList(); // Returns the set of windows which can be cycled through using the tracked // list of most recently used windows. diff --git a/ash/wm/window_positioner.cc b/ash/wm/window_positioner.cc index 73b7d09..880abd1 100644 --- a/ash/wm/window_positioner.cc +++ b/ash/wm/window_positioner.cc @@ -192,7 +192,7 @@ aura::Window* GetReferenceWindow(const aura::Window* root_window, // Get a list of all windows. const std::vector<aura::Window*> windows = - ash::MruWindowTracker::BuildWindowList(false); + ash::MruWindowTracker::BuildWindowList(); if (windows.empty()) return NULL; @@ -504,7 +504,7 @@ gfx::Rect WindowPositioner::SmartPopupPosition( const gfx::Rect& work_area, int grid) { const std::vector<aura::Window*> windows = - MruWindowTracker::BuildWindowList(false); + MruWindowTracker::BuildWindowList(); std::vector<const gfx::Rect*> regions; // Process the window list and check if we can bail immediately. |